[PR PATCH] New package: spotify-player:0.13.1

[PR PATCH] New package: spotify-player:0.13.1

[f1nbar]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

There is a new pull request by f1nbar against master on the void-packages repository

https://github.com/f1nbar/void-packages spotify-player
https://github.com/void-linux/void-packages/pull/43324

New package: spotify-player:0.13.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: Yes

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): Yes

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-player-43324.patch --]
[-- Type: text/x-diff, Size: 1222 bytes --]

From 07d709ff377de761b4332c89f7abd5e60115f264 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Finbar=20=C3=93=20Deaghaidh?= <finbar@tutanota.com>
Date: Fri, 7 Apr 2023 16:40:32 +0100
Subject: [PATCH] New package: spotify-player:0.13.1

---
 srcpkgs/spotify-player/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/spotify-player/template

diff --git a/srcpkgs/spotify-player/template b/srcpkgs/spotify-player/template
new file mode 100644
index 000000000000..83f4a2fc5b05
--- /dev/null
+++ b/srcpkgs/spotify-player/template
@@ -0,0 +1,19 @@
+# Template file for 'spotify-player'
+pkgname=spotify-player
+version=0.13.1
+revision=1
+archs="x86_64"
+build_style=cargo
+make_install_args="--path spotify_player"
+makedepends="openssl-devel pkg-config alsa-lib-devel dbus-devel"
+depends="openssl alsa-lib"
+short_desc="Command driven spotify player"
+maintainer=" Thang Pham <phamducthang1234@gmail.com>"
+license="MIT"
+homepage="https://github.com/aome510/spotify-player"
+distfiles="https://github.com/aome510/spotify-player/archive/refs/tags/v${version}.tar.gz"
+checksum=0d63b9ebb52c349480d1f181b8b9e6f726189e61f67846b5ee183f51ae9900df
+
+post_install() {
+	vlicense LICENSE.md
+}

Re: [PR REVIEW] New package: spotify-player:0.13.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1160997816

Comment:
why restrict to x86_64 only? (not even musl variant)

Re: [PR REVIEW] New package: spotify-player:0.13.1

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1160997987

Comment:
not needed  as shlib dependencies are automatically resolved, see `common/shlibs`

Re: New package: spotify-player:0.13.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#issuecomment-1500708449

Comment:
please adjust the commit message according to CONTRIBUTING.md

Re: [PR PATCH] [Updated] New package: spotify-player:0.13.1

[f1nbar]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is an updated pull request by f1nbar against master on the void-packages repository

https://github.com/f1nbar/void-packages spotify-player
https://github.com/void-linux/void-packages/pull/43324

New package: spotify-player:0.13.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: Yes

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): Yes

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-player-43324.patch --]
[-- Type: text/x-diff, Size: 1185 bytes --]

From 8a6c04a5526a0d491653098131b4e8f0bc75c575 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Finbar=20=C3=93=20Deaghaidh?= <finbar@tutanota.com>
Date: Fri, 7 Apr 2023 16:40:32 +0100
Subject: [PATCH] New package: spotify-player-0.13.1

---
 srcpkgs/spotify-player/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/spotify-player/template

diff --git a/srcpkgs/spotify-player/template b/srcpkgs/spotify-player/template
new file mode 100644
index 000000000000..12bee0fa0c0b
--- /dev/null
+++ b/srcpkgs/spotify-player/template
@@ -0,0 +1,18 @@
+# Template file for 'spotify-player'
+pkgname=spotify-player
+version=0.13.1
+revision=1
+archs="*"
+build_style=cargo
+make_install_args="--path spotify_player"
+makedepends="openssl-devel pkg-config alsa-lib-devel dbus-devel"
+short_desc="Command driven spotify player"
+maintainer=" Thang Pham <phamducthang1234@gmail.com>"
+license="MIT"
+homepage="https://github.com/aome510/spotify-player"
+distfiles="https://github.com/aome510/spotify-player/archive/refs/tags/v${version}.tar.gz"
+checksum=0d63b9ebb52c349480d1f181b8b9e6f726189e61f67846b5ee183f51ae9900df
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: spotify-player:0.13.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1161155933

Comment:
this is the default value, remove it

Re: [PR PATCH] [Updated] New package: spotify-player:0.13.1

[f1nbar]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is an updated pull request by f1nbar against master on the void-packages repository

https://github.com/f1nbar/void-packages spotify-player
https://github.com/void-linux/void-packages/pull/43324

New package: spotify-player:0.13.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: Yes

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): Yes

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-player-43324.patch --]
[-- Type: text/x-diff, Size: 1207 bytes --]

From 83d838a005f62abc2d562caf4c9ce1fe04f383c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Finbar=20=C3=93=20Deaghaidh?= <finbar@tutanota.com>
Date: Fri, 7 Apr 2023 16:40:32 +0100
Subject: [PATCH] New package: spotify-player-0.13.1

---
 srcpkgs/spotify-player/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/spotify-player/template

diff --git a/srcpkgs/spotify-player/template b/srcpkgs/spotify-player/template
new file mode 100644
index 000000000000..5a7627673e81
--- /dev/null
+++ b/srcpkgs/spotify-player/template
@@ -0,0 +1,18 @@
+# Template file for 'spotify-player'
+pkgname=spotify-player
+version=0.13.1
+revision=1
+archs="x86_64 x86_64-musl i686"
+build_style=cargo
+make_install_args="--path spotify_player"
+makedepends="openssl-devel pkg-config alsa-lib-devel dbus-devel"
+short_desc="Command driven spotify player"
+maintainer=" Thang Pham <phamducthang1234@gmail.com>"
+license="MIT"
+homepage="https://github.com/aome510/spotify-player"
+distfiles="https://github.com/aome510/spotify-player/archive/refs/tags/v${version}.tar.gz"
+checksum=0d63b9ebb52c349480d1f181b8b9e6f726189e61f67846b5ee183f51ae9900df
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: spotify-player:0.13.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1161267719

Comment:
please remove the whole line and fix cross compilation by putting -devel packages to make depends instead of hostmakedepends

Re: [PR REVIEW] New package: spotify-player:0.13.1

[f1nbar]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by f1nbar on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1161271427

Comment:
The -devel packages are aleady in the make depends? And remove the arch line entirely?
Thank you for all the help, I will know all of this for next time :smile: 

Re: [PR REVIEW] New package: spotify-player:0.13.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1161275029

Comment:
oh, so the other way around, move pkg-config to hostmakedepends, it's not a library and provides a binary that has to run on the host

Re: [PR REVIEW] New package: spotify-player:0.13.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1161275029

Comment:
oh, so the other way around, move pkg-config to hostmakedepends, it's not a library and provides a binary that has to run on the host

yes, remove the archs line entirely, there should be no reason why this shouldn't work on all architectures we support. $archs is only used to restrict architectures if it doesn't work on those archs

Re: [PR PATCH] [Updated] New package: spotify-player:0.13.1

[f1nbar]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is an updated pull request by f1nbar against master on the void-packages repository

https://github.com/f1nbar/void-packages spotify-player
https://github.com/void-linux/void-packages/pull/43324

New package: spotify-player:0.13.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: Yes

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): Yes

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-player-43324.patch --]
[-- Type: text/x-diff, Size: 1193 bytes --]

From 7d44044eea060f1516b06b81f2b28ad23391cfd8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Finbar=20=C3=93=20Deaghaidh?= <finbar@tutanota.com>
Date: Fri, 7 Apr 2023 16:40:32 +0100
Subject: [PATCH] New package: spotify-player-0.13.1

---
 srcpkgs/spotify-player/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/spotify-player/template

diff --git a/srcpkgs/spotify-player/template b/srcpkgs/spotify-player/template
new file mode 100644
index 000000000000..cbac95f3d5b2
--- /dev/null
+++ b/srcpkgs/spotify-player/template
@@ -0,0 +1,18 @@
+# Template file for 'spotify-player'
+pkgname=spotify-player
+version=0.13.1
+revision=1
+build_style=cargo
+make_install_args="--path spotify_player"
+hostmakedepends="pkg-config"
+makedepends="openssl-devel alsa-lib-devel dbus-devel"
+short_desc="Command driven spotify player"
+maintainer=" Thang Pham <phamducthang1234@gmail.com>"
+license="MIT"
+homepage="https://github.com/aome510/spotify-player"
+distfiles="https://github.com/aome510/spotify-player/archive/refs/tags/v${version}.tar.gz"
+checksum=0d63b9ebb52c349480d1f181b8b9e6f726189e61f67846b5ee183f51ae9900df
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: spotify-player:0.13.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#discussion_r1161277391

Comment:
```suggestion
maintainer="Thang Pham <phamducthang1234@gmail.com>"
```

Re: [PR PATCH] [Updated] New package: spotify-player:0.13.1

[f1nbar]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

There is an updated pull request by f1nbar against master on the void-packages repository

https://github.com/f1nbar/void-packages spotify-player
https://github.com/void-linux/void-packages/pull/43324

New package: spotify-player:0.13.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: Yes

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): Yes

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43324.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-player-43324.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From 32fa22c9ebc0e487e9658997b296689401a335ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Finbar=20=C3=93=20Deaghaidh?= <finbar@tutanota.com>
Date: Fri, 7 Apr 2023 16:40:32 +0100
Subject: [PATCH] New package: spotify-player-0.13.1

---
 srcpkgs/spotify-player/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/spotify-player/template

diff --git a/srcpkgs/spotify-player/template b/srcpkgs/spotify-player/template
new file mode 100644
index 000000000000..07031e71cf4a
--- /dev/null
+++ b/srcpkgs/spotify-player/template
@@ -0,0 +1,18 @@
+# Template file for 'spotify-player'
+pkgname=spotify-player
+version=0.13.1
+revision=1
+build_style=cargo
+make_install_args="--path spotify_player"
+hostmakedepends="pkg-config"
+makedepends="openssl-devel alsa-lib-devel dbus-devel"
+short_desc="Command driven spotify player"
+maintainer="Thang Pham <phamducthang1234@gmail.com>"
+license="MIT"
+homepage="https://github.com/aome510/spotify-player"
+distfiles="https://github.com/aome510/spotify-player/archive/refs/tags/v${version}.tar.gz"
+checksum=0d63b9ebb52c349480d1f181b8b9e6f726189e61f67846b5ee183f51ae9900df
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: spotify-player:0.13.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/43324#issuecomment-1570826850

Comment:
Closed in 18c2b327a4351563f2f62926fd4fd45aeeb78e90.

Re: [PR PATCH] [Closed]: New package: spotify-player:0.13.1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

There's a closed pull request on the void-packages repository

New package: spotify-player:0.13.1
https://github.com/void-linux/void-packages/pull/43324

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: Yes

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): Yes

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->