Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] flite: add deps to flite-devel subpkg
@ 2023-05-21  1:49 chrysos349
  2023-05-25 18:26 ` ahesford
  2023-05-25 18:26 ` [PR PATCH] [Closed]: " ahesford
  0 siblings, 2 replies; 3+ messages in thread
From: chrysos349 @ 2023-05-21  1:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

There is a new pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages flite
https://github.com/void-linux/void-packages/pull/43982

flite: add deps to flite-devel subpkg
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

#### Note
flite is compiled with alsa, but there was no alsa in deps of a subpkg. I fixed it.

A patch file from https://github.com/void-linux/void-packages/pull/43982.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-flite-43982.patch --]
[-- Type: text/x-diff, Size: 925 bytes --]

From e5596ab3ab2c9346bc7d06e9920808572ed7b209 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Sun, 21 May 2023 04:45:31 +0300
Subject: [PATCH] flite: add deps to flite-devel subpkg

---
 srcpkgs/flite/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/flite/template b/srcpkgs/flite/template
index 85afadf8d84b..d422207636a6 100644
--- a/srcpkgs/flite/template
+++ b/srcpkgs/flite/template
@@ -1,7 +1,7 @@
 # Template file for 'flite'
 pkgname=flite
 version=2.2
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-shared --with-audio=alsa"
 makedepends="alsa-lib-devel"
@@ -18,7 +18,7 @@ post_install() {
 
 flite-devel_package() {
 	short_desc+=" - development files"
-	depends="flite>=${version}_${revision}"
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/include
 		vmove usr/lib/*.a

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: flite: add deps to flite-devel subpkg
  2023-05-21  1:49 [PR PATCH] flite: add deps to flite-devel subpkg chrysos349
@ 2023-05-25 18:26 ` ahesford
  2023-05-25 18:26 ` [PR PATCH] [Closed]: " ahesford
  1 sibling, 0 replies; 3+ messages in thread
From: ahesford @ 2023-05-25 18:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/43982#issuecomment-1563328921

Comment:
The `flightgear` package links `flite` but does not pull in `alsa-lib-devel`, suggesting that there is no strict requirement that ALSA headers or a library be present.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: flite: add deps to flite-devel subpkg
  2023-05-21  1:49 [PR PATCH] flite: add deps to flite-devel subpkg chrysos349
  2023-05-25 18:26 ` ahesford
@ 2023-05-25 18:26 ` ahesford
  1 sibling, 0 replies; 3+ messages in thread
From: ahesford @ 2023-05-25 18:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

There's a closed pull request on the void-packages repository

flite: add deps to flite-devel subpkg
https://github.com/void-linux/void-packages/pull/43982

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)

#### Note
flite is compiled with alsa, but there was no alsa in deps of a subpkg. I fixed it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-25 18:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-21  1:49 [PR PATCH] flite: add deps to flite-devel subpkg chrysos349
2023-05-25 18:26 ` ahesford
2023-05-25 18:26 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).