Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] i3status-rust: update to 0.31.5.
@ 2023-05-24 20:12 inalone
  2023-05-31 18:20 ` [PR REVIEW] " mhmdanas
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: inalone @ 2023-05-24 20:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

There is a new pull request by inalone against master on the void-packages repository

https://github.com/inalone/void-packages i3status-rust
https://github.com/void-linux/void-packages/pull/44067

i3status-rust: update to 0.31.5.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/44067.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-i3status-rust-44067.patch --]
[-- Type: text/x-diff, Size: 1547 bytes --]

From e59c62fee32f94bc6a24d49ca01595f1eb42657c Mon Sep 17 00:00:00 2001
From: inalone <me@inal.one>
Date: Wed, 24 May 2023 21:10:54 +0100
Subject: [PATCH] i3status-rust: update to 0.31.5.

---
 srcpkgs/i3status-rust/template | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/i3status-rust/template b/srcpkgs/i3status-rust/template
index 788270ca956f..9f67778165af 100644
--- a/srcpkgs/i3status-rust/template
+++ b/srcpkgs/i3status-rust/template
@@ -1,18 +1,23 @@
 # Template file for 'i3status-rust'
 pkgname=i3status-rust
-version=0.22.0
-revision=2
+version=0.31.5
+revision=1
 build_style=cargo
 make_check_args="--bins"
 hostmakedepends="pkg-config"
-makedepends="dbus-devel pulseaudio-devel openssl-devel libsensors-devel"
+makedepends="dbus-devel pulseaudio-devel openssl-devel libsensors-devel pandoc"
 short_desc="Replacement for i3status, written in Rust"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="GPL-3.0-only"
 homepage="https://github.com/greshake/i3status-rust"
 changelog="https://raw.githubusercontent.com/greshake/i3status-rust/master/NEWS.md"
 distfiles="https://github.com/greshake/i3status-rust/archive/refs/tags/v${version}.tar.gz"
-checksum=cd28a90ccb2f9faaaef1e528619f1018981609d77f409abe4877350d810d3324
+checksum=640df4ac85de4efbbc51fd4fa040bfa55270e9c04184f27aca9c427f8d86d3bf
+
+do_build() {
+	cargo auditable build --release --locked --target ${RUST_TARGET}
+	cargo xtask generate-manpage
+}
 
 post_install() {
 	vmkdir usr/share/i3status-rust

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] i3status-rust: update to 0.31.5.
  2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
@ 2023-05-31 18:20 ` mhmdanas
  2023-06-09  2:15 ` classabbyamp
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: mhmdanas @ 2023-05-31 18:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44067#discussion_r1212125195

Comment:
Why did you add `pandoc` to `makedepends` and not `hostmakedepends`? I'm surprised that this works at all to be honest.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] i3status-rust: update to 0.31.5.
  2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
  2023-05-31 18:20 ` [PR REVIEW] " mhmdanas
@ 2023-06-09  2:15 ` classabbyamp
  2023-06-09  2:18 ` classabbyamp
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-06-09  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44067#discussion_r1223758826

Comment:
it didn't work. CI "passed" because it ended with pandoc's nocross being triggered and no packages were built

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] i3status-rust: update to 0.31.5.
  2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
  2023-05-31 18:20 ` [PR REVIEW] " mhmdanas
  2023-06-09  2:15 ` classabbyamp
@ 2023-06-09  2:18 ` classabbyamp
  2023-06-09 11:35 ` mhmdanas
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-06-09  2:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44067#discussion_r1223758826

Comment:
it didn't work. CI "passed" for cross because it ended with pandoc's nocross being triggered and no packages were built

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] i3status-rust: update to 0.31.5.
  2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
                   ` (2 preceding siblings ...)
  2023-06-09  2:18 ` classabbyamp
@ 2023-06-09 11:35 ` mhmdanas
  2023-06-25 17:14 ` classabbyamp
  2023-08-16 11:54 ` [PR PATCH] [Closed]: " inalone
  5 siblings, 0 replies; 7+ messages in thread
From: mhmdanas @ 2023-06-09 11:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44067#discussion_r1224191806

Comment:
Oh, haha, weird stuff.

@inalone you should put pandoc in hostmakedepends instead of makedepends then.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] i3status-rust: update to 0.31.5.
  2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
                   ` (3 preceding siblings ...)
  2023-06-09 11:35 ` mhmdanas
@ 2023-06-25 17:14 ` classabbyamp
  2023-08-16 11:54 ` [PR PATCH] [Closed]: " inalone
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-06-25 17:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44067#discussion_r1241241600

Comment:
```suggestion
post_build() {
	cargo xtask generate-manpage
}
```


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: i3status-rust: update to 0.31.5.
  2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
                   ` (4 preceding siblings ...)
  2023-06-25 17:14 ` classabbyamp
@ 2023-08-16 11:54 ` inalone
  5 siblings, 0 replies; 7+ messages in thread
From: inalone @ 2023-08-16 11:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

There's a closed pull request on the void-packages repository

i3status-rust: update to 0.31.5.
https://github.com/void-linux/void-packages/pull/44067

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-08-16 11:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-24 20:12 [PR PATCH] i3status-rust: update to 0.31.5 inalone
2023-05-31 18:20 ` [PR REVIEW] " mhmdanas
2023-06-09  2:15 ` classabbyamp
2023-06-09  2:18 ` classabbyamp
2023-06-09 11:35 ` mhmdanas
2023-06-25 17:14 ` classabbyamp
2023-08-16 11:54 ` [PR PATCH] [Closed]: " inalone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).