Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] helix: switch from launcher script to symlink
@ 2023-05-30 12:42 tranzystorek-io
  2023-06-09  1:53 ` [PR PATCH] [Merged]: " classabbyamp
  0 siblings, 1 reply; 2+ messages in thread
From: tranzystorek-io @ 2023-05-30 12:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

There is a new pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages helix-symlink
https://github.com/void-linux/void-packages/pull/44168

helix: switch from launcher script to symlink
<!-- Uncomment relevant sections and delete options which are not applicable -->

Allows users to set their own `HELIX_RUNTIME` variable and also autodetect the system runtime dir `/usr/lib/helix/runtime`

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44168.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-helix-symlink-44168.patch --]
[-- Type: text/x-diff, Size: 1339 bytes --]

From 1ce18db5497dbe754ffe16451a0976bcf8d25bcd Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Tue, 30 May 2023 14:38:43 +0200
Subject: [PATCH] helix: switch from launcher script to symlink

---
 srcpkgs/helix/files/hx | 2 --
 srcpkgs/helix/template | 6 +++---
 2 files changed, 3 insertions(+), 5 deletions(-)
 delete mode 100644 srcpkgs/helix/files/hx

diff --git a/srcpkgs/helix/files/hx b/srcpkgs/helix/files/hx
deleted file mode 100644
index a43e49fadc5b..000000000000
--- a/srcpkgs/helix/files/hx
+++ /dev/null
@@ -1,2 +0,0 @@
-#!/bin/sh
-HELIX_RUNTIME=/usr/lib/helix/runtime exec /usr/lib/helix/hx "$@"
diff --git a/srcpkgs/helix/template b/srcpkgs/helix/template
index f920843b9ce4..ee11896d0803 100644
--- a/srcpkgs/helix/template
+++ b/srcpkgs/helix/template
@@ -1,7 +1,7 @@
 # Template file for 'helix'
 pkgname=helix
 version=23.05
-revision=1
+revision=2
 build_style=cargo
 make_install_args="--path helix-term"
 short_desc="Post-modern modal text editor"
@@ -30,7 +30,7 @@ post_install() {
 	vinstall contrib/helix.png 644 usr/share/icons/hicolor/128x128/apps
 
 	vmkdir usr/lib/helix
-	mv ${DESTDIR}/usr/bin/hx ${DESTDIR}/usr/lib/helix/
 	vcopy runtime usr/lib/helix
-	vbin ${FILESDIR}/hx
+	mv ${DESTDIR}/usr/bin/hx ${DESTDIR}/usr/lib/helix/
+	ln -s /usr/lib/helix/hx ${DESTDIR}/usr/bin/
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: helix: switch from launcher script to symlink
  2023-05-30 12:42 [PR PATCH] helix: switch from launcher script to symlink tranzystorek-io
@ 2023-06-09  1:53 ` classabbyamp
  0 siblings, 0 replies; 2+ messages in thread
From: classabbyamp @ 2023-06-09  1:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

There's a merged pull request on the void-packages repository

helix: switch from launcher script to symlink
https://github.com/void-linux/void-packages/pull/44168

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Allows users to set their own `HELIX_RUNTIME` variable and also autodetect the system runtime dir `/usr/lib/helix/runtime`

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-09  1:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 12:42 [PR PATCH] helix: switch from launcher script to symlink tranzystorek-io
2023-06-09  1:53 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).