From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] dkms install --force
Date: Tue, 30 May 2023 17:57:34 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44171@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
There is a new pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages dkms-force
https://github.com/void-linux/void-packages/pull/44171
dkms install --force
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/44171.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dkms-force-44171.patch --]
[-- Type: text/x-diff, Size: 3814 bytes --]
From b63c19c727e880fdf2d38bfa71f772e4a2fcc56e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 30 May 2023 13:51:06 +0700
Subject: [PATCH 1/2] dkms: force dkms install
Whenever the installing step is failing, for some reasons,
all subsequent installing step will run into failure,
except when --force is passed.
---
srcpkgs/dkms/files/kernel.d/dkms.postinst | 2 +-
srcpkgs/dkms/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/dkms/files/kernel.d/dkms.postinst b/srcpkgs/dkms/files/kernel.d/dkms.postinst
index 6b345bef9050..66d22981b517 100644
--- a/srcpkgs/dkms/files/kernel.d/dkms.postinst
+++ b/srcpkgs/dkms/files/kernel.d/dkms.postinst
@@ -87,7 +87,7 @@ while [ $# -gt 1 ]; do
if [ $(echo "$status"|grep -c ": built") -eq 1 ] &&
[ $(echo "$status"|grep -c ": installed") -eq 0 ]; then
echo -n "Installing DKMS module: ${module}-${modulever}... "
- /usr/bin/dkms install -q -m ${module} -v ${modulever} -k ${VERSION} -a ${ARCH}
+ /usr/bin/dkms install --force -q -m ${module} -v ${modulever} -k ${VERSION} -a ${ARCH}
rval=$?
# If the module failed installation, go to the next module.
if [ $rval -eq 0 ]; then
diff --git a/srcpkgs/dkms/template b/srcpkgs/dkms/template
index 5da51b101a8c..34ee6c4afabb 100644
--- a/srcpkgs/dkms/template
+++ b/srcpkgs/dkms/template
@@ -1,7 +1,7 @@
# Template file for 'dkms'
pkgname=dkms
version=3.0.10
-revision=1
+revision=2
conf_files="/etc/dkms/framework.conf"
depends="bash kmod gcc make coreutils xbps-triggers>=0.123_1"
short_desc="Dynamic Kernel Module Support"
From cc62e6e44aaf31b10b440a35913b2ec1b82e85f9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 30 May 2023 13:52:08 +0700
Subject: [PATCH 2/2] xbps-triggers: update to 0.125.
`dkms install` with `--force`, for some reasons, my initial installing
of some dkms modules was failing, the subsequent installing run into
failure too, except when `--force` has been passed in. `--force` seems
to be the correct flags for all invocation of `dkms` because it will be
invoked either by `xbps-install` (`--force` is harmless there),
or `xbps-install -yff` or `xbps-reconfigure`,
which obviously need `--force`.
While we're at it, invoke `dkms` in quiet mode because we will dump dkms
into /dev/null anyway.
---
srcpkgs/xbps-triggers/files/dkms | 4 ++--
srcpkgs/xbps-triggers/template | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/xbps-triggers/files/dkms b/srcpkgs/xbps-triggers/files/dkms
index 6b285c576b53..ae87f3bff838 100755
--- a/srcpkgs/xbps-triggers/files/dkms
+++ b/srcpkgs/xbps-triggers/files/dkms
@@ -89,7 +89,7 @@ add_modules() {
set -- ${dkms_modules}
while [ $# -gt 0 ]; do
echo -n "Building DKMS module '$1-$2' for kernel-${_kver}... "
- $DKMS build -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
+ $DKMS build -q -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
if [ $? -eq 0 ]; then
echo "done."
else
@@ -99,7 +99,7 @@ add_modules() {
shift 2; continue
fi
echo -n "Installing DKMS module '$1-$2' for kernel-${_kver}... "
- $DKMS install -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
+ $DKMS install --force -q -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
if [ $? -eq 0 ]; then
echo "done."
else
diff --git a/srcpkgs/xbps-triggers/template b/srcpkgs/xbps-triggers/template
index aa62e0902528..89cc9398c8c4 100644
--- a/srcpkgs/xbps-triggers/template
+++ b/srcpkgs/xbps-triggers/template
@@ -1,6 +1,6 @@
# Template file for 'xbps-triggers'
pkgname=xbps-triggers
-version=0.124
+version=0.125
revision=1
bootstrap=yes
short_desc="XBPS triggers for Void Linux"
next reply other threads:[~2023-05-30 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:57 sgn [this message]
2023-06-09 2:01 ` ahesford
2023-06-09 2:03 ` classabbyamp
2023-06-21 2:54 ` dexgs
2023-06-21 9:56 ` [PR PATCH] [Merged]: " sgn
2023-06-21 9:56 ` sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44171@inbox.vuxu.org \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).