* [PR PATCH] dkms install --force
@ 2023-05-30 15:57 sgn
2023-06-09 2:01 ` ahesford
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: sgn @ 2023-05-30 15:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]
There is a new pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages dkms-force
https://github.com/void-linux/void-packages/pull/44171
dkms install --force
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/44171.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dkms-force-44171.patch --]
[-- Type: text/x-diff, Size: 3814 bytes --]
From b63c19c727e880fdf2d38bfa71f772e4a2fcc56e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 30 May 2023 13:51:06 +0700
Subject: [PATCH 1/2] dkms: force dkms install
Whenever the installing step is failing, for some reasons,
all subsequent installing step will run into failure,
except when --force is passed.
---
srcpkgs/dkms/files/kernel.d/dkms.postinst | 2 +-
srcpkgs/dkms/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/dkms/files/kernel.d/dkms.postinst b/srcpkgs/dkms/files/kernel.d/dkms.postinst
index 6b345bef9050..66d22981b517 100644
--- a/srcpkgs/dkms/files/kernel.d/dkms.postinst
+++ b/srcpkgs/dkms/files/kernel.d/dkms.postinst
@@ -87,7 +87,7 @@ while [ $# -gt 1 ]; do
if [ $(echo "$status"|grep -c ": built") -eq 1 ] &&
[ $(echo "$status"|grep -c ": installed") -eq 0 ]; then
echo -n "Installing DKMS module: ${module}-${modulever}... "
- /usr/bin/dkms install -q -m ${module} -v ${modulever} -k ${VERSION} -a ${ARCH}
+ /usr/bin/dkms install --force -q -m ${module} -v ${modulever} -k ${VERSION} -a ${ARCH}
rval=$?
# If the module failed installation, go to the next module.
if [ $rval -eq 0 ]; then
diff --git a/srcpkgs/dkms/template b/srcpkgs/dkms/template
index 5da51b101a8c..34ee6c4afabb 100644
--- a/srcpkgs/dkms/template
+++ b/srcpkgs/dkms/template
@@ -1,7 +1,7 @@
# Template file for 'dkms'
pkgname=dkms
version=3.0.10
-revision=1
+revision=2
conf_files="/etc/dkms/framework.conf"
depends="bash kmod gcc make coreutils xbps-triggers>=0.123_1"
short_desc="Dynamic Kernel Module Support"
From cc62e6e44aaf31b10b440a35913b2ec1b82e85f9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Tue, 30 May 2023 13:52:08 +0700
Subject: [PATCH 2/2] xbps-triggers: update to 0.125.
`dkms install` with `--force`, for some reasons, my initial installing
of some dkms modules was failing, the subsequent installing run into
failure too, except when `--force` has been passed in. `--force` seems
to be the correct flags for all invocation of `dkms` because it will be
invoked either by `xbps-install` (`--force` is harmless there),
or `xbps-install -yff` or `xbps-reconfigure`,
which obviously need `--force`.
While we're at it, invoke `dkms` in quiet mode because we will dump dkms
into /dev/null anyway.
---
srcpkgs/xbps-triggers/files/dkms | 4 ++--
srcpkgs/xbps-triggers/template | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/xbps-triggers/files/dkms b/srcpkgs/xbps-triggers/files/dkms
index 6b285c576b53..ae87f3bff838 100755
--- a/srcpkgs/xbps-triggers/files/dkms
+++ b/srcpkgs/xbps-triggers/files/dkms
@@ -89,7 +89,7 @@ add_modules() {
set -- ${dkms_modules}
while [ $# -gt 0 ]; do
echo -n "Building DKMS module '$1-$2' for kernel-${_kver}... "
- $DKMS build -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
+ $DKMS build -q -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
if [ $? -eq 0 ]; then
echo "done."
else
@@ -99,7 +99,7 @@ add_modules() {
shift 2; continue
fi
echo -n "Installing DKMS module '$1-$2' for kernel-${_kver}... "
- $DKMS install -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
+ $DKMS install --force -q -m "$1" -v "$2" -k "${_kver}" >/dev/null 2>&1
if [ $? -eq 0 ]; then
echo "done."
else
diff --git a/srcpkgs/xbps-triggers/template b/srcpkgs/xbps-triggers/template
index aa62e0902528..89cc9398c8c4 100644
--- a/srcpkgs/xbps-triggers/template
+++ b/srcpkgs/xbps-triggers/template
@@ -1,6 +1,6 @@
# Template file for 'xbps-triggers'
pkgname=xbps-triggers
-version=0.124
+version=0.125
revision=1
bootstrap=yes
short_desc="XBPS triggers for Void Linux"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dkms install --force
2023-05-30 15:57 [PR PATCH] dkms install --force sgn
@ 2023-06-09 2:01 ` ahesford
2023-06-09 2:03 ` classabbyamp
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2023-06-09 2:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44171#issuecomment-1583827677
Comment:
This is probably reasonable. Does it fix some known problem?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dkms install --force
2023-05-30 15:57 [PR PATCH] dkms install --force sgn
2023-06-09 2:01 ` ahesford
@ 2023-06-09 2:03 ` classabbyamp
2023-06-21 2:54 ` dexgs
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-06-09 2:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/44171#issuecomment-1583828964
Comment:
I think the problem fixed is listed in the full commit messages
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dkms install --force
2023-05-30 15:57 [PR PATCH] dkms install --force sgn
2023-06-09 2:01 ` ahesford
2023-06-09 2:03 ` classabbyamp
@ 2023-06-21 2:54 ` dexgs
2023-06-21 9:56 ` [PR PATCH] [Merged]: " sgn
2023-06-21 9:56 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: dexgs @ 2023-06-21 2:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
New comment by dexgs on void-packages repository
https://github.com/void-linux/void-packages/pull/44171#issuecomment-1599996546
Comment:
I just ran into this: I tried to downgrade the nvidia driver and the dkms hook wouldn't succeed because `dkms` won't install a less recent version of a module without the `--force` flag.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: dkms install --force
2023-05-30 15:57 [PR PATCH] dkms install --force sgn
` (2 preceding siblings ...)
2023-06-21 2:54 ` dexgs
@ 2023-06-21 9:56 ` sgn
2023-06-21 9:56 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2023-06-21 9:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
There's a merged pull request on the void-packages repository
dkms install --force
https://github.com/void-linux/void-packages/pull/44171
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: dkms install --force
2023-05-30 15:57 [PR PATCH] dkms install --force sgn
` (3 preceding siblings ...)
2023-06-21 9:56 ` [PR PATCH] [Merged]: " sgn
@ 2023-06-21 9:56 ` sgn
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2023-06-21 9:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/44171#issuecomment-1600543567
Comment:
OK, let's merge.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-21 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 15:57 [PR PATCH] dkms install --force sgn
2023-06-09 2:01 ` ahesford
2023-06-09 2:03 ` classabbyamp
2023-06-21 2:54 ` dexgs
2023-06-21 9:56 ` [PR PATCH] [Merged]: " sgn
2023-06-21 9:56 ` sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).