* [PR PATCH] nextcloud-client: update to 3.8.2, adopt
@ 2023-05-30 23:01 mdkcore0
2023-05-30 23:12 ` mdkcore0
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: mdkcore0 @ 2023-05-30 23:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
There is a new pull request by mdkcore0 against master on the void-packages repository
https://github.com/mdkcore0/void-packages update-nextcloud
https://github.com/void-linux/void-packages/pull/44186
nextcloud-client: update to 3.8.2, adopt
I am removing the patch to disable update check, use _BUILD_UPDATER=NO_ flag instead (https://github.com/nextcloud/desktop/pull/1847)
I've talked to @yopito by e-mail and he is fine in me adopting this package.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-libc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- armv7l (crossbuild)
- i686-libc
A patch file from https://github.com/void-linux/void-packages/pull/44186.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-nextcloud-44186.patch --]
[-- Type: text/x-diff, Size: 3255 bytes --]
From 5b6074df9f637b5be85a7ef77e0ceb64f28edd7e Mon Sep 17 00:00:00 2001
From: Rodrigo Oliveira <mdkcore@qtrnn.io>
Date: Tue, 7 Mar 2023 13:22:56 -0300
Subject: [PATCH] nextcloud-client: update to 3.8.2, adopt
Also:
- Remove patch to disable update check, use BUILD_UPDATER=NO flag
instead [1]
[1] https://github.com/nextcloud/desktop/pull/1847
---
...heck-for-updates-disabled-as-default.patch | 24 -------------------
srcpkgs/nextcloud-client/template | 8 +++----
2 files changed, 4 insertions(+), 28 deletions(-)
delete mode 100644 srcpkgs/nextcloud-client/patches/check-for-updates-disabled-as-default.patch
diff --git a/srcpkgs/nextcloud-client/patches/check-for-updates-disabled-as-default.patch b/srcpkgs/nextcloud-client/patches/check-for-updates-disabled-as-default.patch
deleted file mode 100644
index dec501c628f2..000000000000
--- a/srcpkgs/nextcloud-client/patches/check-for-updates-disabled-as-default.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-Set check for updates option as false by default
-
---- a/src/gui/generalsettings.ui
-+++ b/src/gui/generalsettings.ui
-@@ -114,7 +114,7 @@
- <string>&Automatically check for Updates</string>
- </property>
- <property name="checked">
-- <bool>true</bool>
-+ <bool>false</bool>
- </property>
- </widget>
- </item>
---- a/src/libsync/configfile.cpp
-+++ b/src/libsync/configfile.cpp
-@@ -631,7 +631,7 @@ bool ConfigFile::autoUpdateCheck(const QString &connection) const
- if (connection.isEmpty())
- con = defaultConnection();
-
-- QVariant fallback = getValue(QLatin1String(autoUpdateCheckC), con, true);
-+ QVariant fallback = getValue(QLatin1String(autoUpdateCheckC), con, false);
- fallback = getValue(QLatin1String(autoUpdateCheckC), QString(), fallback);
-
- QVariant value = getPolicySetting(QLatin1String(autoUpdateCheckC), fallback);
diff --git a/srcpkgs/nextcloud-client/template b/srcpkgs/nextcloud-client/template
index 27502262b8fa..8d667180293f 100644
--- a/srcpkgs/nextcloud-client/template
+++ b/srcpkgs/nextcloud-client/template
@@ -1,9 +1,9 @@
# Template file for 'nextcloud-client'
pkgname=nextcloud-client
-version=3.8.1
+version=3.8.2
revision=1
build_style=cmake
-configure_args="-Wno-dev"
+configure_args="-DBUILD_UPDATER=NO -Wno-dev"
hostmakedepends="pkg-config inkscape"
makedepends="qt5-tools-devel qt5-declarative-devel qt5-webchannel-devel
qt5-location-devel qtkeychain-qt5-devel sqlite-devel libcloudproviders-devel
@@ -14,12 +14,12 @@ depends="qt5-graphicaleffects"
checkdepends="cmocka-devel"
conf_files="/etc/Nextcloud/sync-exclude.lst"
short_desc="NextCloud Desktop client"
-maintainer="yopito <pierre.bourgin@free.fr>"
+maintainer="Rodrigo Oliveira <mdkcore@qtrnn.io>"
license="GPL-2.0-or-later"
homepage="https://nextcloud.com/clients/"
changelog="https://github.com/nextcloud/desktop/releases"
distfiles="https://github.com/nextcloud/desktop/archive/v${version}.tar.gz"
-checksum=f919a09c261039ddb8fcb6c10f10b1c6a8a31f64bf9b8b14ff46b5d02e428afc
+checksum=6186aaa70b82b06b4531cff2e55e0dd38a0d817de7ef039a81293d82cb05e8c0
# https://github.com/void-linux/void-packages/pull/33358#discussion_r724518549
make_check=ci-skip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nextcloud-client: update to 3.8.2, adopt
2023-05-30 23:01 [PR PATCH] nextcloud-client: update to 3.8.2, adopt mdkcore0
@ 2023-05-30 23:12 ` mdkcore0
2023-05-31 13:13 ` realcharmer
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: mdkcore0 @ 2023-05-30 23:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
New comment by mdkcore0 on void-packages repository
https://github.com/void-linux/void-packages/pull/44186#issuecomment-1569257385
Comment:
3.8.1 with patch to disable update check
![nextcloud-3 8 1](https://github.com/void-linux/void-packages/assets/1218078/bd763a8d-fbeb-4349-99ee-7f742a51dcfc)
3.8.2 with `BUILD_UPDATER=NO`
![nextcloud-3 8 2](https://github.com/void-linux/void-packages/assets/1218078/c5db7f6b-f776-4385-9f89-2698ee1a72ce)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nextcloud-client: update to 3.8.2, adopt
2023-05-30 23:01 [PR PATCH] nextcloud-client: update to 3.8.2, adopt mdkcore0
2023-05-30 23:12 ` mdkcore0
@ 2023-05-31 13:13 ` realcharmer
2023-05-31 20:58 ` yopito
2023-06-09 1:09 ` [PR PATCH] [Merged]: " classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: realcharmer @ 2023-05-31 13:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by realcharmer on void-packages repository
https://github.com/void-linux/void-packages/pull/44186#issuecomment-1570212962
Comment:
Quick regression testing on `x86_64-glibc` shows no issues. Nice work.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nextcloud-client: update to 3.8.2, adopt
2023-05-30 23:01 [PR PATCH] nextcloud-client: update to 3.8.2, adopt mdkcore0
2023-05-30 23:12 ` mdkcore0
2023-05-31 13:13 ` realcharmer
@ 2023-05-31 20:58 ` yopito
2023-06-09 1:09 ` [PR PATCH] [Merged]: " classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: yopito @ 2023-05-31 20:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New comment by yopito on void-packages repository
https://github.com/void-linux/void-packages/pull/44186#issuecomment-1570945887
Comment:
I agree with the adoption; thanks for your packaging effort.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: nextcloud-client: update to 3.8.2, adopt
2023-05-30 23:01 [PR PATCH] nextcloud-client: update to 3.8.2, adopt mdkcore0
` (2 preceding siblings ...)
2023-05-31 20:58 ` yopito
@ 2023-06-09 1:09 ` classabbyamp
3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2023-06-09 1:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
There's a merged pull request on the void-packages repository
nextcloud-client: update to 3.8.2, adopt
https://github.com/void-linux/void-packages/pull/44186
Description:
I am removing the patch to disable update check, use _BUILD_UPDATER=NO_ flag instead (https://github.com/nextcloud/desktop/pull/1847)
I've talked to @yopito by e-mail and he is fine in me adopting this package.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-libc
- I built this PR locally for these architectures:
- armv7l (crossbuild)
- i686-libc
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-09 1:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 23:01 [PR PATCH] nextcloud-client: update to 3.8.2, adopt mdkcore0
2023-05-30 23:12 ` mdkcore0
2023-05-31 13:13 ` realcharmer
2023-05-31 20:58 ` yopito
2023-06-09 1:09 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).