[PR PATCH] qt6-webengine: enable proprietary codecs

[PR PATCH] qt6-webengine: enable proprietary codecs

[xegrox]

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

There is a new pull request by xegrox against master on the void-packages repository

https://github.com/xegrox/void-packages master
https://github.com/void-linux/void-packages/pull/44293

qt6-webengine: enable proprietary codecs
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

[ci skip]


A patch file from https://github.com/void-linux/void-packages/pull/44293.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-44293.patch --]
[-- Type: text/x-diff, Size: 793 bytes --]

From 951dbfce28d560b67a57f226b2e0e1523036a516 Mon Sep 17 00:00:00 2001
From: xegrox <52340924+xegrox@users.noreply.github.com>
Date: Tue, 6 Jun 2023 16:30:58 +0800
Subject: [PATCH] qt6-webengine: enable proprietary codecs

---
 srcpkgs/qt6-webengine/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/qt6-webengine/template b/srcpkgs/qt6-webengine/template
index 4e22cb6e8863..ea45a8c552e7 100644
--- a/srcpkgs/qt6-webengine/template
+++ b/srcpkgs/qt6-webengine/template
@@ -10,6 +10,7 @@ configure_args="
  -DQT_FEATURE_webengine_system_icu=ON
  -DQT_FEATURE_webengine_webrtc_pipewire=ON
  -DQT_FEATURE_webengine_embedded_build=OFF
+ -DQT_FEATURE_webengine_proprietary_codecs=ON
  -DQT_FEATURE_pdf_v8=ON
  -DNinja_EXECUTABLE=$XBPS_WRAPPERDIR/ninja
  -DQT_BUILD_EXAMPLES=ON"

Re: qt6-webengine: enable proprietary codecs

[sgn]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44293#issuecomment-1579801801

Comment:
No, enable proprietary codecs will prevent us from redistribution.

Re: [PR PATCH] [Closed]: qt6-webengine: enable proprietary codecs

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

There's a closed pull request on the void-packages repository

qt6-webengine: enable proprietary codecs
https://github.com/void-linux/void-packages/pull/44293

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

[ci skip]

Re: qt6-webengine: enable proprietary codecs

[xegrox]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

New comment by xegrox on void-packages repository

https://github.com/void-linux/void-packages/pull/44293#issuecomment-1581804485

Comment:
> No, enable proprietary codecs will prevent us from redistribution.

Sorry don't quite understand why, this flag only tells qt6-webengine to recognize proprietary codecs and does not ship any additional codecs? The user is free to choose open source codec implementations (e.g. x264) or a proprietary one (e.g. h264), so wouldn't any licensing issues lie with the user?

also this flag is already enabled for qt5-webengine

https://github.com/void-linux/void-packages/blob/master/srcpkgs/qt5-webengine/template#L12

Re: qt6-webengine: enable proprietary codecs

[sgn]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44293#issuecomment-1581919519

Comment:
Then we should disable it on Qt5 instead.

See https://bugs.chromium.org/p/chromium/issues/detail?id=795935

Re: qt6-webengine: enable proprietary codecs

[sgn]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44293#issuecomment-1581923115

Comment:
Hm, I guess I was wrong. Chromium team build Chromium with bundled FFMEG, thus disabling proprietary codecs. We build Qt6 with system FFMEG, thus enabling is fine, since Qt6-WebEngine will use whatever enabled by FFMEG.

Re: qt6-webengine: enable proprietary codecs

[sgn]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44293#issuecomment-1694220900

Comment:
Tagging myself, so it's in my backlog.

Re: qt6-webengine: enable proprietary codecs

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44293#issuecomment-1711986417

Comment:
This fixes video playback in qutebrowser. Can you bump the revision so that this change will trigger a rebuild of the package?

Re: [PR PATCH] [Closed]: qt6-webengine: enable proprietary codecs

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

There's a closed pull request on the void-packages repository

qt6-webengine: enable proprietary codecs
https://github.com/void-linux/void-packages/pull/44293

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

[ci skip]