[PR PATCH] Signal-Desktop: update to 6.20.1.

[PR PATCH] Signal-Desktop: update to 6.20.1.

[akierig]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

There is a new pull request by akierig against master on the void-packages repository

https://github.com/akierig/void-packages signal-6.20.1
https://github.com/void-linux/void-packages/pull/44302

Signal-Desktop: update to 6.20.1.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/44302.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signal-6.20.1-44302.patch --]
[-- Type: text/x-diff, Size: 1950 bytes --]

From 2d799c8f93ebae39894b1a68466a296cc079c038 Mon Sep 17 00:00:00 2001
From: anelki <akierig@fastmail.de>
Date: Tue, 6 Jun 2023 20:24:30 -0500
Subject: [PATCH] Signal-Desktop: update to 6.20.1.

---
 srcpkgs/Signal-Desktop/template | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/Signal-Desktop/template b/srcpkgs/Signal-Desktop/template
index fec02583a29a..7eca75b4f1f5 100644
--- a/srcpkgs/Signal-Desktop/template
+++ b/srcpkgs/Signal-Desktop/template
@@ -1,38 +1,34 @@
 # Template file for 'Signal-Desktop'
 pkgname=Signal-Desktop
-version=6.20.0
+version=6.20.1
 revision=1
 # Signal officially only supports x86_64 
 # x86_64-musl could potentially work based on the Alpine port:
 # https://git.alpinelinux.org/aports/tree/testing/signal-desktop
 # ARM: https://github.com/signalapp/Signal-Desktop/issues/3410
 archs="x86_64"
-hostmakedepends="git git-lfs nodeenv python3 tar"
+hostmakedepends="git git-lfs nodejs python3 tar"
 depends="cairo gtk+3 libvips pango"
 short_desc="Signal Private Messenger for Linux"
 maintainer="anelki <akierig@fastmail.de>"
 license="AGPL-3.0-only"
 homepage="https://github.com/signalapp/Signal-Desktop"
 distfiles="https://github.com/signalapp/Signal-Desktop/archive/v${version}.tar.gz"
-checksum=fc92011c51da6792215eb92d48afc17f1967caeade1307daaa13884244d7a3b0
+checksum=3c664dbb5c1670554859fa55fd765ac35632f573fd5b7bea63876cdf41b6b7d6
 nostrip_files="signal-desktop"
 
 post_extract() {
 	# git-lfs hook needs to be installed for one of the dependencies
 	git lfs install
 
-	# use nodeenv since we have that in the repos already
-	nodeenv --node='18.14.0' signal-node
-	. ./signal-node/bin/activate
+	vsed 's/"node": "/&>=/' -i package.json
 
 	npm install -g yarn
-
 	# Dependencies have to be installed before applying patch
 	yarn install --ignore-engines --frozen-lockfile
 }
 
 do_build() {
-	. ./signal-node/bin/activate
 	yarn generate
 	yarn build-release
 }

Re: [PR REVIEW] Signal-Desktop: update to 6.20.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/44302#discussion_r1221570245

Comment:
is this still necessary?

Re: [PR REVIEW] Signal-Desktop: update to 6.20.1.

[akierig]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New review comment by akierig on void-packages repository

https://github.com/void-linux/void-packages/pull/44302#discussion_r1221711692

Comment:
yes, our node is 18.16, the package.json file specifies 18.14 specifically. 

https://github.com/signalapp/Signal-Desktop/blob/7ec64823bdce91f2e6802566dfe9963f5b9b5363/package.json#L320

Re: [PR PATCH] [Merged]: Signal-Desktop: update to 6.20.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

There's a merged pull request on the void-packages repository

Signal-Desktop: update to 6.20.1.
https://github.com/void-linux/void-packages/pull/44302

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64