[PR PATCH] curl: disable ssh option to break build cycle

[PR PATCH] curl: disable ssh option to break build cycle

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages curly-queue
https://github.com/void-linux/void-packages/pull/44336

curl: disable ssh option to break build cycle
Now that libssh2 builds with cmake, enabling SSH support in curl introduces a build cycle:

    binutils -> elfutils -> curl -> libssh2 -> cmake -> curl

Because SSH support in curl seems superfluous anyway, just disable it.

The other alternative is to go back to autotools for libssh2. I don't know if that's a long-term solution, but it seems possible for now.

A patch file from https://github.com/void-linux/void-packages/pull/44336.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-curly-queue-44336.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From d6833a2147ea27859f4a87cd50b5c617e92fb4ea Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Fri, 9 Jun 2023 15:22:27 -0400
Subject: [PATCH] curl: disable ssh option to break build cycle

Now that libssh2 builds with cmake, enabling SSH support in curl
introduces a build cycle:

    binutils -> elfutils -> curl -> libssh2 -> cmake -> curl

Because SSH support in curl seems superfluous anyway, just disable it.
---
 srcpkgs/curl/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/curl/template b/srcpkgs/curl/template
index 1ce72a58c188..b43961934747 100644
--- a/srcpkgs/curl/template
+++ b/srcpkgs/curl/template
@@ -1,7 +1,7 @@
 # Template file for 'curl'
 pkgname=curl
 version=8.0.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="ac_cv_sizeof_off_t=8 --enable-threaded-resolver --enable-ipv6
  --enable-websockets --with-random=/dev/urandom
@@ -27,7 +27,7 @@ changelog="https://curl.haxx.se/changes.html#${version//./_}"
 distfiles="${homepage}/download/curl-${version}.tar.bz2"
 checksum=9b6b1e96b748d04b968786b6bdf407aa5c75ab53a3d37c1c8c81cdb736555ccf
 build_options="gnutls gssapi ldap rtmp ssh ssl zstd"
-build_options_default="ssh ssl zstd"
+build_options_default="ssl zstd"
 vopt_conflict ssl gnutls
 
 if [ "$CROSS_BUILD" ]; then

Re: curl: disable ssh option to break build cycle

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44336#issuecomment-1585063733

Comment:
+1 for this over going back to autotools, I think

Re: [PR PATCH] [Merged]: curl: disable ssh option to break build cycle

[abenson]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

There's a merged pull request on the void-packages repository

curl: disable ssh option to break build cycle
https://github.com/void-linux/void-packages/pull/44336

Description:
Now that libssh2 builds with cmake, enabling SSH support in curl introduces a build cycle:

    binutils -> elfutils -> curl -> libssh2 -> cmake -> curl

Because SSH support in curl seems superfluous anyway, just disable it.

The other alternative is to go back to autotools for libssh2. I don't know if that's a long-term solution, but it seems possible for now.