[PR PATCH] libasr: remove, discontinued upstream and unused

[PR PATCH] libasr: remove, discontinued upstream and unused

[omar-polo]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

There is a new pull request by omar-polo against master on the void-packages repository

https://github.com/omar-polo/void-packages remove-libasr
https://github.com/void-linux/void-packages/pull/44487

libasr: remove, discontinued upstream and unused
First time I'm proposing to drop a package, hope the PR is fine.

libasr was imported (I guess) for OpenSMTPD, but it hasn't been updated in a long time and the OpenSMTPD package doesn't use it anymore either.  There are several well-known issues that were fixed upstream and not backported, so I think it should be removed.  The upstream repository for libasr-portable will be archived soon too.

Nowadays (and for a while already) libasr was only maintained as part of the OpenSMTPD repository.

A patch file from https://github.com/void-linux/void-packages/pull/44487.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove-libasr-44487.patch --]
[-- Type: text/x-diff, Size: 1678 bytes --]

From 28922220bd62598f8160c79d373f2621db4ecb62 Mon Sep 17 00:00:00 2001
From: Omar Polo <op@omarpolo.com>
Date: Sat, 17 Jun 2023 12:01:00 +0200
Subject: [PATCH] libasr: remove, discontinued upstream and unused

---
 srcpkgs/libasr-devel    |  1 -
 srcpkgs/libasr/template | 34 ----------------------------------
 2 files changed, 35 deletions(-)
 delete mode 120000 srcpkgs/libasr-devel
 delete mode 100644 srcpkgs/libasr/template

diff --git a/srcpkgs/libasr-devel b/srcpkgs/libasr-devel
deleted file mode 120000
index 213782918378..000000000000
--- a/srcpkgs/libasr-devel
+++ /dev/null
@@ -1 +0,0 @@
-libasr
\ No newline at end of file
diff --git a/srcpkgs/libasr/template b/srcpkgs/libasr/template
deleted file mode 100644
index fdd5986a740b..000000000000
--- a/srcpkgs/libasr/template
+++ /dev/null
@@ -1,34 +0,0 @@
-# Template file for 'libasr'
-pkgname=libasr
-version=1.0.4
-revision=1
-build_style=gnu-configure
-hostmakedepends="automake libtool"
-short_desc="Simple and portable asynchronous resolver library"
-maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="BSD-2-Clause"
-homepage="https://www.opensmtpd.org/"
-distfiles="https://github.com/OpenSMTPD/${pkgname}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=19fb6bed10d15c9775c8d008cd1130155917ae4e801c729fe85e6d88a545dab4
-
-if [ "$XBPS_TARGET_LIBC" != "musl" ]; then
-	CFLAGS="-DHAVE_RES_RANDOMID"
-fi
-
-pre_configure() {
-	./bootstrap
-}
-
-post_install() {
-	vlicense LICENCE
-}
-
-libasr-devel_package() {
-	short_desc+=" - development files"
-	depends="${sourcepkg}>=${version}_${revision}"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/lib/*.a
-		vmove usr/lib/*.so
-	}
-}

Re: libasr: remove, discontinued upstream and unused

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44487#issuecomment-1595729663

Comment:
You also need to add `libasr<=1.0.4` and `libasr-devel<=1.0.4` to `removed-packages`. See https://github.com/void-linux/void-packages/blob/master/Manual.md#removing-a-package for details.

Re: libasr: remove, discontinued upstream and unused

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/44487#issuecomment-1595729663

Comment:
You also need to add `libasr<=1.0.4_1` and `libasr-devel<=1.0.4_1` to `removed-packages`. See https://github.com/void-linux/void-packages/blob/master/Manual.md#removing-a-package for details.

Re: [PR PATCH] [Updated] libasr: remove, discontinued upstream and unused

[omar-polo]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

There is an updated pull request by omar-polo against master on the void-packages repository

https://github.com/omar-polo/void-packages remove-libasr
https://github.com/void-linux/void-packages/pull/44487

libasr: remove, discontinued upstream and unused
First time I'm proposing to drop a package, hope the PR is fine.

libasr was imported (I guess) for OpenSMTPD, but it hasn't been updated in a long time and the OpenSMTPD package doesn't use it anymore either.  There are several well-known issues that were fixed upstream and not backported, so I think it should be removed.  The upstream repository for libasr-portable will be archived soon too.

Nowadays (and for a while already) libasr was only maintained as part of the OpenSMTPD repository.

A patch file from https://github.com/void-linux/void-packages/pull/44487.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove-libasr-44487.patch --]
[-- Type: text/x-diff, Size: 2929 bytes --]

From f394da2b4503a6ec105753d42c3fa29f16c2e8c2 Mon Sep 17 00:00:00 2001
From: Omar Polo <op@omarpolo.com>
Date: Sat, 17 Jun 2023 12:01:00 +0200
Subject: [PATCH] libasr: remove, discontinued upstream and unused

---
 common/shlibs                     |  1 -
 srcpkgs/libasr-devel              |  1 -
 srcpkgs/libasr/template           | 34 -------------------------------
 srcpkgs/removed-packages/template |  4 +++-
 4 files changed, 3 insertions(+), 37 deletions(-)
 delete mode 120000 srcpkgs/libasr-devel
 delete mode 100644 srcpkgs/libasr/template

diff --git a/common/shlibs b/common/shlibs
index 494e99b89550..e19eb850c6f1 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2208,7 +2208,6 @@ libphobos2-ldc-debug-shared.so.101 ldc-runtime-1.31.0_1
 libmarblewidget-qt5.so.28 marble5-17.12.2_1
 libastro.so.2 marble5-17.12.2_1
 libparrot.so.6.9.0 parrot-6.9.0_1
-libasr.so.0 libasr-1.0.0_1
 libssr-glinject.so ssr-0.3.1_1
 libgdict-1.0.so.10 gnome-dictionary-3.18.1_1
 libasignify.so.1 asignify-1.0_1
diff --git a/srcpkgs/libasr-devel b/srcpkgs/libasr-devel
deleted file mode 120000
index 213782918378..000000000000
--- a/srcpkgs/libasr-devel
+++ /dev/null
@@ -1 +0,0 @@
-libasr
\ No newline at end of file
diff --git a/srcpkgs/libasr/template b/srcpkgs/libasr/template
deleted file mode 100644
index fdd5986a740b..000000000000
--- a/srcpkgs/libasr/template
+++ /dev/null
@@ -1,34 +0,0 @@
-# Template file for 'libasr'
-pkgname=libasr
-version=1.0.4
-revision=1
-build_style=gnu-configure
-hostmakedepends="automake libtool"
-short_desc="Simple and portable asynchronous resolver library"
-maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="BSD-2-Clause"
-homepage="https://www.opensmtpd.org/"
-distfiles="https://github.com/OpenSMTPD/${pkgname}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=19fb6bed10d15c9775c8d008cd1130155917ae4e801c729fe85e6d88a545dab4
-
-if [ "$XBPS_TARGET_LIBC" != "musl" ]; then
-	CFLAGS="-DHAVE_RES_RANDOMID"
-fi
-
-pre_configure() {
-	./bootstrap
-}
-
-post_install() {
-	vlicense LICENCE
-}
-
-libasr-devel_package() {
-	short_desc+=" - development files"
-	depends="${sourcepkg}>=${version}_${revision}"
-	pkg_install() {
-		vmove usr/include
-		vmove usr/lib/*.a
-		vmove usr/lib/*.so
-	}
-}
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 2e2535fa1cc3..9348b700cf2a 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -1,6 +1,6 @@
 # Template file for 'removed-packages'
 pkgname=removed-packages
-version=0.1.20230516
+version=0.1.20230617
 revision=1
 build_style=meta
 short_desc="Uninstalls packages removed from repository"
@@ -273,6 +273,8 @@ replaces="
  libantimicrox-devel<=3.1.3_1
  libantimicrox<=3.1.3_1
  libapp<=20140527_2
+ libasr<=1.0.4_1
+ libasr-devel<=1.0.4_1
  libbitcoin-blockchain-devel<=3.6.0_10
  libbitcoin-blockchain<=3.6.0_10
  libbitcoin-client-devel<=3.6.0_10

Re: libasr: remove, discontinued upstream and unused

[omar-polo]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by omar-polo on void-packages repository

https://github.com/void-linux/void-packages/pull/44487#issuecomment-1595741316

Comment:
@mhmdanas thanks, fixed (i forgot to commit the change to shlibs too btw >.<)

Re: [PR PATCH] [Closed]: libasr: remove, discontinued upstream and unused

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

There's a closed pull request on the void-packages repository

libasr: remove, discontinued upstream and unused
https://github.com/void-linux/void-packages/pull/44487

Description:
First time I'm proposing to drop a package, hope the PR is fine.

libasr was imported (I guess) for OpenSMTPD, but it hasn't been updated in a long time and the OpenSMTPD package doesn't use it anymore either.  There are several well-known issues that were fixed upstream and not backported, so I think it should be removed.  The upstream repository for libasr-portable will be archived soon too.

Nowadays (and for a while already) libasr was only maintained as part of the OpenSMTPD repository.