[PR PATCH] gnome-shell: add gnome-menus dependency

[PR PATCH] gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gmenu
https://github.com/void-linux/void-packages/pull/44548

gnome-shell: add gnome-menus dependency
This fixes translations for the default folders i.e. X-GNOME-Utilities.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44548.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmenu-44548.patch --]
[-- Type: text/x-diff, Size: 1217 bytes --]

From 58ed60143b30667b550946df62393897b3a19d79 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:16:31 -0700
Subject: [PATCH] gnome-shell: add gnome-menus dependency

This fixes translations for the default folders i.e. X-GNOME-Utilities.
---
 srcpkgs/gnome-shell/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-shell/template b/srcpkgs/gnome-shell/template
index 3fc7eb89d17d..fd36ed793e15 100644
--- a/srcpkgs/gnome-shell/template
+++ b/srcpkgs/gnome-shell/template
@@ -12,8 +12,8 @@ makedepends="gnome-control-center-devel at-spi2-atk-devel
  polkit-devel startup-notification-devel ibus-devel gnome-desktop-devel
  NetworkManager-devel pulseaudio-devel gtk4-devel gnome-autoar-devel gjs-devel
  gnome-bluetooth-devel pipewire-devel gstreamer1-devel gcr4-devel"
-depends="elogind gnome-control-center gsettings-desktop-schemas upower
- gstreamer1-pipewire gst-plugins-good1"
+depends="elogind gnome-control-center gsettings-desktop-schemas gnome-menus
+ upower gstreamer1-pipewire gst-plugins-good1"
 checkdepends="xvfb-run mesa-dri $depends"
 short_desc="GNOME core user interface"
 maintainer="Michal Vasilek <michal@vasilek.cz>"

Re: [PR PATCH] [Updated] gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gmenu
https://github.com/void-linux/void-packages/pull/44548

gnome-shell: add gnome-menus dependency
This fixes translations for the default folders i.e. X-GNOME-Utilities.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44548.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmenu-44548.patch --]
[-- Type: text/x-diff, Size: 2186 bytes --]

From 58ed60143b30667b550946df62393897b3a19d79 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:16:31 -0700
Subject: [PATCH 1/2] gnome-shell: add gnome-menus dependency

This fixes translations for the default folders i.e. X-GNOME-Utilities.
---
 srcpkgs/gnome-shell/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gnome-shell/template b/srcpkgs/gnome-shell/template
index 3fc7eb89d17d..fd36ed793e15 100644
--- a/srcpkgs/gnome-shell/template
+++ b/srcpkgs/gnome-shell/template
@@ -12,8 +12,8 @@ makedepends="gnome-control-center-devel at-spi2-atk-devel
  polkit-devel startup-notification-devel ibus-devel gnome-desktop-devel
  NetworkManager-devel pulseaudio-devel gtk4-devel gnome-autoar-devel gjs-devel
  gnome-bluetooth-devel pipewire-devel gstreamer1-devel gcr4-devel"
-depends="elogind gnome-control-center gsettings-desktop-schemas upower
- gstreamer1-pipewire gst-plugins-good1"
+depends="elogind gnome-control-center gsettings-desktop-schemas gnome-menus
+ upower gstreamer1-pipewire gst-plugins-good1"
 checkdepends="xvfb-run mesa-dri $depends"
 short_desc="GNOME core user interface"
 maintainer="Michal Vasilek <michal@vasilek.cz>"

From 2482cd639470f3a915969230e663e218966db1d5 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:23:39 -0700
Subject: [PATCH 2/2] gnome-menus: remove unneeded intltool dependency

https://gitlab.gnome.org/GNOME/gnome-menus/-/commit/b3f51d8577cf7ed00f5a53569b4f022b9ff30fda
---
 srcpkgs/gnome-menus/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gnome-menus/template b/srcpkgs/gnome-menus/template
index e787fb8de6bc..f2e65f8fa580 100644
--- a/srcpkgs/gnome-menus/template
+++ b/srcpkgs/gnome-menus/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-configure
 build_helper="gir"
 configure_args="--disable-static"
-hostmakedepends="pkg-config intltool $(vopt_if gir gobject-introspection)"
+hostmakedepends="pkg-config gettext-devel $(vopt_if gir gobject-introspection)"
 makedepends="libglib-devel"
 short_desc="GNOME menu specifications"
 maintainer="Enno Boland <gottox@voidlinux.org>"

Re: [PR PATCH] [Updated] gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gmenu
https://github.com/void-linux/void-packages/pull/44548

gnome-shell: add gnome-menus dependency
This fixes translations for the default folders i.e. X-GNOME-Utilities.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44548.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmenu-44548.patch --]
[-- Type: text/x-diff, Size: 2383 bytes --]

From a9e8614bedafe5a2c2bfa75e9249d70ccde4d551 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:16:31 -0700
Subject: [PATCH 1/2] gnome-shell: add gnome-menus dependency

This fixes translations for the default folders i.e. X-GNOME-Utilities.
---
 srcpkgs/gnome-shell/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gnome-shell/template b/srcpkgs/gnome-shell/template
index 3fc7eb89d17d..0ea458bb66dd 100644
--- a/srcpkgs/gnome-shell/template
+++ b/srcpkgs/gnome-shell/template
@@ -1,7 +1,7 @@
 # Template file for 'gnome-shell'
 pkgname=gnome-shell
 version=44.2
-revision=1
+revision=2
 build_style=meson
 build_helper=gir
 configure_args="-Dsystemd=false -Dtests=false"
@@ -12,8 +12,8 @@ makedepends="gnome-control-center-devel at-spi2-atk-devel
  polkit-devel startup-notification-devel ibus-devel gnome-desktop-devel
  NetworkManager-devel pulseaudio-devel gtk4-devel gnome-autoar-devel gjs-devel
  gnome-bluetooth-devel pipewire-devel gstreamer1-devel gcr4-devel"
-depends="elogind gnome-control-center gsettings-desktop-schemas upower
- gstreamer1-pipewire gst-plugins-good1"
+depends="elogind gnome-control-center gsettings-desktop-schemas gnome-menus
+ upower gstreamer1-pipewire gst-plugins-good1"
 checkdepends="xvfb-run mesa-dri $depends"
 short_desc="GNOME core user interface"
 maintainer="Michal Vasilek <michal@vasilek.cz>"

From f7f6e8981b2c7249319e2846e7b1ea1913d37060 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:23:39 -0700
Subject: [PATCH 2/2] gnome-menus: remove unneeded intltool dependency

https://gitlab.gnome.org/GNOME/gnome-menus/-/commit/b3f51d8577cf7ed00f5a53569b4f022b9ff30fda
---
 srcpkgs/gnome-menus/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gnome-menus/template b/srcpkgs/gnome-menus/template
index e787fb8de6bc..f2e65f8fa580 100644
--- a/srcpkgs/gnome-menus/template
+++ b/srcpkgs/gnome-menus/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-configure
 build_helper="gir"
 configure_args="--disable-static"
-hostmakedepends="pkg-config intltool $(vopt_if gir gobject-introspection)"
+hostmakedepends="pkg-config gettext-devel $(vopt_if gir gobject-introspection)"
 makedepends="libglib-devel"
 short_desc="GNOME menu specifications"
 maintainer="Enno Boland <gottox@voidlinux.org>"

Re: [PR PATCH] [Updated] gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages gmenu
https://github.com/void-linux/void-packages/pull/44548

gnome-shell: add gnome-menus dependency
This fixes translations for the default folders i.e. X-GNOME-Utilities.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44548.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gmenu-44548.patch --]
[-- Type: text/x-diff, Size: 2381 bytes --]

From a9e8614bedafe5a2c2bfa75e9249d70ccde4d551 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:16:31 -0700
Subject: [PATCH 1/2] gnome-shell: add gnome-menus dependency

This fixes translations for the default folders i.e. X-GNOME-Utilities.
---
 srcpkgs/gnome-shell/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gnome-shell/template b/srcpkgs/gnome-shell/template
index 3fc7eb89d17d..0ea458bb66dd 100644
--- a/srcpkgs/gnome-shell/template
+++ b/srcpkgs/gnome-shell/template
@@ -1,7 +1,7 @@
 # Template file for 'gnome-shell'
 pkgname=gnome-shell
 version=44.2
-revision=1
+revision=2
 build_style=meson
 build_helper=gir
 configure_args="-Dsystemd=false -Dtests=false"
@@ -12,8 +12,8 @@ makedepends="gnome-control-center-devel at-spi2-atk-devel
  polkit-devel startup-notification-devel ibus-devel gnome-desktop-devel
  NetworkManager-devel pulseaudio-devel gtk4-devel gnome-autoar-devel gjs-devel
  gnome-bluetooth-devel pipewire-devel gstreamer1-devel gcr4-devel"
-depends="elogind gnome-control-center gsettings-desktop-schemas upower
- gstreamer1-pipewire gst-plugins-good1"
+depends="elogind gnome-control-center gsettings-desktop-schemas gnome-menus
+ upower gstreamer1-pipewire gst-plugins-good1"
 checkdepends="xvfb-run mesa-dri $depends"
 short_desc="GNOME core user interface"
 maintainer="Michal Vasilek <michal@vasilek.cz>"

From 757b1e0eaebf5501efb4af525b991030711f599f Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Tue, 20 Jun 2023 18:23:39 -0700
Subject: [PATCH 2/2] gnome-menus: remove unused intltool dependency

https://gitlab.gnome.org/GNOME/gnome-menus/-/commit/b3f51d8577cf7ed00f5a53569b4f022b9ff30fda
---
 srcpkgs/gnome-menus/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gnome-menus/template b/srcpkgs/gnome-menus/template
index e787fb8de6bc..f2e65f8fa580 100644
--- a/srcpkgs/gnome-menus/template
+++ b/srcpkgs/gnome-menus/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-configure
 build_helper="gir"
 configure_args="--disable-static"
-hostmakedepends="pkg-config intltool $(vopt_if gir gobject-introspection)"
+hostmakedepends="pkg-config gettext-devel $(vopt_if gir gobject-introspection)"
 makedepends="libglib-devel"
 short_desc="GNOME menu specifications"
 maintainer="Enno Boland <gottox@voidlinux.org>"

Re: gnome-shell: add gnome-menus dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1608931015

Comment:
should gnome-menus be revbumped?

Re: gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609066468

Comment:
No, gettext is a build time dependency.

Re: gnome-shell: add gnome-menus dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609067709

Comment:
right, does it change the resultant package?

Re: gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609066468

Comment:
No, gettext is a build time dependency which was previous getting pulled in through intltool.
I removed intltool from the hostmakedeps because it is unmaintained (and isn't needed by gnome-menus).

Re: gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609069412

Comment:
No.

Re: gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609069412

Comment:
No, intltool isn't used.

Re: gnome-shell: add gnome-menus dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609071259

Comment:
oh, i see the edit

Re: gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609069412

Comment:
No, intltool isn't used even if it is avaliable.

Re: gnome-shell: add gnome-menus dependency

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/44548#issuecomment-1609069412

Comment:
No, intltool isn't used even if it is available.

Re: [PR PATCH] [Merged]: gnome-shell: add gnome-menus dependency

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

There's a merged pull request on the void-packages repository

gnome-shell: add gnome-menus dependency
https://github.com/void-linux/void-packages/pull/44548

Description:
This fixes translations for the default folders i.e. X-GNOME-Utilities.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->