Github messages for voidlinux
 help / color / mirror / Atom feed
From: yoshiyoshyosh <yoshiyoshyosh@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] ferium: fix base build, include GUI build option.
Date: Sat, 24 Jun 2023 21:35:58 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44616@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

There is a new pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages ferium
https://github.com/void-linux/void-packages/pull/44616

ferium: fix base build, include GUI build option.
#### Testing the changes
- I tested the changes in this PR: **briefly**.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

Apologies for the quick revision, but I only realized after the merge that the package compiles with the GUI `xdg-desktop-portal` integration by default, which results in an inability to change some options through the TUI interface on system without `xdg-desktop-portal`. This commit opts to make the `nogui` option the default and provide a build option for the GUI integration instead.

A patch file from https://github.com/void-linux/void-packages/pull/44616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ferium-44616.patch --]
[-- Type: text/x-diff, Size: 1289 bytes --]

From ec3479f43f42db37d0696bb04ad1e9fa009f2d45 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Sat, 24 Jun 2023 14:12:39 -0500
Subject: [PATCH] ferium: fix base build, include GUI build option.

---
 srcpkgs/ferium/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ferium/template b/srcpkgs/ferium/template
index 859e790f75d1..de04a7717bb8 100644
--- a/srcpkgs/ferium/template
+++ b/srcpkgs/ferium/template
@@ -1,9 +1,11 @@
 # Template file for 'ferium'
 pkgname=ferium
 version=4.4.0
-revision=1
+revision=2
 build_style=cargo
 build_helper=qemu
+configure_args="--no-default-features $(vopt_if gui --features=gui)"
+depends="$(vopt_if gui xdg-desktop-portal)"
 short_desc="CLI program for managing Minecraft mods and modpacks"
 maintainer="yosh <yosh-git@riseup.net>"
 license="MPL-2.0"
@@ -12,6 +14,9 @@ changelog="https://raw.githubusercontent.com/gorilla-devs/ferium/main/CHANGELOG.
 distfiles="https://github.com/gorilla-devs/ferium/archive/refs/tags/v${version}.tar.gz"
 checksum=a19b5ea7b12123ef68b2caf96a1c58025aa30d7e14e8c0dbfef44ffc01938045
 
+build_options="gui"
+desc_option_gui="Use GUI file picker via xdg-desktop-portal"
+
 post_install() {
 	local ferium="${DESTDIR}/usr/bin/ferium"
 	for shell in bash fish zsh; do

             reply	other threads:[~2023-06-24 19:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 19:35 yoshiyoshyosh [this message]
2023-06-24 19:47 ` yoshiyoshyosh
2023-06-24 19:51 ` yoshiyoshyosh
2023-06-24 20:18 ` yoshiyoshyosh
2023-06-24 20:19 ` yoshiyoshyosh
2023-08-07  7:14 ` [PR PATCH] [Updated] " yoshiyoshyosh
2023-08-07  7:17 ` ferium: update to 4.4.1 yoshiyoshyosh
2023-08-07  7:17 ` yoshiyoshyosh
2023-08-07  7:24 ` yoshiyoshyosh
2023-08-07  7:25 ` yoshiyoshyosh
2023-10-23 20:52 ` yoshiyoshyosh
2024-01-06 18:09 ` [PR PATCH] [Updated] " yoshiyoshyosh
2024-01-06 18:19 ` [PR PATCH] [Merged]: ferium: don't use portal-based gui classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44616@inbox.vuxu.org \
    --to=yoshiyoshyosh@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).