[PR PATCH] ferium: fix base build, include GUI build option.

[PR PATCH] ferium: fix base build, include GUI build option.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

There is a new pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages ferium
https://github.com/void-linux/void-packages/pull/44616

ferium: fix base build, include GUI build option.
#### Testing the changes
- I tested the changes in this PR: **briefly**.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

Apologies for the quick revision, but I only realized after the merge that the package compiles with the GUI `xdg-desktop-portal` integration by default, which results in an inability to change some options through the TUI interface on system without `xdg-desktop-portal`. This commit opts to make the `nogui` option the default and provide a build option for the GUI integration instead.

A patch file from https://github.com/void-linux/void-packages/pull/44616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ferium-44616.patch --]
[-- Type: text/x-diff, Size: 1289 bytes --]

From ec3479f43f42db37d0696bb04ad1e9fa009f2d45 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Sat, 24 Jun 2023 14:12:39 -0500
Subject: [PATCH] ferium: fix base build, include GUI build option.

---
 srcpkgs/ferium/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ferium/template b/srcpkgs/ferium/template
index 859e790f75d1..de04a7717bb8 100644
--- a/srcpkgs/ferium/template
+++ b/srcpkgs/ferium/template
@@ -1,9 +1,11 @@
 # Template file for 'ferium'
 pkgname=ferium
 version=4.4.0
-revision=1
+revision=2
 build_style=cargo
 build_helper=qemu
+configure_args="--no-default-features $(vopt_if gui --features=gui)"
+depends="$(vopt_if gui xdg-desktop-portal)"
 short_desc="CLI program for managing Minecraft mods and modpacks"
 maintainer="yosh <yosh-git@riseup.net>"
 license="MPL-2.0"
@@ -12,6 +14,9 @@ changelog="https://raw.githubusercontent.com/gorilla-devs/ferium/main/CHANGELOG.
 distfiles="https://github.com/gorilla-devs/ferium/archive/refs/tags/v${version}.tar.gz"
 checksum=a19b5ea7b12123ef68b2caf96a1c58025aa30d7e14e8c0dbfef44ffc01938045
 
+build_options="gui"
+desc_option_gui="Use GUI file picker via xdg-desktop-portal"
+
 post_install() {
 	local ferium="${DESTDIR}/usr/bin/ferium"
 	for shell in bash fish zsh; do

Re: ferium: fix base build, include GUI build option.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1605703684

Comment:
The action failures are seemingly from being forbidden/unable to access the CurseForge API for adding mods. This is known about and a problem with CurseForge itself, not the ferium build.

Re: ferium: fix base build, include GUI build option.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1605703684

Comment:
The action failures are seemingly from the tests being forbidden/unable to access the CurseForge API for adding mods. This is known about and a problem with CurseForge itself, not the ferium build.

Re: ferium: fix base build, include GUI build option.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1605703684

Comment:
The action failures are seemingly from the tests being forbidden/unable to access the CurseForge API for adding mods. [This is known about and will be fixed in a later update](https://github.com/gorilla-devs/ferium/discussions/337#discussioncomment-6111930).

Re: ferium: fix base build, include GUI build option.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1605703684

Comment:
The action failures are seemingly from the tests being forbidden/unable to access the CurseForge API for adding mods. [This is known about and will be fixed in a later update, and there is a current workaround in the software itself](https://github.com/gorilla-devs/ferium/discussions/337#discussioncomment-6111930).

Re: [PR PATCH] [Updated] ferium: fix base build, include GUI build option.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

There is an updated pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages ferium
https://github.com/void-linux/void-packages/pull/44616

ferium: fix base build, include GUI build option.
#### Testing the changes
- I tested the changes in this PR: **briefly**.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

Apologies for the quick revision, but I only realized after the merge that the package compiles with the GUI `xdg-desktop-portal` integration by default, which results in an inability to change some options through the TUI interface on systems without `xdg-desktop-portal`. This commit opts to make the `nogui` option the default and provide a build option for the GUI integration instead.

A patch file from https://github.com/void-linux/void-packages/pull/44616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ferium-44616.patch --]
[-- Type: text/x-diff, Size: 1351 bytes --]

From 5f0d07be325054a5996dbc1dc125f30a865a0967 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Sat, 24 Jun 2023 14:12:39 -0500
Subject: [PATCH] ferium: update to 4.4.1

---
 srcpkgs/ferium/template | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ferium/template b/srcpkgs/ferium/template
index 859e790f75d13..6d718821fbf6b 100644
--- a/srcpkgs/ferium/template
+++ b/srcpkgs/ferium/template
@@ -1,16 +1,21 @@
 # Template file for 'ferium'
 pkgname=ferium
-version=4.4.0
+version=4.4.1
 revision=1
 build_style=cargo
 build_helper=qemu
+configure_args="--no-default-features $(vopt_if gui --features=gui)"
+depends="$(vopt_if gui xdg-desktop-portal)"
 short_desc="CLI program for managing Minecraft mods and modpacks"
 maintainer="yosh <yosh-git@riseup.net>"
 license="MPL-2.0"
 homepage="https://github.com/gorilla-devs/ferium"
 changelog="https://raw.githubusercontent.com/gorilla-devs/ferium/main/CHANGELOG.md"
 distfiles="https://github.com/gorilla-devs/ferium/archive/refs/tags/v${version}.tar.gz"
-checksum=a19b5ea7b12123ef68b2caf96a1c58025aa30d7e14e8c0dbfef44ffc01938045
+checksum=ccab09df5cd0c3db890b7099705696cd8770dcf936182dcd266ad3da5f5262f9
+
+build_options="gui"
+desc_option_gui="Use GUI file picker via xdg-desktop-portal"
 
 post_install() {
 	local ferium="${DESTDIR}/usr/bin/ferium"

Re: ferium: update to 4.4.1

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1667319426

Comment:
checks for modpacks were failing for some reason for me and *only* in xbps-src. `cargo test`ing the builddir ferium myself works perfectly fine, as well as doing all the actions the tests run on the completed package of ferium. binary works perfectly fine otherwise

Re: ferium: update to 4.4.1

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1667319426

Comment:
checks for modpacks were failing for some reason for me and *only* in xbps-src. `cargo test`ing the builddir ferium myself works perfectly fine, as well as doing all the actions the tests run on the completed package of ferium. binary works perfectly fine

Re: ferium: update to 4.4.1

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1667319426

Comment:
~~checks for modpacks were failing for some reason for me and *only* in xbps-src. `cargo test`ing the builddir ferium myself works perfectly fine, as well as doing all the actions the tests run on the completed package of ferium. binary works perfectly fine~~
Looks to have been a network issue on my part--perhaps cf/md wasn't liking my network. whatever.

Re: ferium: update to 4.4.1

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1667319426

Comment:
~~checks for modpacks were failing for some reason for me and *only* in xbps-src. `cargo test`ing the builddir ferium myself works perfectly fine, as well as doing all the actions the tests run on the completed package of ferium. binary works perfectly fine~~
Looks to have been a network issue on my part--perhaps cf/md wasn't liking my connection in that specific case. whatever.

Re: ferium: update to 4.4.1

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/44616#issuecomment-1605703684

Comment:
~~The action failures are seemingly from the tests being forbidden/unable to access the CurseForge API for adding mods. [This is known about and will be fixed in a later update, and there is a current workaround in the software itself](https://github.com/gorilla-devs/ferium/discussions/337#discussioncomment-6111930).~~ fixed with 4.4.1

Re: [PR PATCH] [Updated] ferium: update to 4.4.1

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

There is an updated pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages ferium
https://github.com/void-linux/void-packages/pull/44616

ferium: update to 4.4.1
#### Testing the changes
- I tested the changes in this PR: **briefly**.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

Apologies for the quick revision, but I only realized after the merge that the package compiles with the GUI `xdg-desktop-portal` integration by default, which results in an inability to change some options through the TUI interface on systems without `xdg-desktop-portal`. This commit opts to make the `nogui` option the default and provide a build option for the GUI integration instead.

A patch file from https://github.com/void-linux/void-packages/pull/44616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ferium-44616.patch --]
[-- Type: text/x-diff, Size: 743 bytes --]

From 29e8837ad1679487258ddfe47c6851f8cf6233a7 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Sat, 6 Jan 2024 13:01:51 -0500
Subject: [PATCH] ferium: don't use portals

---
 srcpkgs/ferium/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/ferium/template b/srcpkgs/ferium/template
index 6e23f474c1d27..b9eeac95c56c4 100644
--- a/srcpkgs/ferium/template
+++ b/srcpkgs/ferium/template
@@ -1,9 +1,10 @@
 # Template file for 'ferium'
 pkgname=ferium
 version=4.4.1
-revision=1
+revision=2
 build_style=cargo
 build_helper=qemu
+configure_args="--no-default-features"
 short_desc="CLI program for managing Minecraft mods and modpacks"
 maintainer="yosh <yosh-git@riseup.net>"
 license="MPL-2.0"

Re: [PR PATCH] [Merged]: ferium: don't use portal-based gui

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

There's a merged pull request on the void-packages repository

ferium: don't use portal-based gui
https://github.com/void-linux/void-packages/pull/44616

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

Apologies for the quick revision, but I only realized after the merge that the package compiles with the GUI `xdg-desktop-portal` integration by default, which results in an inability to change some options through the TUI interface on systems without `xdg-desktop-portal`. This commit opts to make the `nogui` option the default and provide a build option for the GUI integration instead.