Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] jupyterlab: add missing dependency
@ 2023-07-06  0:07 classabbyamp
  2023-07-06  1:44 ` dkwo
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: classabbyamp @ 2023-07-06  0:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages jupyterlab-tomli
https://github.com/void-linux/void-packages/pull/44872

jupyterlab: add missing dependency
needed for `jupyter labextension` functionality

@dkwo

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/44872.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jupyterlab-tomli-44872.patch --]
[-- Type: text/x-diff, Size: 1012 bytes --]

From cefd3afcb5d8cb9514bd65f467ac13af46163480 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 5 Jul 2023 20:06:44 -0400
Subject: [PATCH] jupyterlab: add missing dependency

needed for `jupyter labextension` functionality
---
 srcpkgs/jupyterlab/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/jupyterlab/template b/srcpkgs/jupyterlab/template
index 65597d3b63d5..d25867cee455 100644
--- a/srcpkgs/jupyterlab/template
+++ b/srcpkgs/jupyterlab/template
@@ -1,12 +1,12 @@
 # Template file for 'jupyterlab'
 pkgname=jupyterlab
 version=3.5.0
-revision=2
+revision=3
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-jupyterlab_server nodejs python3-nbclassic
  python3-requests-unixsocket python3-jupyter_ipywidgets
- python3-notebook_shim"
+ python3-notebook_shim python3-tomli"
 short_desc="JupyterLab computational environment"
 maintainer="dkwo <nicolopiazzalunga@gmail.com>"
 license="custom:jupyterlab"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: jupyterlab: add missing dependency
  2023-07-06  0:07 [PR PATCH] jupyterlab: add missing dependency classabbyamp
@ 2023-07-06  1:44 ` dkwo
  2023-07-06  2:07 ` classabbyamp
  2023-07-06  2:07 ` [PR PATCH] [Closed]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: dkwo @ 2023-07-06  1:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/44872#issuecomment-1622793489

Comment:
looks good, but see also https://github.com/void-linux/void-packages/pull/44160
maybe it can be done there?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: jupyterlab: add missing dependency
  2023-07-06  0:07 [PR PATCH] jupyterlab: add missing dependency classabbyamp
  2023-07-06  1:44 ` dkwo
@ 2023-07-06  2:07 ` classabbyamp
  2023-07-06  2:07 ` [PR PATCH] [Closed]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2023-07-06  2:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44872#issuecomment-1622841930

Comment:
probably yeah


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: jupyterlab: add missing dependency
  2023-07-06  0:07 [PR PATCH] jupyterlab: add missing dependency classabbyamp
  2023-07-06  1:44 ` dkwo
  2023-07-06  2:07 ` classabbyamp
@ 2023-07-06  2:07 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2023-07-06  2:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

There's a closed pull request on the void-packages repository

jupyterlab: add missing dependency
https://github.com/void-linux/void-packages/pull/44872

Description:
needed for `jupyter labextension` functionality

@dkwo

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-06  2:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-06  0:07 [PR PATCH] jupyterlab: add missing dependency classabbyamp
2023-07-06  1:44 ` dkwo
2023-07-06  2:07 ` classabbyamp
2023-07-06  2:07 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).