[PR PATCH] fail2ban: change maintainer

[PR PATCH] fail2ban: change maintainer

[MeganerdNL]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

There is a new pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages fail2ban-upd-maintainer
https://github.com/void-linux/void-packages/pull/44894

fail2ban: change maintainer
I will maintain this package from now on.
@necrophcodr (old maintainer) will comment here to confirm this - as discussed by e-mail.


A patch file from https://github.com/void-linux/void-packages/pull/44894.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fail2ban-upd-maintainer-44894.patch --]
[-- Type: text/x-diff, Size: 850 bytes --]

From 13ed1fd077666a91f5ab983d48411a0909171381 Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Fri, 7 Jul 2023 08:17:46 +0200
Subject: [PATCH] fail2ban: change maintainer

---
 srcpkgs/fail2ban/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/fail2ban/template b/srcpkgs/fail2ban/template
index caaf7fd6b537..ab214ed0f83a 100644
--- a/srcpkgs/fail2ban/template
+++ b/srcpkgs/fail2ban/template
@@ -6,7 +6,7 @@ build_style=python3-module
 hostmakedepends="pkg-config python3"
 depends="python3"
 short_desc="Authentication failure monitor system"
-maintainer="necrophcodr <necrophcodr@necrophcodr.me>"
+maintainer="MeganerdNL <meganerd@meganerd.nl>"
 license="GPL-2.0-only"
 homepage="https://www.fail2ban.org/"
 changelog="https://raw.githubusercontent.com/fail2ban/fail2ban/master/ChangeLog"

Re: fail2ban: change maintainer

[necrophcodr]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by necrophcodr on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1624840680

Comment:
I haven't done the best of jobs maintaining this, so great to see someone else pick it up :+1: 

Re: fail2ban: change maintainer

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1625381890

Comment:
We generally don't want to change maintainer ship for packages to people who are really new, there has a been a history of one-of maintainers adopting packages and then not contributing anymore.

Re: fail2ban: change maintainer

[MeganerdNL]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1625430365

Comment:
> We generally don't want to change maintainer ship for packages to people who are really new, there has a been a history of one-of maintainers adopting packages and then not contributing anymore.

I really do understand that! 
You will have to take my word for it, but that's hard on the internet :).

I have Void installed on several machines now (1 in production but I will add 3 more in the near future). I'm coming from Debian and I recently searched for a rolling release without systemd and with a greater userbase than Artix (which I use for my laptop) and that let me to Void and I'm really enthusiastic about it since. Great documentation too. Fail2ban is a must-have on servers imho, but there was an old version here, so I PR'd for a new one a few days ago (merged)  and that went well and it learned me how the flow is in void-packages as a bonus. 

So a little introduction that can help you decide. I'm also happy to update fail2ban without being the official maintainer for now and than you can decide later. The former maintainer didn't update it in a long time (so he said himself), so that is the alternative. Cheers.

Re: fail2ban: change maintainer

[necrophcodr]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

New comment by necrophcodr on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1625643738

Comment:
> We generally don't want to change maintainer ship for packages to people who are really new, there has a been a history of one-of maintainers adopting packages and then not contributing anymore.

On the other hand, I haven't been maintaining that package. Is it better to keep a maintainer that, for years, hasn't actively contributed?

Re: fail2ban: change maintainer

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1625663426

Comment:
> > We generally don't want to change maintainer ship for packages to people who are really new, there has a been a history of one-of maintainers adopting packages and then not contributing anymore.
> 
> On the other hand, I haven't been maintaining that package. Is it better to keep a maintainer that, for years, hasn't actively contributed?

Of course not, they should've been orphaned a long time ago. 

I've been trying to actively remove outdated maintainers, but you commenting/approving the fail2ban PR that I've merged threw me off and I assumed you are active without checking the history.

Re: fail2ban: change maintainer

[necrophcodr]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

New comment by necrophcodr on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1625985814

Comment:
> > > We generally don't want to change maintainer ship for packages to people who are really new, there has a been a history of one-of maintainers adopting packages and then not contributing anymore.
> > 
> > 
> > On the other hand, I haven't been maintaining that package. Is it better to keep a maintainer that, for years, hasn't actively contributed?
> 
> Of course not, they should've been orphaned a long time ago.
> 
> I've been trying to actively remove outdated maintainers, but you commenting/approving the fail2ban PR that I've merged threw me off and I assumed you are active without checking the history.

The real story is that @MeganerdNL contacted me via the email listed, and asked if it could be updated. I replied back that I haven't been active in this community for a long time (and I haven't), so if they wanted to update it and maybe maintain it too, they would have my approval at least (however little that means). One PR merged later, and here we are.

Re: fail2ban: change maintainer

[necrophcodr]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

New comment by necrophcodr on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1625985814

Comment:
> > > We generally don't want to change maintainer ship for packages to people who are really new, there has a been a history of one-of maintainers adopting packages and then not contributing anymore.
> > 
> > 
> > On the other hand, I haven't been maintaining that package. Is it better to keep a maintainer that, for years, hasn't actively contributed?
> 
> Of course not, they should've been orphaned a long time ago.
> 
> I've been trying to actively remove outdated maintainers, but you commenting/approving the fail2ban PR that I've merged threw me off and I assumed you are active without checking the history.

The real story is that @MeganerdNL contacted me via the email listed, and asked if it could be updated. I replied back that I haven't been active in this community for a long time (and I haven't), so if they wanted to update it and maybe maintain it too, I would encourage them to give it a shot at least (however little that means). One PR merged later, and here we are.

Re: fail2ban: change maintainer

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44894#issuecomment-1627637837

Comment:
please rebase to fix the conflict

Re: [PR PATCH] [Closed]: fail2ban: change maintainer

[MeganerdNL]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

There's a closed pull request on the void-packages repository

fail2ban: change maintainer
https://github.com/void-linux/void-packages/pull/44894

Description:
I will maintain this package from now on.
@necrophcodr (old maintainer) will comment here to confirm this - as discussed by e-mail.

Re: [PR PATCH] [Updated] fail2ban: change maintainer

[MeganerdNL]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is an updated pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages fail2ban-upd-maintainer
https://github.com/void-linux/void-packages/pull/44894

fail2ban: change maintainer
I will maintain this package from now on.
@necrophcodr (old maintainer) will comment here to confirm this - as discussed by e-mail.


A patch file from https://github.com/void-linux/void-packages/pull/44894.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fail2ban-upd-maintainer-44894.patch --]
[-- Type: text/x-diff, Size: 0 bytes --]