* [PR PATCH] variety: depend on qt5-tools for KDE support.
@ 2023-07-13 15:21 TinfoilSubmarine
2023-07-17 3:03 ` sgn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: TinfoilSubmarine @ 2023-07-13 15:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
There is a new pull request by TinfoilSubmarine against master on the void-packages repository
https://github.com/TinfoilSubmarine/void-packages update/variety
https://github.com/void-linux/void-packages/pull/45016
variety: depend on qt5-tools for KDE support.
<!-- Uncomment relevant sections and delete options which are not applicable -->
Not sure if this is the right choice or if we should just put a note in
`INSTALL.msg`. I did a quick look through
`/usr/share/variety/scripts/set_wallpaper` and it seems like most other DEs
include the needed tool for variety to set the wallpaper.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/45016.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update/variety-45016.patch --]
[-- Type: text/x-diff, Size: 1140 bytes --]
From 9b621192ad7d4b43848c70a6adb77026b72305da Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Thu, 13 Jul 2023 11:06:03 -0400
Subject: [PATCH] variety: depend on qt5-tools for KDE support.
---
srcpkgs/variety/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/variety/template b/srcpkgs/variety/template
index 619fd032a40f..4d0cf6996407 100644
--- a/srcpkgs/variety/template
+++ b/srcpkgs/variety/template
@@ -1,13 +1,13 @@
# Template file for 'variety'
pkgname=variety
version=0.8.10
-revision=1
+revision=2
build_style=python3-module
pycompile_dirs="usr/share/variety/plugins"
hostmakedepends="python3-setuptools python3-distutils-extra intltool"
depends="ImageMagick gtk+3 libgexiv2 libnotify python3-BeautifulSoup4
python3-Pillow python3-configobj python3-dbus python3-gobject python3-httplib2
- python3-lxml python3-requests python3-cairo"
+ python3-lxml python3-requests python3-cairo qt5-tools"
checkdepends="python3-pytest pylint $depends"
short_desc="Changes the wallpaper on a regular interval"
maintainer="Ishaan Bhimwal <ishaanbhimwal@protonmail.com>"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: variety: depend on qt5-tools for KDE support.
2023-07-13 15:21 [PR PATCH] variety: depend on qt5-tools for KDE support TinfoilSubmarine
@ 2023-07-17 3:03 ` sgn
2023-07-17 3:03 ` [PR PATCH] [Closed]: " sgn
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2023-07-17 3:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/45016#issuecomment-1637312976
Comment:
Nope.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: variety: depend on qt5-tools for KDE support.
2023-07-13 15:21 [PR PATCH] variety: depend on qt5-tools for KDE support TinfoilSubmarine
2023-07-17 3:03 ` sgn
@ 2023-07-17 3:03 ` sgn
2023-07-17 13:04 ` TinfoilSubmarine
2023-07-27 16:16 ` TinfoilSubmarine
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2023-07-17 3:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
There's a closed pull request on the void-packages repository
variety: depend on qt5-tools for KDE support.
https://github.com/void-linux/void-packages/pull/45016
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
Not sure if this is the right choice or if we should just put a note in
`INSTALL.msg`. I did a quick look through
`/usr/share/variety/scripts/set_wallpaper` and it seems like most other DEs
include the needed tool for variety to set the wallpaper.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: variety: depend on qt5-tools for KDE support.
2023-07-13 15:21 [PR PATCH] variety: depend on qt5-tools for KDE support TinfoilSubmarine
2023-07-17 3:03 ` sgn
2023-07-17 3:03 ` [PR PATCH] [Closed]: " sgn
@ 2023-07-17 13:04 ` TinfoilSubmarine
2023-07-27 16:16 ` TinfoilSubmarine
3 siblings, 0 replies; 5+ messages in thread
From: TinfoilSubmarine @ 2023-07-17 13:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/45016#issuecomment-1638102040
Comment:
> Nope.
Do you have a recommendation of how to better deal with this? This package is broken on KDE with no clear guidance on how to make it work.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: variety: depend on qt5-tools for KDE support.
2023-07-13 15:21 [PR PATCH] variety: depend on qt5-tools for KDE support TinfoilSubmarine
` (2 preceding siblings ...)
2023-07-17 13:04 ` TinfoilSubmarine
@ 2023-07-27 16:16 ` TinfoilSubmarine
3 siblings, 0 replies; 5+ messages in thread
From: TinfoilSubmarine @ 2023-07-27 16:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
New comment by TinfoilSubmarine on void-packages repository
https://github.com/void-linux/void-packages/pull/45016#issuecomment-1653934064
Comment:
Related: https://github.com/varietywalls/variety/pull/633
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-27 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 15:21 [PR PATCH] variety: depend on qt5-tools for KDE support TinfoilSubmarine
2023-07-17 3:03 ` sgn
2023-07-17 3:03 ` [PR PATCH] [Closed]: " sgn
2023-07-17 13:04 ` TinfoilSubmarine
2023-07-27 16:16 ` TinfoilSubmarine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).