[PR PATCH] mcomix: update to 2.2.1.

[PR PATCH] mcomix: update to 2.2.1.

[hazen2215]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

There is a new pull request by hazen2215 against master on the void-packages repository

https://github.com/hazen2215/void-packages mcomix
https://github.com/void-linux/void-packages/pull/45052

mcomix: update to 2.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/45052.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mcomix-45052.patch --]
[-- Type: text/x-diff, Size: 1107 bytes --]

From a1c00c2cb4623e0561f410ccd2426ca7326e442c Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Sat, 15 Jul 2023 22:39:28 +0900
Subject: [PATCH] mcomix: update to 2.2.1.

---
 srcpkgs/mcomix/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mcomix/template b/srcpkgs/mcomix/template
index 9e84decf7405..d599591846e5 100644
--- a/srcpkgs/mcomix/template
+++ b/srcpkgs/mcomix/template
@@ -1,6 +1,6 @@
 # Template file for 'mcomix'
 pkgname=mcomix
-version=2.1.0
+version=2.2.1
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -9,5 +9,5 @@ short_desc="GTK+ comic book viewer"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="GPL-2.0-only"
 homepage="http://sourceforge.net/projects/mcomix/"
-distfiles="${SOURCEFORGE_SITE}/${pkgname}/MComix-${version}/${pkgname}-${version}.tar.gz"
-checksum=368938a2a4deccef38abd20366f822df765e29f44bfada60ed01039a9d996695
+distfiles="${SOURCEFORGE_SITE}/mcomix/MComix-${version}/mcomix-${version}.tar.gz"
+checksum=7e69e53e134237a611de55b660230401b1225958a071f143ab5b434357933640

Re: [PR PATCH] [Updated] mcomix: update to 2.2.1.

[hazen2215]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by hazen2215 against master on the void-packages repository

https://github.com/hazen2215/void-packages mcomix
https://github.com/void-linux/void-packages/pull/45052

mcomix: update to 2.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/45052.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mcomix-45052.patch --]
[-- Type: text/x-diff, Size: 1138 bytes --]

From 3c06bae3363191309e2f6fdb6dea8575fb1a4b14 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Sat, 15 Jul 2023 22:39:28 +0900
Subject: [PATCH] mcomix: update to 2.2.1.

---
 srcpkgs/mcomix/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mcomix/template b/srcpkgs/mcomix/template
index 9e84decf7405..0e1b504920c8 100644
--- a/srcpkgs/mcomix/template
+++ b/srcpkgs/mcomix/template
@@ -1,6 +1,6 @@
 # Template file for 'mcomix'
 pkgname=mcomix
-version=2.1.0
+version=2.2.1
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -9,5 +9,6 @@ short_desc="GTK+ comic book viewer"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="GPL-2.0-only"
 homepage="http://sourceforge.net/projects/mcomix/"
-distfiles="${SOURCEFORGE_SITE}/${pkgname}/MComix-${version}/${pkgname}-${version}.tar.gz"
-checksum=368938a2a4deccef38abd20366f822df765e29f44bfada60ed01039a9d996695
+distfiles="${SOURCEFORGE_SITE}/mcomix/MComix-${version}/mcomix-${version}.tar.gz"
+checksum=7e69e53e134237a611de55b660230401b1225958a071f143ab5b434357933640
+make_check=no # broken tests

Re: [PR REVIEW] mcomix: update to 2.2.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45052#discussion_r1267533060

Comment:
https

Re: [PR REVIEW] mcomix: update to 2.2.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45052#discussion_r1267533283

Comment:
also add changelog: https://sourceforge.net/p/mcomix/news/

Re: [PR PATCH] [Updated] mcomix: update to 2.2.1.

[hazen2215]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by hazen2215 against master on the void-packages repository

https://github.com/hazen2215/void-packages mcomix
https://github.com/void-linux/void-packages/pull/45052

mcomix: update to 2.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/45052.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mcomix-45052.patch --]
[-- Type: text/x-diff, Size: 1315 bytes --]

From faa76e58552768f85bd18cc31a3fbeaebc57093d Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Sat, 15 Jul 2023 22:39:28 +0900
Subject: [PATCH] mcomix: update to 2.2.1.

---
 srcpkgs/mcomix/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/mcomix/template b/srcpkgs/mcomix/template
index 9e84decf74058..522c82038e0d3 100644
--- a/srcpkgs/mcomix/template
+++ b/srcpkgs/mcomix/template
@@ -1,6 +1,6 @@
 # Template file for 'mcomix'
 pkgname=mcomix
-version=2.1.0
+version=2.2.1
 revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -8,6 +8,8 @@ depends="python3-gobject python3-cairo python3-Pillow xdg-utils"
 short_desc="GTK+ comic book viewer"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="GPL-2.0-only"
-homepage="http://sourceforge.net/projects/mcomix/"
-distfiles="${SOURCEFORGE_SITE}/${pkgname}/MComix-${version}/${pkgname}-${version}.tar.gz"
-checksum=368938a2a4deccef38abd20366f822df765e29f44bfada60ed01039a9d996695
+homepage="https://sourceforge.net/projects/mcomix/"
+changelog="https://sourceforge.net/p/mcomix/news/"
+distfiles="${SOURCEFORGE_SITE}/mcomix/MComix-${version}/mcomix-${version}.tar.gz"
+checksum=7e69e53e134237a611de55b660230401b1225958a071f143ab5b434357933640
+make_check=no # broken tests

Re: mcomix: update to 2.2.1.

[hazen2215]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by hazen2215 on void-packages repository

https://github.com/void-linux/void-packages/pull/45052#issuecomment-1641842412

Comment:
Applied suggestion.

Re: [PR PATCH] [Merged]: mcomix: update to 2.2.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

There's a merged pull request on the void-packages repository

mcomix: update to 2.2.1.
https://github.com/void-linux/void-packages/pull/45052

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

Re: mcomix: update to 2.2.1.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45052#issuecomment-1644434136

Comment:
"broken tests" doesn't explain anything. Template lacks `checkdepends="python3-pytest ${depends}"` and tarball lacks some files present in source control, primarily `test/__init__.py`, what could be reported and resolved upstream.