Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] neochat: add missing kitemmodels runtime dep.
@ 2023-07-22 16:54 mhmdanas
  2023-07-23 13:59 ` [PR PATCH] [Merged]: " Johnnynator
  0 siblings, 1 reply; 2+ messages in thread
From: mhmdanas @ 2023-07-22 16:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages neochat-add-missing-kitemmodels-dep
https://github.com/void-linux/void-packages/pull/45196

neochat: add missing kitemmodels runtime dep.
Otherwise it exits with this error:
```
qrc:/RoomListPage.qml:11:1: module "org.kde.kitemmodels" is not installed
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (didn't build the package locally, just tested that it works correctly with kitemmodels)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/45196.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-neochat-add-missing-kitemmodels-dep-45196.patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From ec4474235895c5a9b4cbe885d1eb9147e4454f1e Mon Sep 17 00:00:00 2001
From: triallax <triallax@tutanota.com>
Date: Sat, 22 Jul 2023 17:53:26 +0100
Subject: [PATCH] neochat: add missing kitemmodels runtime dep.

Otherwise it exits with this error:
```
qrc:/RoomListPage.qml:11:1: module "org.kde.kitemmodels" is not installed
```
---
 srcpkgs/neochat/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/neochat/template b/srcpkgs/neochat/template
index c7d825a08c3c7..c6c4e699eca58 100644
--- a/srcpkgs/neochat/template
+++ b/srcpkgs/neochat/template
@@ -1,7 +1,7 @@
 # Template file for 'neochat'
 pkgname=neochat
 version=23.04.3
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="extra-cmake-modules gettext pkg-config qt5-qmake
  qt5-host-tools kcoreaddons kconfig AppStream"
@@ -10,7 +10,7 @@ makedepends="kquickimageeditor-devel libQuotient-devel qtkeychain-qt5-devel
  knotifications-devel kconfig-devel kcoreaddons-devel qqc2-desktop-style-devel
  sonnet-devel kitemmodels-devel kirigami-addons kconfigwidgets-devel kio-devel
  qcoro-qt5-devel"
-depends="kquickimageeditor"
+depends="kquickimageeditor kitemmodels"
 short_desc="Client for matrix from KDE"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-only, GPL-3.0-or-later, GPL-2.0-or-later, BSD-2-Clause"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: neochat: add missing kitemmodels runtime dep.
  2023-07-22 16:54 [PR PATCH] neochat: add missing kitemmodels runtime dep mhmdanas
@ 2023-07-23 13:59 ` Johnnynator
  0 siblings, 0 replies; 2+ messages in thread
From: Johnnynator @ 2023-07-23 13:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

There's a merged pull request on the void-packages repository

neochat: add missing kitemmodels runtime dep.
https://github.com/void-linux/void-packages/pull/45196

Description:
Otherwise it exits with this error:
```
qrc:/RoomListPage.qml:11:1: module "org.kde.kitemmodels" is not installed
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (didn't build the package locally, just tested that it works correctly with kitemmodels)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-23 13:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-22 16:54 [PR PATCH] neochat: add missing kitemmodels runtime dep mhmdanas
2023-07-23 13:59 ` [PR PATCH] [Merged]: " Johnnynator

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).