From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable
Date: Mon, 07 Aug 2023 01:50:45 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45465@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages go-read-a-book
https://github.com/void-linux/void-packages/pull/45465
common/build-style/go: use -x -> -v so go build logs are readable
this is still verbose (prints each module being compiled), but build logs should be more readable (for finding things like errors) now
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/45465.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-read-a-book-45465.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]
From c4612d9f33076ffabb0b88caf32c564dc8fec1b0 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 6 Aug 2023 19:47:48 -0400
Subject: [PATCH] common/build-style/go: use -x -> -v so go build logs are
readable
this is still verbose (prints each module being compiled), but build
logs should be more readable (for finding things like errors) now
---
common/build-style/go.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index f1808b3311a4a..c16baa1238059 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -45,10 +45,10 @@ do_build() {
# default behavior.
go_mod_mode=
fi
- go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
else
# Otherwise, build using GOPATH
- go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go get -p "$XBPS_MAKEJOBS" -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
fi
}
next reply other threads:[~2023-08-06 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 23:50 classabbyamp [this message]
2023-08-07 0:07 ` [PR PATCH] [Updated] " classabbyamp
2023-08-07 0:07 ` classabbyamp
2023-08-08 23:54 ` [RFC] " the-maldridge
2023-08-08 23:59 ` classabbyamp
2023-08-10 2:09 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45465@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).