* [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable
@ 2023-08-06 23:50 classabbyamp
2023-08-07 0:07 ` [PR PATCH] [Updated] " classabbyamp
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: classabbyamp @ 2023-08-06 23:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages go-read-a-book
https://github.com/void-linux/void-packages/pull/45465
common/build-style/go: use -x -> -v so go build logs are readable
this is still verbose (prints each module being compiled), but build logs should be more readable (for finding things like errors) now
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/45465.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-read-a-book-45465.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]
From c4612d9f33076ffabb0b88caf32c564dc8fec1b0 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 6 Aug 2023 19:47:48 -0400
Subject: [PATCH] common/build-style/go: use -x -> -v so go build logs are
readable
this is still verbose (prints each module being compiled), but build
logs should be more readable (for finding things like errors) now
---
common/build-style/go.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index f1808b3311a4a..c16baa1238059 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -45,10 +45,10 @@ do_build() {
# default behavior.
go_mod_mode=
fi
- go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
else
# Otherwise, build using GOPATH
- go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go get -p "$XBPS_MAKEJOBS" -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
fi
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Updated] common/build-style/go: use -x -> -v so go build logs are readable
2023-08-06 23:50 [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable classabbyamp
@ 2023-08-07 0:07 ` classabbyamp
2023-08-07 0:07 ` classabbyamp
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-08-07 0:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
There is an updated pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages go-read-a-book
https://github.com/void-linux/void-packages/pull/45465
common/build-style/go: use -x -> -v so go build logs are readable
this is still verbose (prints each module being compiled), but build logs should be more readable (for finding things like errors) now
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/45465.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-read-a-book-45465.patch --]
[-- Type: text/x-diff, Size: 2239 bytes --]
From c4612d9f33076ffabb0b88caf32c564dc8fec1b0 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 6 Aug 2023 19:47:48 -0400
Subject: [PATCH 1/2] common/build-style/go: use -x -> -v so go build logs are
readable
this is still verbose (prints each module being compiled), but build
logs should be more readable (for finding things like errors) now
---
common/build-style/go.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index f1808b3311a4a..c16baa1238059 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -45,10 +45,10 @@ do_build() {
# default behavior.
go_mod_mode=
fi
- go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -modcacherw -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
else
# Otherwise, build using GOPATH
- go get -p "$XBPS_MAKEJOBS" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+ go get -p "$XBPS_MAKEJOBS" -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
fi
}
From fb22689a2bd8fe0a94ad70bc04d8174f6eda9342 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sun, 6 Aug 2023 20:07:23 -0400
Subject: [PATCH 2/2] chezmoi: update to 2.37.0.
---
srcpkgs/chezmoi/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/chezmoi/template b/srcpkgs/chezmoi/template
index bf1f6ee617a1c..a220dd00c0f86 100644
--- a/srcpkgs/chezmoi/template
+++ b/srcpkgs/chezmoi/template
@@ -1,6 +1,6 @@
# Template file for 'chezmoi'
pkgname=chezmoi
-version=2.36.1
+version=2.37.0
revision=1
build_style=go
go_import_path="github.com/twpayne/chezmoi/v2"
@@ -13,7 +13,7 @@ license="MIT"
homepage="https://chezmoi.io/"
changelog="https://github.com/twpayne/chezmoi/releases"
distfiles="https://github.com/twpayne/chezmoi/archive/v${version}.tar.gz"
-checksum=771e848deed1134a9f8065b5de7ae8a885e51b7dc8dab1db2aa94ec44ab1a247
+checksum=c9c37268e437c28b8da93f48fcfdffc8586136a09f95910a06baa94bc4562667
pre_build() {
local _date
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: common/build-style/go: use -x -> -v so go build logs are readable
2023-08-06 23:50 [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable classabbyamp
2023-08-07 0:07 ` [PR PATCH] [Updated] " classabbyamp
@ 2023-08-07 0:07 ` classabbyamp
2023-08-08 23:54 ` [RFC] " the-maldridge
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-08-07 0:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/45465#issuecomment-1667013359
Comment:
see CI logs for an example
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC] common/build-style/go: use -x -> -v so go build logs are readable
2023-08-06 23:50 [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable classabbyamp
2023-08-07 0:07 ` [PR PATCH] [Updated] " classabbyamp
2023-08-07 0:07 ` classabbyamp
@ 2023-08-08 23:54 ` the-maldridge
2023-08-08 23:59 ` classabbyamp
2023-08-10 2:09 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: the-maldridge @ 2023-08-08 23:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/45465#issuecomment-1670460197
Comment:
Ok for now, but I would like to point out that some of the problems we've encountered in the past (distant past at this point) involved looking at compiler flags.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] common/build-style/go: use -x -> -v so go build logs are readable
2023-08-06 23:50 [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable classabbyamp
` (2 preceding siblings ...)
2023-08-08 23:54 ` [RFC] " the-maldridge
@ 2023-08-08 23:59 ` classabbyamp
2023-08-10 2:09 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-08-08 23:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/45465#issuecomment-1670463229
Comment:
hm, it might be nice to have a general xbps-src functionality to define a debug/higher log level for build processes, e.g. `if [ "$XBPS_VERBOSE" ]; flag=" -x "; fi`
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Merged]: [RFC] common/build-style/go: use -x -> -v so go build logs are readable
2023-08-06 23:50 [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable classabbyamp
` (3 preceding siblings ...)
2023-08-08 23:59 ` classabbyamp
@ 2023-08-10 2:09 ` classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-08-10 2:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
There's a merged pull request on the void-packages repository
[RFC] common/build-style/go: use -x -> -v so go build logs are readable
https://github.com/void-linux/void-packages/pull/45465
Description:
this is still verbose (prints each module being compiled), but build logs should be more readable (for finding things like errors) now
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-10 2:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-06 23:50 [PR PATCH] common/build-style/go: use -x -> -v so go build logs are readable classabbyamp
2023-08-07 0:07 ` [PR PATCH] [Updated] " classabbyamp
2023-08-07 0:07 ` classabbyamp
2023-08-08 23:54 ` [RFC] " the-maldridge
2023-08-08 23:59 ` classabbyamp
2023-08-10 2:09 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).