[PR PATCH] WindowMaker: update 0.96.0

[PR PATCH] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

There is a new pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 1470 bytes --]

From a596417b67359100f88ec944d4eea27eec380dc7 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH] WindowMaker: update 0.96.0

Updated WindowMaker to 0.96.0. It required the distfiles url, version, and revision to be changed.
---
 srcpkgs/WindowMaker/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..9bf0d40db977e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=0
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -20,8 +20,8 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {
 	autoreconf -fi

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675393276

Comment:
I just realized there is WindowMaker-devel package as well that this one looks at as well. Let me look at that and I will add it to the PR if I can manage it. 

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675398761

Comment:
WindowMaker-devel is a subpackage of WindowMaker, so updating the version in the WindowMaker template updates WindowMaker-devel as well, nothing else needs to be changed here.

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675398761

Comment:
WindowMaker-devel is a subpackage of WindowMaker, so updating the version in the WindowMaker template updates WindowMaker-devel as well automatically, nothing else needs to be changed here.

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675398761

Comment:
WindowMaker-devel is a subpackage of WindowMaker, so updating the version in the WindowMaker template updates WindowMaker-devel as well automatically, nothing else needs to be changed here for that.

Re: [PR REVIEW] WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#discussion_r1291771788

Comment:
At Void, the revision starts at 1 and not at zero

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675399992

Comment:
> WindowMaker-devel is a subpackage of WindowMaker, so updating the version in the WindowMaker template updates WindowMaker-devel as well automatically, nothing else needs to be changed here.

Ok great. Thanks. I just saw that yes it is a symlink/subpackage.

Re: [PR REVIEW] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#discussion_r1291772290

Comment:
Ahh ok. I wasn't positive/sure what to make that. I will change it now. Thanks.

Re: [PR PATCH] [Updated] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

There is an updated pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 2257 bytes --]

From a596417b67359100f88ec944d4eea27eec380dc7 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH 1/2] WindowMaker: update 0.96.0

Updated WindowMaker to 0.96.0. It required the distfiles url, version, and revision to be changed.
---
 srcpkgs/WindowMaker/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..9bf0d40db977e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=0
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -20,8 +20,8 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {
 	autoreconf -fi

From 9baca2c118af6ad4b4a881e799f09c963d6f25c9 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 17:05:45 -0400
Subject: [PATCH 2/2] Update template

Change the revision from 0 to 1
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 9bf0d40db977e..89b207e9f9f5a 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
 version=0.96.0
-revision=0
+revision=1
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace

Re: [PR REVIEW] WindowMaker: update 0.96.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#discussion_r1291799791

Comment:
```suggestion
distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
```

Re: [PR PATCH] [Updated] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

There is an updated pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 3360 bytes --]

From a596417b67359100f88ec944d4eea27eec380dc7 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH 1/3] WindowMaker: update 0.96.0

Updated WindowMaker to 0.96.0. It required the distfiles url, version, and revision to be changed.
---
 srcpkgs/WindowMaker/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..9bf0d40db977e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=0
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -20,8 +20,8 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {
 	autoreconf -fi

From 9baca2c118af6ad4b4a881e799f09c963d6f25c9 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 17:05:45 -0400
Subject: [PATCH 2/3] Update template

Change the revision from 0 to 1
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 9bf0d40db977e..89b207e9f9f5a 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
 version=0.96.0
-revision=0
+revision=1
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace

From 44bcbd05086a4fb609b61ee2421cc86d1a5ad857 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 21:55:36 -0400
Subject: [PATCH 3/3] Update srcpkgs/WindowMaker/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 89b207e9f9f5a..e712350191b55 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -20,7 +20,7 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
 checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {

Re: [PR REVIEW] WindowMaker: update 0.96.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#discussion_r1291987680

Comment:
```suggestion
homepage="https://www.windowmaker.org/"
changelog="http://www.windowmaker.org/news/"
```

Re: [PR PATCH] [Updated] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

There is an updated pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 4430 bytes --]

From a596417b67359100f88ec944d4eea27eec380dc7 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH 1/4] WindowMaker: update 0.96.0

Updated WindowMaker to 0.96.0. It required the distfiles url, version, and revision to be changed.
---
 srcpkgs/WindowMaker/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..9bf0d40db977e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=0
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -20,8 +20,8 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {
 	autoreconf -fi

From 9baca2c118af6ad4b4a881e799f09c963d6f25c9 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 17:05:45 -0400
Subject: [PATCH 2/4] Update template

Change the revision from 0 to 1
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 9bf0d40db977e..89b207e9f9f5a 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
 version=0.96.0
-revision=0
+revision=1
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace

From 44bcbd05086a4fb609b61ee2421cc86d1a5ad857 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 21:55:36 -0400
Subject: [PATCH 3/4] Update srcpkgs/WindowMaker/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 89b207e9f9f5a..e712350191b55 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -20,7 +20,7 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
 checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {

From c1146eeb1054d316f9ce33ffec216c0f0edb1d87 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 22:20:09 -0400
Subject: [PATCH 4/4] Update srcpkgs/WindowMaker/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index e712350191b55..60f77b6788f33 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -19,7 +19,8 @@ conf_files="
 short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
-homepage="http://www.windowmaker.org/"
+homepage="https://www.windowmaker.org/"
+changelog="http://www.windowmaker.org/news/"
 distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
 checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675861956

Comment:
Please do only one commit per package, see https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes.
Musl builds seem to fail, you can reproduce that with `./xbps-src pkg WindowMaker -a aarch64-musl`.

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675861956

Comment:
Please do only one commit per package, see https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes.
Musl tests seem to fail, you can reproduce that with `./xbps-src check WindowMaker -a aarch64-musl`.

Re: WindowMaker: update 0.96.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675999787

Comment:
> Musl tests seem to fail, you can reproduce that with ./xbps-src check WindowMaker -a aarch64-musl.

That's not the way to check that, tests don't run on cross and you should be using a musl masterdir:

```sh
./xbps-src -m masterdir-musl binary-bootstrap x86_64-musl
./xbps-src -m masterdir-musl check WindowMaker
```

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676000900

Comment:
oh, my bad

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676101899

Comment:
Ok I will try to test/check/compile like you stated. I was on x86_64 when I initially tested and it worked fine.

Re: WindowMaker: update 0.96.0

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1675861956

Comment:
Please do only one commit per package, see https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes.
Some tests seem to fail, you can reproduce that with `./xbps-src check WindowMaker`.

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676110256

Comment:
So I used the two xbps-src commands you listed to compile for x86_64-musl. It seems to be complaining about an option not being found in the INSTALL-WMAKER documentation. Specifically --with-libtool-sysroot. I am not sure why on github some of the checks fail and others do not (for one arch vs others). It is also weird I was able to compile/install the package on my machine without any issue. I also checked the previous version and it also did not contain that string within that file. I do see before the error that it is set to ignore some options? Does this one need to be added? I am not sure what exactly to do from here. Thanks.

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676111191

Comment:
So when I do the check command it fails with the error I described in my last message (unable to find --with-libtool-sysroot in INSTALL-WMAKER) but if I run the pkg command it packages it without error.

Re: [PR REVIEW] WindowMaker: update 0.96.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#discussion_r1292509031

Comment:
```suggestion
checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
# tests various things against documentation, doesn't make sense to run
make_check=no
```
they're doing weird things like checking if the configure script has different weird arguments, and it's been happening since at least the previous version, so just disable them imo

Re: [PR REVIEW] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#discussion_r1292513706

Comment:
Ok will do. I will make that change and if the checks pass I will try to do a commit with all the changes in a single commit. Thanks!

Re: [PR PATCH] [Updated] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

There is an updated pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 5410 bytes --]

From a596417b67359100f88ec944d4eea27eec380dc7 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH 1/5] WindowMaker: update 0.96.0

Updated WindowMaker to 0.96.0. It required the distfiles url, version, and revision to be changed.
---
 srcpkgs/WindowMaker/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..9bf0d40db977e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=0
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -20,8 +20,8 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {
 	autoreconf -fi

From 9baca2c118af6ad4b4a881e799f09c963d6f25c9 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 17:05:45 -0400
Subject: [PATCH 2/5] Update template

Change the revision from 0 to 1
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 9bf0d40db977e..89b207e9f9f5a 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
 version=0.96.0
-revision=0
+revision=1
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace

From 44bcbd05086a4fb609b61ee2421cc86d1a5ad857 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 21:55:36 -0400
Subject: [PATCH 3/5] Update srcpkgs/WindowMaker/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 89b207e9f9f5a..e712350191b55 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -20,7 +20,7 @@ short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
 homepage="http://www.windowmaker.org/"
-distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/${pkgname}-${version}.tar.gz"
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
 checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 
 pre_configure() {

From c1146eeb1054d316f9ce33ffec216c0f0edb1d87 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 22:20:09 -0400
Subject: [PATCH 4/5] Update srcpkgs/WindowMaker/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index e712350191b55..60f77b6788f33 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -19,7 +19,8 @@ conf_files="
 short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
-homepage="http://www.windowmaker.org/"
+homepage="https://www.windowmaker.org/"
+changelog="http://www.windowmaker.org/news/"
 distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
 checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
 

From 39867c2e79ee77b5d9ee1cb9c16dd67177be40c0 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Sat, 12 Aug 2023 18:02:43 -0400
Subject: [PATCH 5/5] Update srcpkgs/WindowMaker/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 60f77b6788f33..3acc1e3720f7e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -23,6 +23,8 @@ homepage="https://www.windowmaker.org/"
 changelog="http://www.windowmaker.org/news/"
 distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
 checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
+# tests various things against documentation, doesn't make sense to run
+make_check=no
 
 pre_configure() {
 	autoreconf -fi

Re: [PR PATCH] [Updated] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

There is an updated pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 1909 bytes --]

From 8c361f744866cb780d5fa4f194e4a496af01ec00 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH] WindowMaker: update to 0.96.0

Updated WindowMaker to 0.96.0. It required the distfiles url, version, and revision to be changed.

Update srcpkgs/WindowMaker/template

Update srcpkgs/WindowMaker/template

Update srcpkgs/WindowMaker/template

Update template

Change the revision from 0 to 1

Co-Authored-By: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/WindowMaker/template | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..3acc1e3720f7e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=1
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -19,9 +19,12 @@ conf_files="
 short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
-homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+homepage="https://www.windowmaker.org/"
+changelog="http://www.windowmaker.org/news/"
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
+# tests various things against documentation, doesn't make sense to run
+make_check=no
 
 pre_configure() {
 	autoreconf -fi

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676126612

Comment:
Ok I believe I have merged the commits into one.

Re: WindowMaker: update 0.96.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676127015

Comment:
you can remove all the lines in the commit message and just leave the title

Re: [PR PATCH] [Updated] WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

There is an updated pull request by tstraus13 against master on the void-packages repository

https://github.com/tstraus13/void-packages master
https://github.com/void-linux/void-packages/pull/45554

WindowMaker: update 0.96.0
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45554.patch --]
[-- Type: text/x-diff, Size: 1571 bytes --]

From 3fb63108a69bffd70dc6f4a3fb7aa3b9773bdd13 Mon Sep 17 00:00:00 2001
From: Tom Strausbaugh <tstrausbaugh@straustech.net>
Date: Fri, 11 Aug 2023 16:49:34 -0400
Subject: [PATCH] WindowMaker: update to 0.96.0

---
 srcpkgs/WindowMaker/template | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/WindowMaker/template b/srcpkgs/WindowMaker/template
index 7eceba0ade6d9..3acc1e3720f7e 100644
--- a/srcpkgs/WindowMaker/template
+++ b/srcpkgs/WindowMaker/template
@@ -1,7 +1,7 @@
 # Template file for 'WindowMaker'
 pkgname=WindowMaker
-version=0.95.9
-revision=2
+version=0.96.0
+revision=1
 build_style=gnu-configure
 configure_args="--enable-xinerama --localedir=/usr/share/locale
  --enable-usermenu --enable-modelock --enable-xrandr --enable-wmreplace
@@ -19,9 +19,12 @@ conf_files="
 short_desc="X11 window manager with a NEXTSTEP look and feel"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, WTFPL"
-homepage="http://www.windowmaker.org/"
-distfiles="http://windowmaker.org/pub/source/release/${pkgname}-${version}.tar.gz"
-checksum=f22358ff60301670e1e2b502faad0f2da7ff8976632d538f95fe4638e9c6b714
+homepage="https://www.windowmaker.org/"
+changelog="http://www.windowmaker.org/news/"
+distfiles="https://github.com/window-maker/wmaker/releases/download/wmaker-${version}/WindowMaker-${version}.tar.gz"
+checksum=4fe130ba23cf4aa21c156ec8f01f748df537d0604ec06c6bbcec896df1926f6d
+# tests various things against documentation, doesn't make sense to run
+make_check=no
 
 pre_configure() {
 	autoreconf -fi

Re: WindowMaker: update 0.96.0

[tstraus13]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by tstraus13 on void-packages repository

https://github.com/void-linux/void-packages/pull/45554#issuecomment-1676128032

Comment:
> you can remove all the lines in the commit message and just leave the title

Done... I think.

Re: [PR PATCH] [Merged]: WindowMaker: update 0.96.0

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

There's a merged pull request on the void-packages repository

WindowMaker: update 0.96.0
https://github.com/void-linux/void-packages/pull/45554

Description:
Updated WindowMaker to 0.96.0. It required the distfiles url, version, revision, and checksum to be changed.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)