[PR PATCH] less: update to 643.

[PR PATCH] less: update to 643.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages less
https://github.com/void-linux/void-packages/pull/45600

less: update to 643.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/45600.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-less-45600.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]

From 568a5cf53c26f731cd42be3a55557341b6066aa5 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 14 Aug 2023 10:29:57 +0200
Subject: [PATCH] less: update to 643.

---
 srcpkgs/less/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/less/template b/srcpkgs/less/template
index 72837b74b51c9..16326f60651f2 100644
--- a/srcpkgs/less/template
+++ b/srcpkgs/less/template
@@ -1,6 +1,6 @@
 # Template file for 'less'
 pkgname=less
-version=633
+version=643
 revision=1
 build_style=gnu-configure
 configure_args="--with-regex=pcre2"
@@ -11,7 +11,7 @@ license="GPL-3.0-or-later"
 homepage="https://www.greenwoodsoftware.com/less"
 changelog="https://raw.githubusercontent.com/gwsw/less/master/NEWS"
 distfiles="https://www.greenwoodsoftware.com/less/less-${version}.tar.gz"
-checksum=2f201d64b828b88af36dfe6cfdba3e0819ece2e446ebe6224813209aaefed04f
+checksum=2911b5432c836fa084c8a2e68f6cd6312372c026a58faaa98862731c8b6052e8
 # Tests intentionally not included in tarball
 # (https://github.com/gwsw/less/issues/344).
 make_check=no

Re: [PR REVIEW] less: update to 643.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/45600#discussion_r1293383257

Comment:
The test suite is now included in the tarball.

Re: [PR REVIEW] less: update to 643.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45600#discussion_r1293426889

Comment:
Two of them seem to fail, and the error messages are worse than the ones from C.

Re: [PR REVIEW] less: update to 643.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45600#discussion_r1293426889

Comment:
Two of them seem to fail, and the error messages are worse than the ones from gcc.

Re: [PR PATCH] [Updated] less: update to 643.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages less
https://github.com/void-linux/void-packages/pull/45600

less: update to 643.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/45600.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-less-45600.patch --]
[-- Type: text/x-diff, Size: 1085 bytes --]

From 6925278f29d7c472864a5f3c568cb5a82e3fd055 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 14 Aug 2023 10:29:57 +0200
Subject: [PATCH] less: update to 643.

---
 srcpkgs/less/template | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/less/template b/srcpkgs/less/template
index 72837b74b51c9..8832c0c224c9f 100644
--- a/srcpkgs/less/template
+++ b/srcpkgs/less/template
@@ -1,6 +1,6 @@
 # Template file for 'less'
 pkgname=less
-version=633
+version=643
 revision=1
 build_style=gnu-configure
 configure_args="--with-regex=pcre2"
@@ -11,7 +11,4 @@ license="GPL-3.0-or-later"
 homepage="https://www.greenwoodsoftware.com/less"
 changelog="https://raw.githubusercontent.com/gwsw/less/master/NEWS"
 distfiles="https://www.greenwoodsoftware.com/less/less-${version}.tar.gz"
-checksum=2f201d64b828b88af36dfe6cfdba3e0819ece2e446ebe6224813209aaefed04f
-# Tests intentionally not included in tarball
-# (https://github.com/gwsw/less/issues/344).
-make_check=no
+checksum=2911b5432c836fa084c8a2e68f6cd6312372c026a58faaa98862731c8b6052e8

Re: [PR PATCH] [Updated] less: update to 643.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages less
https://github.com/void-linux/void-packages/pull/45600

less: update to 643.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/45600.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-less-45600.patch --]
[-- Type: text/x-diff, Size: 1229 bytes --]

From 44417e3f5cd4d95fb93c38289c81b37e9a4ec1d3 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 14 Aug 2023 10:29:57 +0200
Subject: [PATCH] less: update to 643.

---
 srcpkgs/less/template | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/less/template b/srcpkgs/less/template
index 72837b74b51c9..00d056e6d5ac7 100644
--- a/srcpkgs/less/template
+++ b/srcpkgs/less/template
@@ -1,17 +1,15 @@
 # Template file for 'less'
 pkgname=less
-version=633
+version=643
 revision=1
 build_style=gnu-configure
 configure_args="--with-regex=pcre2"
 makedepends="ncurses-devel pcre2-devel"
+checkdepends="perl"
 short_desc="Pager program similar to more(1)"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://www.greenwoodsoftware.com/less"
 changelog="https://raw.githubusercontent.com/gwsw/less/master/NEWS"
 distfiles="https://www.greenwoodsoftware.com/less/less-${version}.tar.gz"
-checksum=2f201d64b828b88af36dfe6cfdba3e0819ece2e446ebe6224813209aaefed04f
-# Tests intentionally not included in tarball
-# (https://github.com/gwsw/less/issues/344).
-make_check=no
+checksum=2911b5432c836fa084c8a2e68f6cd6312372c026a58faaa98862731c8b6052e8

Re: less: update to 643.

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/45600#issuecomment-1677604465

Comment:
Less seems to use a different test suite using perl now, the error messages are not that helpful:

```
=> less-643_1: running do_check ...
if [ -x less ] && ./less -V | grep -q LESSTEST; then :; else make clean; make LESSTEST=1; fi
objdir=$(pwd); rflags=""; if [ -z "" ]; then rflags=-e; fi; cd ./lesstest && make && ./runtest $rflags -l "$objdir/less" lt
FAIL: utf8-2.txt (20 steps)
FAIL: chinese1 (29 steps)
if [ -x less ] && ./less -V | grep -q LESSTEST; then :; else make clean; make LESSTEST=1; fi
objdir=$(pwd); rflags=""; if [ -z "" ]; then rflags=-e; fi; cd ./lesstest && make && ./runtest $rflags -l "$objdir/less" lt
make[1]: Entering directory '/builddir/less-643/lesstest'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/builddir/less-643/lesstest'
DIFF utf8-2.txt on cmd #20 (. a)
FAIL: utf8-2.txt (20 steps)
ERR  status 256 from /builddir/less-643/lesstest/lesstest  -e -s '/builddir/less-643/lesstest/lt_screen' -t '/builddir/less-643/lesstest/lt/utf8-2.txt.lt' '/builddir/less-643/less'
DIFF chinese1 on cmd #29 (. a)
FAIL: chinese1 (29 steps)
ERR  status 256 from /builddir/less-643/lesstest/lesstest  -e -s '/builddir/less-643/lesstest/lt_screen' -t '/builddir/less-643/lesstest/lt/chinese1.lt' '/builddir/less-643/less'
RAN  13 tests with 2 errors
make: *** [Makefile:106: check] Error 1
=> ERROR: less-643_1: do_check: '${make_check_pre} ${make_cmd} ${makejobs} ${make_check_args} ${make_check_target}' exited with 2
=> ERROR:   in do_check() at common/build-style/gnu-configure.sh:33
```

Re: [PR PATCH] [Merged]: less: update to 643.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

There's a merged pull request on the void-packages repository

less: update to 643.
https://github.com/void-linux/void-packages/pull/45600

Description:

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc