[PR PATCH] steam-udev-rules: split from steam package

[PR PATCH] steam-udev-rules: split from steam package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages steam-udev-rules
https://github.com/void-linux/void-packages/pull/45832

steam-udev-rules: split from steam package
this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc @abenson


A patch file from https://github.com/void-linux/void-packages/pull/45832.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam-udev-rules-45832.patch --]
[-- Type: text/x-diff, Size: 4761 bytes --]

From c48f239d423c2814c1ee0cbbd7ae569fc241d65c Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 31 Aug 2023 00:03:23 -0400
Subject: [PATCH] steam-udev-rules: split from steam package

this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs
---
 srcpkgs/steam-udev-rules                      |  1 -
 .../files/99-oculus.rules                     |  0
 srcpkgs/steam-udev-rules/template             | 29 ++++++++++++++++++
 srcpkgs/steam/template                        | 30 ++-----------------
 4 files changed, 31 insertions(+), 29 deletions(-)
 delete mode 120000 srcpkgs/steam-udev-rules
 rename srcpkgs/{steam => steam-udev-rules}/files/99-oculus.rules (100%)
 create mode 100644 srcpkgs/steam-udev-rules/template

diff --git a/srcpkgs/steam-udev-rules b/srcpkgs/steam-udev-rules
deleted file mode 120000
index 9fe3d96896344..0000000000000
--- a/srcpkgs/steam-udev-rules
+++ /dev/null
@@ -1 +0,0 @@
-steam
\ No newline at end of file
diff --git a/srcpkgs/steam/files/99-oculus.rules b/srcpkgs/steam-udev-rules/files/99-oculus.rules
similarity index 100%
rename from srcpkgs/steam/files/99-oculus.rules
rename to srcpkgs/steam-udev-rules/files/99-oculus.rules
diff --git a/srcpkgs/steam-udev-rules/template b/srcpkgs/steam-udev-rules/template
new file mode 100644
index 0000000000000..049730d42a0c1
--- /dev/null
+++ b/srcpkgs/steam-udev-rules/template
@@ -0,0 +1,29 @@
+# Template file for 'steam-udev-rules'
+pkgname=steam-udev-rules
+version=1.0.0.61+20230830
+revision=1
+_commit=13443480a64fe8f10676606bd57da6de89f8ccb1
+short_desc="Udev rules for gaming peripherals for Steam and SteamVR"
+maintainer="classabbyamp <void@placeviolette.net>"
+license="MIT"
+homepage="https://github.com/ValveSoftware/steam-devices"
+distfiles="https://github.com/ValveSoftware/steam-devices/archive/${_commit}.tar.gz"
+checksum=2e508acb093d1428f32c3f6b0bc836cc4a20ceef4afc92b6cdb7cf631400fd36
+
+post_patch() {
+	# support access via input group or logind uaccess
+	vsed -e 's/TAG+="uaccess"/GROUP="input", &/g' \
+		-i 60-steam-input.rules \
+		-i 60-steam-vr.rules
+}
+
+do_install() {
+	# Oculus support, see https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
+	vinstall "${FILESDIR}/99-oculus.rules" 644 usr/lib/udev/rules.d
+
+	for f in *.rules; do
+		vinstall "$f" 644 usr/lib/udev/rules.d
+	done
+
+	vlicense LICENSE
+}
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index f9491371b6d37..41a1a9a09fbf7 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -2,8 +2,6 @@
 pkgname=steam
 version=1.0.0.78
 revision=3
-_steam_devices_commit=13443480a64fe8f10676606bd57da6de89f8ccb1
-build_wrksrc="steam-launcher"
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
  liberation-fonts-ttf file tar bash coreutils lsof steam-udev-rules"
@@ -11,18 +9,10 @@ short_desc="Digital distribution client bootstrap package - Valve's steam client
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
 homepage="https://steampowered.com/"
-distfiles="http://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz
- https://github.com/ValveSoftware/steam-devices/archive/${_steam_devices_commit}.tar.gz"
-checksum="104259755d7211b5f101db247ff70ebfed6ae6ca3e14da61195d1fbf91c7200d
- 2e508acb093d1428f32c3f6b0bc836cc4a20ceef4afc92b6cdb7cf631400fd36"
+distfiles="http://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz"
+checksum=104259755d7211b5f101db247ff70ebfed6ae6ca3e14da61195d1fbf91c7200d
 repository=nonfree
 
-post_patch() {
-	vsed -e 's/TAG+="uaccess"/GROUP="input", &/g' \
-		-i ../steam-devices-${_steam_devices_commit}/60-steam-input.rules \
-		-i ../steam-devices-${_steam_devices_commit}/60-steam-vr.rules
-}
-
 do_install() {
 	make DESTDIR=${DESTDIR} install
 
@@ -31,22 +21,6 @@ do_install() {
 	# Ignore steamdeps.
 	ln -sf /bin/true ${DESTDIR}/usr/bin/steamdeps
 
-	# Oculus support: need read-write access to
-	# Valve-owned input event device nodes.
-	# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
-	vinstall ${FILESDIR}/99-oculus.rules 644 usr/lib/udev/rules.d
-
-	# Device support for Steam-related hardware (e.g. controllers over Steam Link)
-	vinstall ../steam-devices-${_steam_devices_commit}/60-steam-input.rules 644 usr/lib/udev/rules.d
-	vinstall ../steam-devices-${_steam_devices_commit}/60-steam-vr.rules 644 usr/lib/udev/rules.d
-
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
-
-steam-udev-rules_package() {
-	short_desc+=" - udev rules for hardware"
-	pkg_install() {
-		vmove usr/lib/udev/rules.d
-	}
-}

Re: [PR PATCH] [Updated] steam-udev-rules: split from steam package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages steam-udev-rules
https://github.com/void-linux/void-packages/pull/45832

steam-udev-rules: split from steam package
this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc @abenson


A patch file from https://github.com/void-linux/void-packages/pull/45832.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam-udev-rules-45832.patch --]
[-- Type: text/x-diff, Size: 4754 bytes --]

From 271e6cc0348093795051e7f6732599e02cbe7a26 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 31 Aug 2023 00:03:23 -0400
Subject: [PATCH] steam-udev-rules: split from steam package

this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs
---
 srcpkgs/steam-udev-rules                      |  1 -
 .../files/99-oculus.rules                     |  0
 srcpkgs/steam-udev-rules/template             | 29 ++++++++++++++++++
 srcpkgs/steam/template                        | 30 ++-----------------
 4 files changed, 31 insertions(+), 29 deletions(-)
 delete mode 120000 srcpkgs/steam-udev-rules
 rename srcpkgs/{steam => steam-udev-rules}/files/99-oculus.rules (100%)
 create mode 100644 srcpkgs/steam-udev-rules/template

diff --git a/srcpkgs/steam-udev-rules b/srcpkgs/steam-udev-rules
deleted file mode 120000
index 9fe3d96896344..0000000000000
--- a/srcpkgs/steam-udev-rules
+++ /dev/null
@@ -1 +0,0 @@
-steam
\ No newline at end of file
diff --git a/srcpkgs/steam/files/99-oculus.rules b/srcpkgs/steam-udev-rules/files/99-oculus.rules
similarity index 100%
rename from srcpkgs/steam/files/99-oculus.rules
rename to srcpkgs/steam-udev-rules/files/99-oculus.rules
diff --git a/srcpkgs/steam-udev-rules/template b/srcpkgs/steam-udev-rules/template
new file mode 100644
index 0000000000000..59fbcf0a5683b
--- /dev/null
+++ b/srcpkgs/steam-udev-rules/template
@@ -0,0 +1,29 @@
+# Template file for 'steam-udev-rules'
+pkgname=steam-udev-rules
+version=2023.08.30
+revision=1
+_commit=13443480a64fe8f10676606bd57da6de89f8ccb1
+short_desc="Udev rules for gaming peripherals for Steam and SteamVR"
+maintainer="classabbyamp <void@placeviolette.net>"
+license="MIT"
+homepage="https://github.com/ValveSoftware/steam-devices"
+distfiles="https://github.com/ValveSoftware/steam-devices/archive/${_commit}.tar.gz"
+checksum=2e508acb093d1428f32c3f6b0bc836cc4a20ceef4afc92b6cdb7cf631400fd36
+
+post_patch() {
+	# support access via input group or logind uaccess
+	vsed -e 's/TAG+="uaccess"/GROUP="input", &/g' \
+		-i 60-steam-input.rules \
+		-i 60-steam-vr.rules
+}
+
+do_install() {
+	# Oculus support, see https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
+	vinstall "${FILESDIR}/99-oculus.rules" 644 usr/lib/udev/rules.d
+
+	for f in *.rules; do
+		vinstall "$f" 644 usr/lib/udev/rules.d
+	done
+
+	vlicense LICENSE
+}
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index f9491371b6d37..41a1a9a09fbf7 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -2,8 +2,6 @@
 pkgname=steam
 version=1.0.0.78
 revision=3
-_steam_devices_commit=13443480a64fe8f10676606bd57da6de89f8ccb1
-build_wrksrc="steam-launcher"
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
  liberation-fonts-ttf file tar bash coreutils lsof steam-udev-rules"
@@ -11,18 +9,10 @@ short_desc="Digital distribution client bootstrap package - Valve's steam client
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
 homepage="https://steampowered.com/"
-distfiles="http://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz
- https://github.com/ValveSoftware/steam-devices/archive/${_steam_devices_commit}.tar.gz"
-checksum="104259755d7211b5f101db247ff70ebfed6ae6ca3e14da61195d1fbf91c7200d
- 2e508acb093d1428f32c3f6b0bc836cc4a20ceef4afc92b6cdb7cf631400fd36"
+distfiles="http://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz"
+checksum=104259755d7211b5f101db247ff70ebfed6ae6ca3e14da61195d1fbf91c7200d
 repository=nonfree
 
-post_patch() {
-	vsed -e 's/TAG+="uaccess"/GROUP="input", &/g' \
-		-i ../steam-devices-${_steam_devices_commit}/60-steam-input.rules \
-		-i ../steam-devices-${_steam_devices_commit}/60-steam-vr.rules
-}
-
 do_install() {
 	make DESTDIR=${DESTDIR} install
 
@@ -31,22 +21,6 @@ do_install() {
 	# Ignore steamdeps.
 	ln -sf /bin/true ${DESTDIR}/usr/bin/steamdeps
 
-	# Oculus support: need read-write access to
-	# Valve-owned input event device nodes.
-	# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
-	vinstall ${FILESDIR}/99-oculus.rules 644 usr/lib/udev/rules.d
-
-	# Device support for Steam-related hardware (e.g. controllers over Steam Link)
-	vinstall ../steam-devices-${_steam_devices_commit}/60-steam-input.rules 644 usr/lib/udev/rules.d
-	vinstall ../steam-devices-${_steam_devices_commit}/60-steam-vr.rules 644 usr/lib/udev/rules.d
-
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
-
-steam-udev-rules_package() {
-	short_desc+=" - udev rules for hardware"
-	pkg_install() {
-		vmove usr/lib/udev/rules.d
-	}
-}

Re: steam-udev-rules: split from steam package

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45832#issuecomment-1701038823

Comment:
Only suggestion i would make is to prepend at least one`0.` to the version in case they ever start to tag releases. 

Re: steam-udev-rules: split from steam package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45832#issuecomment-1701044040

Comment:
I was thinking of doing `1.0.0.61+20230830` because they have tagged before just not in a long time. chose not to because it was at 1.0.0.78 when part of the stream pkg but i guess `reverts` will fix that

Re: steam-udev-rules: split from steam package

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45832#issuecomment-1701118684

Comment:
ah right didn't think about that

Re: [PR PATCH] [Updated] steam-udev-rules: split from steam package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages steam-udev-rules
https://github.com/void-linux/void-packages/pull/45832

steam-udev-rules: split from steam package
this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc @abenson


A patch file from https://github.com/void-linux/void-packages/pull/45832.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam-udev-rules-45832.patch --]
[-- Type: text/x-diff, Size: 4795 bytes --]

From b74969b10154bbe04347daff3c4f194bd196f78f Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 31 Aug 2023 00:03:23 -0400
Subject: [PATCH] steam-udev-rules: split from steam package

this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs
---
 srcpkgs/steam-udev-rules                      |  1 -
 .../files/99-oculus.rules                     |  0
 srcpkgs/steam-udev-rules/template             | 30 +++++++++++++++++++
 srcpkgs/steam/template                        | 30 ++-----------------
 4 files changed, 32 insertions(+), 29 deletions(-)
 delete mode 120000 srcpkgs/steam-udev-rules
 rename srcpkgs/{steam => steam-udev-rules}/files/99-oculus.rules (100%)
 create mode 100644 srcpkgs/steam-udev-rules/template

diff --git a/srcpkgs/steam-udev-rules b/srcpkgs/steam-udev-rules
deleted file mode 120000
index 9fe3d96896344..0000000000000
--- a/srcpkgs/steam-udev-rules
+++ /dev/null
@@ -1 +0,0 @@
-steam
\ No newline at end of file
diff --git a/srcpkgs/steam/files/99-oculus.rules b/srcpkgs/steam-udev-rules/files/99-oculus.rules
similarity index 100%
rename from srcpkgs/steam/files/99-oculus.rules
rename to srcpkgs/steam-udev-rules/files/99-oculus.rules
diff --git a/srcpkgs/steam-udev-rules/template b/srcpkgs/steam-udev-rules/template
new file mode 100644
index 0000000000000..a09108e92e9db
--- /dev/null
+++ b/srcpkgs/steam-udev-rules/template
@@ -0,0 +1,30 @@
+# Template file for 'steam-udev-rules'
+pkgname=steam-udev-rules
+reverts="1.0.0.78_2 1.0.0.78_3"
+version=1.0.0.61+20230830
+revision=1
+_commit=13443480a64fe8f10676606bd57da6de89f8ccb1
+short_desc="Udev rules for gaming peripherals for Steam and SteamVR"
+maintainer="classabbyamp <void@placeviolette.net>"
+license="MIT"
+homepage="https://github.com/ValveSoftware/steam-devices"
+distfiles="https://github.com/ValveSoftware/steam-devices/archive/${_commit}.tar.gz"
+checksum=2e508acb093d1428f32c3f6b0bc836cc4a20ceef4afc92b6cdb7cf631400fd36
+
+post_patch() {
+	# support access via input group or logind uaccess
+	vsed -e 's/TAG+="uaccess"/GROUP="input", &/g' \
+		-i 60-steam-input.rules \
+		-i 60-steam-vr.rules
+}
+
+do_install() {
+	# Oculus support, see https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
+	vinstall "${FILESDIR}/99-oculus.rules" 644 usr/lib/udev/rules.d
+
+	for f in *.rules; do
+		vinstall "$f" 644 usr/lib/udev/rules.d
+	done
+
+	vlicense LICENSE
+}
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index f9491371b6d37..41a1a9a09fbf7 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -2,8 +2,6 @@
 pkgname=steam
 version=1.0.0.78
 revision=3
-_steam_devices_commit=13443480a64fe8f10676606bd57da6de89f8ccb1
-build_wrksrc="steam-launcher"
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
  liberation-fonts-ttf file tar bash coreutils lsof steam-udev-rules"
@@ -11,18 +9,10 @@ short_desc="Digital distribution client bootstrap package - Valve's steam client
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
 homepage="https://steampowered.com/"
-distfiles="http://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz
- https://github.com/ValveSoftware/steam-devices/archive/${_steam_devices_commit}.tar.gz"
-checksum="104259755d7211b5f101db247ff70ebfed6ae6ca3e14da61195d1fbf91c7200d
- 2e508acb093d1428f32c3f6b0bc836cc4a20ceef4afc92b6cdb7cf631400fd36"
+distfiles="http://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz"
+checksum=104259755d7211b5f101db247ff70ebfed6ae6ca3e14da61195d1fbf91c7200d
 repository=nonfree
 
-post_patch() {
-	vsed -e 's/TAG+="uaccess"/GROUP="input", &/g' \
-		-i ../steam-devices-${_steam_devices_commit}/60-steam-input.rules \
-		-i ../steam-devices-${_steam_devices_commit}/60-steam-vr.rules
-}
-
 do_install() {
 	make DESTDIR=${DESTDIR} install
 
@@ -31,22 +21,6 @@ do_install() {
 	# Ignore steamdeps.
 	ln -sf /bin/true ${DESTDIR}/usr/bin/steamdeps
 
-	# Oculus support: need read-write access to
-	# Valve-owned input event device nodes.
-	# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
-	vinstall ${FILESDIR}/99-oculus.rules 644 usr/lib/udev/rules.d
-
-	# Device support for Steam-related hardware (e.g. controllers over Steam Link)
-	vinstall ../steam-devices-${_steam_devices_commit}/60-steam-input.rules 644 usr/lib/udev/rules.d
-	vinstall ../steam-devices-${_steam_devices_commit}/60-steam-vr.rules 644 usr/lib/udev/rules.d
-
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
-
-steam-udev-rules_package() {
-	short_desc+=" - udev rules for hardware"
-	pkg_install() {
-		vmove usr/lib/udev/rules.d
-	}
-}

Re: [PR PATCH] [Merged]: steam-udev-rules: split from steam package

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

There's a merged pull request on the void-packages repository

steam-udev-rules: split from steam package
https://github.com/void-linux/void-packages/pull/45832

Description:
this is advantageous for several reasons:
- accurate license (and not in /nonfree/)
- can be updated independent from steam
- available for all archs

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

cc @abenson