Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] {send,receive}midi: respect LDFLAGS
@ 2023-09-09 14:22 sgn
  2023-09-09 14:28 ` Duncaen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: sgn @ 2023-09-09 14:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages send-receive-mid-ldflags
https://github.com/void-linux/void-packages/pull/45992

{send,receive}midi: respect LDFLAGS
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

I have no idea how to test this.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/45992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-send-receive-mid-ldflags-45992.patch --]
[-- Type: text/x-diff, Size: 2197 bytes --]

From 741e3ce8d26559cc1ad56a9f36cbf9acb5b5d074 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sat, 9 Sep 2023 21:17:49 +0700
Subject: [PATCH] {send,receive}midi: respect LDFLAGS

---
 srcpkgs/receivemidi/template | 11 ++++-------
 srcpkgs/sendmidi/template    |  9 ++++-----
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/srcpkgs/receivemidi/template b/srcpkgs/receivemidi/template
index 4f9a0b7566cd5..f02c4afaa0dd9 100644
--- a/srcpkgs/receivemidi/template
+++ b/srcpkgs/receivemidi/template
@@ -1,10 +1,8 @@
 # Template file for 'receivemidi'
 pkgname=receivemidi
 version=1.3.1
-revision=1
+revision=2
 build_wrksrc="Builds/LinuxMakefile"
-build_style=gnu-makefile
-make_build_args="CONFIG=Release"
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel"
 short_desc="Command-line tool to monitor and receive MIDI messages"
@@ -15,10 +13,9 @@ changelog="https://github.com/gbevin/ReceiveMIDI/releases"
 distfiles="https://github.com/gbevin/ReceiveMIDI/archive/refs/tags/${version}.tar.gz"
 checksum=54697ad1a723eea5e3f19ec3bf153795e765b278953dde8be7f350001637bc0a
 
-post_patch() {
-	if [ -z "$XBPS_TARGET_NO_ATOMIC8" ]; then
-		vsed -e 's/-latomic//g' -i Makefile
-	fi
+do_build() {
+	export JUCE_LDFLAGS="$LDFLAGS"
+	make ${makejobs} CONFIG=Release V=1
 }
 
 do_install() {
diff --git a/srcpkgs/sendmidi/template b/srcpkgs/sendmidi/template
index 2b44c25e7247a..c50f827d518ae 100644
--- a/srcpkgs/sendmidi/template
+++ b/srcpkgs/sendmidi/template
@@ -1,7 +1,7 @@
 # Template file for 'sendmidi'
 pkgname=sendmidi
 version=1.2.1
-revision=1
+revision=2
 build_wrksrc="Builds/LinuxMakefile"
 build_style=gnu-makefile
 make_build_args="CONFIG=Release"
@@ -15,10 +15,9 @@ changelog="https://github.com/gbevin/SendMIDI/releases"
 distfiles="https://github.com/gbevin/SendMIDI/archive/refs/tags/${version}.tar.gz"
 checksum=3fb3d16ee14784e057e633b6e57fede33ac291d9af85942106fde8b431e15740
 
-post_patch() {
-	if [ -z "$XBPS_TARGET_NO_ATOMIC8" ]; then
-		vsed -e 's/-latomic//g' -i Makefile
-	fi
+do_build() {
+	export JUCE_LDFLAGS="$LDFLAGS"
+	make ${makejobs} CONFIG=Release V=1
 }
 
 do_install() {

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: {send,receive}midi: respect LDFLAGS
  2023-09-09 14:22 [PR PATCH] {send,receive}midi: respect LDFLAGS sgn
@ 2023-09-09 14:28 ` Duncaen
  2023-09-09 14:29 ` Duncaen
  2023-09-12 14:47 ` [PR PATCH] [Merged]: " sgn
  2 siblings, 0 replies; 4+ messages in thread
From: Duncaen @ 2023-09-09 14:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45992#issuecomment-1712524771

Comment:
Shoud be fine if it builds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: {send,receive}midi: respect LDFLAGS
  2023-09-09 14:22 [PR PATCH] {send,receive}midi: respect LDFLAGS sgn
  2023-09-09 14:28 ` Duncaen
@ 2023-09-09 14:29 ` Duncaen
  2023-09-12 14:47 ` [PR PATCH] [Merged]: " sgn
  2 siblings, 0 replies; 4+ messages in thread
From: Duncaen @ 2023-09-09 14:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45992#issuecomment-1712524771

Comment:
Should be fine if it builds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: {send,receive}midi: respect LDFLAGS
  2023-09-09 14:22 [PR PATCH] {send,receive}midi: respect LDFLAGS sgn
  2023-09-09 14:28 ` Duncaen
  2023-09-09 14:29 ` Duncaen
@ 2023-09-12 14:47 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: sgn @ 2023-09-12 14:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

There's a merged pull request on the void-packages repository

{send,receive}midi: respect LDFLAGS
https://github.com/void-linux/void-packages/pull/45992

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

I have no idea how to test this.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-12 14:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-09 14:22 [PR PATCH] {send,receive}midi: respect LDFLAGS sgn
2023-09-09 14:28 ` Duncaen
2023-09-09 14:29 ` Duncaen
2023-09-12 14:47 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).