* [PR PATCH] greetd: install manpages
@ 2023-09-20 18:36 dkwo
2023-09-21 16:42 ` [PR REVIEW] " classabbyamp
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dkwo @ 2023-09-20 18:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
There is a new pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages greetd
https://github.com/void-linux/void-packages/pull/46160
greetd: install manpages
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)
cc maintainer @cinerea0
A patch file from https://github.com/void-linux/void-packages/pull/46160.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-greetd-46160.patch --]
[-- Type: text/x-diff, Size: 1123 bytes --]
From 606cf68462e14c0e90808a94364fdfa7d359890f Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Wed, 20 Sep 2023 14:33:39 -0400
Subject: [PATCH] greetd: install manpages
---
srcpkgs/greetd/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/greetd/template b/srcpkgs/greetd/template
index b1603ed736665..ebdd44f2a37db 100644
--- a/srcpkgs/greetd/template
+++ b/srcpkgs/greetd/template
@@ -1,7 +1,7 @@
# Template file for 'greetd'
pkgname=greetd
version=0.9.0
-revision=1
+revision=2
build_style=cargo
conf_files="/etc/greetd/config.toml"
hostmakedepends="pkg-config scdoc"
@@ -19,8 +19,7 @@ _greeter_homedir="/var/lib/_greeter"
make_dirs="/var/lib/_greeter 0755 _greeter _greeter"
pre_build() {
- cd man
- make all
+ make -C man
}
do_install() {
@@ -29,8 +28,9 @@ do_install() {
vbin "target/${RUST_TARGET}/release/greetd"
vinstall config.toml 644 etc/greetd/
- cd man
- make install
+ for m in agreety.1 greetd.1 greetd.5 greetd-ipc.7; do
+ vman man/${m}
+ done
vinstall ${FILESDIR}/greetd.pam 644 etc/pam.d/ greetd
vsv greetd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] greetd: install manpages
2023-09-20 18:36 [PR PATCH] greetd: install manpages dkwo
@ 2023-09-21 16:42 ` classabbyamp
2023-09-21 16:44 ` classabbyamp
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-09-21 16:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/46160#discussion_r1333348909
Comment:
```suggestion
make -C man install PREFIX=/usr DESTDIR="$DESTDIR"
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] greetd: install manpages
2023-09-20 18:36 [PR PATCH] greetd: install manpages dkwo
2023-09-21 16:42 ` [PR REVIEW] " classabbyamp
@ 2023-09-21 16:44 ` classabbyamp
2023-09-21 17:24 ` [PR PATCH] [Updated] " dkwo
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-09-21 16:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/46160#discussion_r1333348909
Comment:
the only thing wrong was it was installing to `/usr/local/share/man/...` by default
```suggestion
make -C man install PREFIX=/usr DESTDIR="$DESTDIR"
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] greetd: install manpages
2023-09-20 18:36 [PR PATCH] greetd: install manpages dkwo
2023-09-21 16:42 ` [PR REVIEW] " classabbyamp
2023-09-21 16:44 ` classabbyamp
@ 2023-09-21 17:24 ` dkwo
2023-09-21 17:26 ` [PR REVIEW] " dkwo
2023-09-21 17:40 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: dkwo @ 2023-09-21 17:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages greetd
https://github.com/void-linux/void-packages/pull/46160
greetd: install manpages
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)
cc maintainer @cinerea0
A patch file from https://github.com/void-linux/void-packages/pull/46160.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-greetd-46160.patch --]
[-- Type: text/x-diff, Size: 1093 bytes --]
From 0a61693ca9ac2870ba9f37ede1990032c85cdb1b Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Wed, 20 Sep 2023 14:33:39 -0400
Subject: [PATCH] greetd: install manpages
---
srcpkgs/greetd/template | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/greetd/template b/srcpkgs/greetd/template
index b1603ed736665..61f2b4be31091 100644
--- a/srcpkgs/greetd/template
+++ b/srcpkgs/greetd/template
@@ -1,7 +1,7 @@
# Template file for 'greetd'
pkgname=greetd
version=0.9.0
-revision=1
+revision=2
build_style=cargo
conf_files="/etc/greetd/config.toml"
hostmakedepends="pkg-config scdoc"
@@ -19,8 +19,7 @@ _greeter_homedir="/var/lib/_greeter"
make_dirs="/var/lib/_greeter 0755 _greeter _greeter"
pre_build() {
- cd man
- make all
+ make -C man
}
do_install() {
@@ -29,8 +28,7 @@ do_install() {
vbin "target/${RUST_TARGET}/release/greetd"
vinstall config.toml 644 etc/greetd/
- cd man
- make install
+ make -C man install PREFIX=/usr DESTDIR="$DESTDIR"
vinstall ${FILESDIR}/greetd.pam 644 etc/pam.d/ greetd
vsv greetd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] greetd: install manpages
2023-09-20 18:36 [PR PATCH] greetd: install manpages dkwo
` (2 preceding siblings ...)
2023-09-21 17:24 ` [PR PATCH] [Updated] " dkwo
@ 2023-09-21 17:26 ` dkwo
2023-09-21 17:40 ` [PR PATCH] [Merged]: " classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: dkwo @ 2023-09-21 17:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
New review comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/46160#discussion_r1333391646
Comment:
done
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: greetd: install manpages
2023-09-20 18:36 [PR PATCH] greetd: install manpages dkwo
` (3 preceding siblings ...)
2023-09-21 17:26 ` [PR REVIEW] " dkwo
@ 2023-09-21 17:40 ` classabbyamp
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2023-09-21 17:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
There's a merged pull request on the void-packages repository
greetd: install manpages
https://github.com/void-linux/void-packages/pull/46160
Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)
cc maintainer @cinerea0
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-21 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-20 18:36 [PR PATCH] greetd: install manpages dkwo
2023-09-21 16:42 ` [PR REVIEW] " classabbyamp
2023-09-21 16:44 ` classabbyamp
2023-09-21 17:24 ` [PR PATCH] [Updated] " dkwo
2023-09-21 17:26 ` [PR REVIEW] " dkwo
2023-09-21 17:40 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).