* [PR PATCH] New package: PWAsForFirefox-2.7.3
@ 2023-09-28 20:52 Feleuxens
2023-09-28 22:02 ` [PR REVIEW] " Bnyro
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: Feleuxens @ 2023-09-28 20:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
There is a new pull request by Feleuxens against master on the void-packages repository
https://github.com/Feleuxens/void-packages PWAsForFirefox
https://github.com/void-linux/void-packages/pull/46316
New package: PWAsForFirefox-2.7.3
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/46316.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PWAsForFirefox-46316.patch --]
[-- Type: text/x-diff, Size: 2136 bytes --]
From cbb1366dce23592a2db75d40cc9aa316bcd88027 Mon Sep 17 00:00:00 2001
From: Feleuxens <felixgrueb@icloud.com>
Date: Thu, 28 Sep 2023 22:42:49 +0200
Subject: [PATCH] New package: PWAsForFirefox-2.7.3
---
srcpkgs/PWAsForFirefox/template | 36 +++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 srcpkgs/PWAsForFirefox/template
diff --git a/srcpkgs/PWAsForFirefox/template b/srcpkgs/PWAsForFirefox/template
new file mode 100644
index 0000000000000..026f4e78ba214
--- /dev/null
+++ b/srcpkgs/PWAsForFirefox/template
@@ -0,0 +1,36 @@
+# Template file for 'PWAsForFirefox'
+pkgname=PWAsForFirefox
+version=2.7.3
+revision=1
+archs="~*-musl"
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="openssl-devel"
+depends="firefox"
+short_desc="Native part of the firefox extension PWAsForFirefox"
+maintainer="Feleuxens <me@feleuxens.de>"
+license="MPL-2.0"
+homepage="https://github.com/filips123/PWAsForFirefox"
+distfiles="https://github.com/filips123/PWAsForFirefox/archive/refs/tags/v${version}.tar.gz"
+checksum=b520cf5caeeca1d23043a032137f7eead7eb88270e5376c5d08b1234bb90376f
+
+post_extract() {
+ # rm everything except native/
+ find . -mindepth 1 -maxdepth 1 -not -name native -exec rm -r '{}' \;
+ # move everything inside native to root
+ mv native/* .
+ # set version because it is set to 0.0.0
+ sed -i "s/0.0.0/${version}/" Cargo.toml
+ sed -i "/firefoxpwa/,/0.0.0/ s/0.0.0/${version}/" Cargo.lock
+ sed -i "s/DISTRIBUTION_VERSION = \"0.0.0\"/DISTRIBUTION_VERSION = \"${version}\"/g" userchrome/profile/chrome/pwa/chrome.jsm
+}
+
+do_install() {
+ install -D "target/${RUST_TARGET}/release/firefoxpwa" "${DESTDIR}/usr/bin/firefoxpwa"
+ install -D "target/${RUST_TARGET}/release/firefoxpwa-connector" "${DESTDIR}/usr/libexec/firefoxpwa-connector"
+ install -D manifests/linux.json "${DESTDIR}/usr/lib/mozilla/native-messaging-hosts/firefoxpwa.json"
+ install -D manifests/linux.json "${DESTDIR}/usr/lib64/mozilla/native-messaging-hosts/firefoxpwa.json"
+
+ mkdir -p "${DESTDIR}/usr/share/firefoxpwa/userchrome/"
+ cp -R userchrome/* "${DESTDIR}/usr/share/firefoxpwa/userchrome/"
+}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
@ 2023-09-28 22:02 ` Bnyro
2023-09-28 22:04 ` Bnyro
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Bnyro @ 2023-09-28 22:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New review comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1340706164
Comment:
Please use vsed instead of see everywhere here.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
2023-09-28 22:02 ` [PR REVIEW] " Bnyro
@ 2023-09-28 22:04 ` Bnyro
2023-09-28 22:04 ` Bnyro
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Bnyro @ 2023-09-28 22:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
New review comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1340707032
Comment:
```suggestion
vmkdir -p "usr/share/firefoxpwa/userchrome/"
```
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
2023-09-28 22:02 ` [PR REVIEW] " Bnyro
2023-09-28 22:04 ` Bnyro
@ 2023-09-28 22:04 ` Bnyro
2023-09-28 22:04 ` Bnyro
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Bnyro @ 2023-09-28 22:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
New review comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1340706705
Comment:
All this should be vinstall, see https://github.com/void-linux/void-packages/blob/master/Manual.md#global-functions
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (2 preceding siblings ...)
2023-09-28 22:04 ` Bnyro
@ 2023-09-28 22:04 ` Bnyro
2023-09-28 22:06 ` Bnyro
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Bnyro @ 2023-09-28 22:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
New review comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1340707406
Comment:
```suggestion
vcopy userchrome/* "usr/share/firefoxpwa/userchrome/"
```
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (3 preceding siblings ...)
2023-09-28 22:04 ` Bnyro
@ 2023-09-28 22:06 ` Bnyro
2023-09-28 22:13 ` Bnyro
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Bnyro @ 2023-09-28 22:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
New review comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1340708553
Comment:
It would be simpler to use `post_install()` instead, then we can drop the first line of the current `do_install()`
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (4 preceding siblings ...)
2023-09-28 22:06 ` Bnyro
@ 2023-09-28 22:13 ` Bnyro
2023-09-29 13:49 ` [PR PATCH] [Updated] " Feleuxens
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Bnyro @ 2023-09-28 22:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New review comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1340711839
Comment:
Any particular reason why musl is unsupported? Or do the builds just fail for musl for unknown reasons here while musl is generally supported?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (5 preceding siblings ...)
2023-09-28 22:13 ` Bnyro
@ 2023-09-29 13:49 ` Feleuxens
2023-09-29 13:53 ` [PR REVIEW] " Feleuxens
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Feleuxens @ 2023-09-29 13:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
There is an updated pull request by Feleuxens against master on the void-packages repository
https://github.com/Feleuxens/void-packages PWAsForFirefox
https://github.com/void-linux/void-packages/pull/46316
New package: PWAsForFirefox-2.7.3
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/46316.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PWAsForFirefox-46316.patch --]
[-- Type: text/x-diff, Size: 1967 bytes --]
From ccb1be0916510e0a177fab51437415b60b81041a Mon Sep 17 00:00:00 2001
From: Feleuxens <felixgrueb@icloud.com>
Date: Thu, 28 Sep 2023 22:42:49 +0200
Subject: [PATCH] New package: PWAsForFirefox-2.7.3
---
srcpkgs/PWAsForFirefox/template | 35 +++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 srcpkgs/PWAsForFirefox/template
diff --git a/srcpkgs/PWAsForFirefox/template b/srcpkgs/PWAsForFirefox/template
new file mode 100644
index 0000000000000..b1e52122c2e5d
--- /dev/null
+++ b/srcpkgs/PWAsForFirefox/template
@@ -0,0 +1,35 @@
+# Template file for 'PWAsForFirefox'
+pkgname=PWAsForFirefox
+version=2.7.3
+revision=1
+archs="~*-musl"
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="openssl-devel"
+depends="firefox"
+short_desc="Native part of the firefox extension PWAsForFirefox"
+maintainer="Feleuxens <me@feleuxens.de>"
+license="MPL-2.0"
+homepage="https://github.com/filips123/PWAsForFirefox"
+distfiles="https://github.com/filips123/PWAsForFirefox/archive/refs/tags/v${version}.tar.gz"
+checksum=b520cf5caeeca1d23043a032137f7eead7eb88270e5376c5d08b1234bb90376f
+
+post_extract() {
+ # rm everything except native/
+ find . -mindepth 1 -maxdepth 1 -not -name native -exec rm -r '{}' \;
+ # move everything inside native to root
+ mv native/* .
+ # set version because it is set to 0.0.0
+ vsed -i "s/0.0.0/${version}/" Cargo.toml
+ vsed -i "/firefoxpwa/,/0.0.0/ s/0.0.0/${version}/" Cargo.lock
+ vsed -i "s/DISTRIBUTION_VERSION = '0.0.0'/DISTRIBUTION_VERSION = '${version}'/g" userchrome/profile/chrome/pwa/chrome.jsm
+}
+
+post_install() {
+ vinstall "target/${RUST_TARGET}/release/firefoxpwa-connector" 755 usr/libexec
+ vinstall manifests/linux.json 644 usr/lib/mozilla/native-messaging-hosts firefoxpwa.json
+ vinstall manifests/linux.json 644 usr/lib64/mozilla/native-messaging-hosts firefoxpwa.json
+
+ vmkdir usr/share/firefoxpwa/userchrome/
+ vcopy userchrome/* usr/share/firefoxpwa/userchrome/
+}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR REVIEW] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (6 preceding siblings ...)
2023-09-29 13:49 ` [PR PATCH] [Updated] " Feleuxens
@ 2023-09-29 13:53 ` Feleuxens
2023-10-03 20:55 ` [PR PATCH] [Updated] " Feleuxens
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Feleuxens @ 2023-09-29 13:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New review comment by Feleuxens on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#discussion_r1341394577
Comment:
The author of the program lists glibc as a requirement. I don't know if musl would work anyway.
https://github.com/filips123/PWAsForFirefox/tree/main/native#requirements
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] New package: PWAsForFirefox-2.7.3
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (7 preceding siblings ...)
2023-09-29 13:53 ` [PR REVIEW] " Feleuxens
@ 2023-10-03 20:55 ` Feleuxens
2024-01-02 1:47 ` New package: PWAsForFirefox-2.8.0 github-actions
2024-01-17 1:47 ` [PR PATCH] [Closed]: " github-actions
10 siblings, 0 replies; 12+ messages in thread
From: Feleuxens @ 2023-10-03 20:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
There is an updated pull request by Feleuxens against master on the void-packages repository
https://github.com/Feleuxens/void-packages PWAsForFirefox
https://github.com/void-linux/void-packages/pull/46316
New package: PWAsForFirefox-2.7.3
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/46316.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-PWAsForFirefox-46316.patch --]
[-- Type: text/x-diff, Size: 1967 bytes --]
From f948006b142d7341c606193e4b85c174dea4809a Mon Sep 17 00:00:00 2001
From: Feleuxens <felixgrueb@icloud.com>
Date: Thu, 28 Sep 2023 22:42:49 +0200
Subject: [PATCH] New package: PWAsForFirefox-2.8.0
---
srcpkgs/PWAsForFirefox/template | 35 +++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 srcpkgs/PWAsForFirefox/template
diff --git a/srcpkgs/PWAsForFirefox/template b/srcpkgs/PWAsForFirefox/template
new file mode 100644
index 0000000000000..558deef7f9440
--- /dev/null
+++ b/srcpkgs/PWAsForFirefox/template
@@ -0,0 +1,35 @@
+# Template file for 'PWAsForFirefox'
+pkgname=PWAsForFirefox
+version=2.8.0
+revision=1
+archs="~*-musl"
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="openssl-devel"
+depends="firefox"
+short_desc="Native part of the firefox extension PWAsForFirefox"
+maintainer="Feleuxens <me@feleuxens.de>"
+license="MPL-2.0"
+homepage="https://github.com/filips123/PWAsForFirefox"
+distfiles="https://github.com/filips123/PWAsForFirefox/archive/refs/tags/v${version}.tar.gz"
+checksum=d2aff50d963d9d197b41f8736d9fbc3a01922f455d7b90eae1ce80dab3d9f313
+
+post_extract() {
+ # rm everything except native/
+ find . -mindepth 1 -maxdepth 1 -not -name native -exec rm -r '{}' \;
+ # move everything inside native to root
+ mv native/* .
+ # set version because it is set to 0.0.0
+ vsed -i "s/0.0.0/${version}/" Cargo.toml
+ vsed -i "/firefoxpwa/,/0.0.0/ s/0.0.0/${version}/" Cargo.lock
+ vsed -i "s/DISTRIBUTION_VERSION = '0.0.0'/DISTRIBUTION_VERSION = '${version}'/g" userchrome/profile/chrome/pwa/chrome.jsm
+}
+
+post_install() {
+ vinstall "target/${RUST_TARGET}/release/firefoxpwa-connector" 755 usr/libexec
+ vinstall manifests/linux.json 644 usr/lib/mozilla/native-messaging-hosts firefoxpwa.json
+ vinstall manifests/linux.json 644 usr/lib64/mozilla/native-messaging-hosts firefoxpwa.json
+
+ vmkdir usr/share/firefoxpwa/userchrome/
+ vcopy userchrome/* usr/share/firefoxpwa/userchrome/
+}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: New package: PWAsForFirefox-2.8.0
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (8 preceding siblings ...)
2023-10-03 20:55 ` [PR PATCH] [Updated] " Feleuxens
@ 2024-01-02 1:47 ` github-actions
2024-01-17 1:47 ` [PR PATCH] [Closed]: " github-actions
10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2024-01-02 1:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/46316#issuecomment-1873559928
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Closed]: New package: PWAsForFirefox-2.8.0
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
` (9 preceding siblings ...)
2024-01-02 1:47 ` New package: PWAsForFirefox-2.8.0 github-actions
@ 2024-01-17 1:47 ` github-actions
10 siblings, 0 replies; 12+ messages in thread
From: github-actions @ 2024-01-17 1:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
There's a closed pull request on the void-packages repository
New package: PWAsForFirefox-2.8.0
https://github.com/void-linux/void-packages/pull/46316
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-01-17 1:47 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-28 20:52 [PR PATCH] New package: PWAsForFirefox-2.7.3 Feleuxens
2023-09-28 22:02 ` [PR REVIEW] " Bnyro
2023-09-28 22:04 ` Bnyro
2023-09-28 22:04 ` Bnyro
2023-09-28 22:04 ` Bnyro
2023-09-28 22:06 ` Bnyro
2023-09-28 22:13 ` Bnyro
2023-09-29 13:49 ` [PR PATCH] [Updated] " Feleuxens
2023-09-29 13:53 ` [PR REVIEW] " Feleuxens
2023-10-03 20:55 ` [PR PATCH] [Updated] " Feleuxens
2024-01-02 1:47 ` New package: PWAsForFirefox-2.8.0 github-actions
2024-01-17 1:47 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).