[PR PATCH] radicale: fix permissions post-install

[PR PATCH] radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

There is a new pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages fix/radicale
https://github.com/void-linux/void-packages/pull/46357

radicale: fix permissions post-install
Picks up #39973

Also add `_` prefix to system user

A patch file from https://github.com/void-linux/void-packages/pull/46357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/radicale-46357.patch --]
[-- Type: text/x-diff, Size: 2459 bytes --]

From 5f0bb42a609d93879e8a2546b807029245abfa35 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Sun, 1 Oct 2023 21:47:46 +0200
Subject: [PATCH] radicale: fix permissions post-install

---
 srcpkgs/radicale/INSTALL            | 11 +++++++++++
 srcpkgs/radicale/files/radicale/run |  2 +-
 srcpkgs/radicale/template           | 13 ++++++-------
 3 files changed, 18 insertions(+), 8 deletions(-)
 create mode 100644 srcpkgs/radicale/INSTALL

diff --git a/srcpkgs/radicale/INSTALL b/srcpkgs/radicale/INSTALL
new file mode 100644
index 0000000000000..830c308f38534
--- /dev/null
+++ b/srcpkgs/radicale/INSTALL
@@ -0,0 +1,11 @@
+# *-*-shell-*-*
+#
+case ${ACTION} in
+post)
+	# fix permissions and owners
+    chown _radicale:_radicale /etc/radicale/config
+    chown _radicale:_radicale /etc/radicale/rights
+    chmod 644 /etc/radicale/config
+    chmod 640 /etc/radicale/rights
+	;;
+esac
diff --git a/srcpkgs/radicale/files/radicale/run b/srcpkgs/radicale/files/radicale/run
index ab664721091e9..f9f20fa972320 100755
--- a/srcpkgs/radicale/files/radicale/run
+++ b/srcpkgs/radicale/files/radicale/run
@@ -1,3 +1,3 @@
 #!/bin/sh
 exec 2>&1
-exec chpst -u radicale radicale -C /etc/radicale/config
+exec chpst -u _radicale _radicale -C /etc/radicale/config
diff --git a/srcpkgs/radicale/template b/srcpkgs/radicale/template
index a6fabe065463c..b5a0cb3a0a33f 100644
--- a/srcpkgs/radicale/template
+++ b/srcpkgs/radicale/template
@@ -1,7 +1,7 @@
 # Template file for 'radicale'
 pkgname=radicale
 version=3.1.8
-revision=3
+revision=4
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-vobject python3-dateutil python3-passlib python3-bcrypt
@@ -22,11 +22,11 @@ conf_files="
 make_dirs="
  /etc/radicale 755 root root
  /usr/share/radicale/ 755 root root
- /var/log/radicale/ 700 root root
- /var/lib/radicale 750 radicale radicale"
-system_accounts="radicale"
-radicale_homedir="/var/lib/radicale"
-radicale_descr="Radicale user"
+ /var/log/radicale/ 750 _radicale _radicale
+ /var/lib/radicale 750 _radicale _radicale"
+system_accounts="_radicale"
+_radicale_homedir="/var/lib/radicale"
+_radicale_descr="Radicale user"
 replaces="radicale2<3.0.6"
 
 do_check() {
@@ -38,7 +38,6 @@ do_check() {
 post_install() {
 	vinstall config 644 etc/radicale/
 	vinstall rights 640 etc/radicale/
-	vinstall config 644 usr/share/examples/radicale
 	vinstall radicale.wsgi 644 usr/share/radicale
 	vsv radicale
 	vdoc README.md

Re: radicale: fix permissions post-install

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46357#issuecomment-1742183778

Comment:
the account name is fine as-is, it was grandfathered in https://github.com/leahneukirchen/xtools/blob/master/xlint#L343 

Re: radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/46357#issuecomment-1742184033

Comment:
ah i see
then let me revert the user name

Re: [PR PATCH] [Updated] radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages fix/radicale
https://github.com/void-linux/void-packages/pull/46357

radicale: fix permissions post-install
Picks up #39973

Also add `_` prefix to system user

A patch file from https://github.com/void-linux/void-packages/pull/46357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/radicale-46357.patch --]
[-- Type: text/x-diff, Size: 1789 bytes --]

From e4c7b8f4c87626c588f6e72309d3c02bde568d46 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Sun, 1 Oct 2023 21:47:46 +0200
Subject: [PATCH] radicale: fix permissions post-install

---
 srcpkgs/radicale/INSTALL  | 11 +++++++++++
 srcpkgs/radicale/template |  5 ++---
 2 files changed, 13 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/radicale/INSTALL

diff --git a/srcpkgs/radicale/INSTALL b/srcpkgs/radicale/INSTALL
new file mode 100644
index 0000000000000..2d1ec39577e2f
--- /dev/null
+++ b/srcpkgs/radicale/INSTALL
@@ -0,0 +1,11 @@
+# *-*-shell-*-*
+#
+case ${ACTION} in
+post)
+	# fix permissions and owners
+    chown radicale:radicale /etc/radicale/config
+    chown radicale:radicale /etc/radicale/rights
+    chmod 644 /etc/radicale/config
+    chmod 640 /etc/radicale/rights
+	;;
+esac
diff --git a/srcpkgs/radicale/template b/srcpkgs/radicale/template
index a6fabe065463c..ab7ef2d601967 100644
--- a/srcpkgs/radicale/template
+++ b/srcpkgs/radicale/template
@@ -1,7 +1,7 @@
 # Template file for 'radicale'
 pkgname=radicale
 version=3.1.8
-revision=3
+revision=4
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-vobject python3-dateutil python3-passlib python3-bcrypt
@@ -22,7 +22,7 @@ conf_files="
 make_dirs="
  /etc/radicale 755 root root
  /usr/share/radicale/ 755 root root
- /var/log/radicale/ 700 root root
+ /var/log/radicale/ 750 radicale radicale
  /var/lib/radicale 750 radicale radicale"
 system_accounts="radicale"
 radicale_homedir="/var/lib/radicale"
@@ -38,7 +38,6 @@ do_check() {
 post_install() {
 	vinstall config 644 etc/radicale/
 	vinstall rights 640 etc/radicale/
-	vinstall config 644 usr/share/examples/radicale
 	vinstall radicale.wsgi 644 usr/share/radicale
 	vsv radicale
 	vdoc README.md

Re: [PR REVIEW] radicale: fix permissions post-install

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46357#discussion_r1342181785

Comment:
use tabs

Re: [PR REVIEW] radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by fanyx on void-packages repository

https://github.com/void-linux/void-packages/pull/46357#discussion_r1342181920

Comment:
oh right, autoexpand
my bad

Re: [PR PATCH] [Updated] radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages fix/radicale
https://github.com/void-linux/void-packages/pull/46357

radicale: fix permissions post-install
Picks up #39973

Hopefully fixes #38923

A patch file from https://github.com/void-linux/void-packages/pull/46357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/radicale-46357.patch --]
[-- Type: text/x-diff, Size: 1777 bytes --]

From 64b3a77b0005ef85c319b78799ef3320cdeb1f5c Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Sun, 1 Oct 2023 21:47:46 +0200
Subject: [PATCH] radicale: fix permissions post-install

---
 srcpkgs/radicale/INSTALL  | 11 +++++++++++
 srcpkgs/radicale/template |  5 ++---
 2 files changed, 13 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/radicale/INSTALL

diff --git a/srcpkgs/radicale/INSTALL b/srcpkgs/radicale/INSTALL
new file mode 100644
index 0000000000000..a0551ab304a36
--- /dev/null
+++ b/srcpkgs/radicale/INSTALL
@@ -0,0 +1,11 @@
+# *-*-shell-*-*
+#
+case ${ACTION} in
+post)
+	# fix permissions and owners
+	chown radicale:radicale /etc/radicale/config
+	chown radicale:radicale /etc/radicale/rights
+	chmod 644 /etc/radicale/config
+	chmod 640 /etc/radicale/rights
+	;;
+esac
diff --git a/srcpkgs/radicale/template b/srcpkgs/radicale/template
index a6fabe065463c..ab7ef2d601967 100644
--- a/srcpkgs/radicale/template
+++ b/srcpkgs/radicale/template
@@ -1,7 +1,7 @@
 # Template file for 'radicale'
 pkgname=radicale
 version=3.1.8
-revision=3
+revision=4
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-vobject python3-dateutil python3-passlib python3-bcrypt
@@ -22,7 +22,7 @@ conf_files="
 make_dirs="
  /etc/radicale 755 root root
  /usr/share/radicale/ 755 root root
- /var/log/radicale/ 700 root root
+ /var/log/radicale/ 750 radicale radicale
  /var/lib/radicale 750 radicale radicale"
 system_accounts="radicale"
 radicale_homedir="/var/lib/radicale"
@@ -38,7 +38,6 @@ do_check() {
 post_install() {
 	vinstall config 644 etc/radicale/
 	vinstall rights 640 etc/radicale/
-	vinstall config 644 usr/share/examples/radicale
 	vinstall radicale.wsgi 644 usr/share/radicale
 	vsv radicale
 	vdoc README.md

Re: [PR PATCH] [Updated] radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages fix/radicale
https://github.com/void-linux/void-packages/pull/46357

radicale: fix permissions post-install
Picks up #39973

Hopefully fixes #38923

A patch file from https://github.com/void-linux/void-packages/pull/46357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/radicale-46357.patch --]
[-- Type: text/x-diff, Size: 1531 bytes --]

From a407a3c130b4fea271800e6993a743424a7fa50a Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 12 Dec 2023 12:54:18 +0100
Subject: [PATCH] radicale: fix permissions post-install

---
 srcpkgs/radicale/INSTALL  | 11 +++++++++++
 srcpkgs/radicale/template |  3 +--
 2 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/radicale/INSTALL

diff --git a/srcpkgs/radicale/INSTALL b/srcpkgs/radicale/INSTALL
new file mode 100644
index 0000000000000..a0551ab304a36
--- /dev/null
+++ b/srcpkgs/radicale/INSTALL
@@ -0,0 +1,11 @@
+# *-*-shell-*-*
+#
+case ${ACTION} in
+post)
+	# fix permissions and owners
+	chown radicale:radicale /etc/radicale/config
+	chown radicale:radicale /etc/radicale/rights
+	chmod 644 /etc/radicale/config
+	chmod 640 /etc/radicale/rights
+	;;
+esac
diff --git a/srcpkgs/radicale/template b/srcpkgs/radicale/template
index cfab227cfa194..8a7a341d79c7b 100644
--- a/srcpkgs/radicale/template
+++ b/srcpkgs/radicale/template
@@ -22,7 +22,7 @@ conf_files="
 make_dirs="
  /etc/radicale 755 root root
  /usr/share/radicale/ 755 root root
- /var/log/radicale/ 700 root root
+ /var/log/radicale/ 750 radicale radicale
  /var/lib/radicale 750 radicale radicale"
 system_accounts="radicale"
 radicale_homedir="/var/lib/radicale"
@@ -38,7 +38,6 @@ do_check() {
 post_install() {
 	vinstall config 644 etc/radicale/
 	vinstall rights 640 etc/radicale/
-	vinstall config 644 usr/share/examples/radicale
 	vinstall radicale.wsgi 644 usr/share/radicale
 	vsv radicale
 	vdoc README.md

Re: [PR PATCH] [Updated] radicale: fix permissions post-install

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

There is an updated pull request by fanyx against master on the void-packages repository

https://github.com/fanyx/void-packages fix/radicale
https://github.com/void-linux/void-packages/pull/46357

radicale: fix permissions post-install
Picks up #39973

Hopefully fixes #38923

A patch file from https://github.com/void-linux/void-packages/pull/46357.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/radicale-46357.patch --]
[-- Type: text/x-diff, Size: 2860 bytes --]

From a407a3c130b4fea271800e6993a743424a7fa50a Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 12 Dec 2023 12:54:18 +0100
Subject: [PATCH 1/2] radicale: fix permissions post-install

---
 srcpkgs/radicale/INSTALL  | 11 +++++++++++
 srcpkgs/radicale/template |  3 +--
 2 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/radicale/INSTALL

diff --git a/srcpkgs/radicale/INSTALL b/srcpkgs/radicale/INSTALL
new file mode 100644
index 0000000000000..a0551ab304a36
--- /dev/null
+++ b/srcpkgs/radicale/INSTALL
@@ -0,0 +1,11 @@
+# *-*-shell-*-*
+#
+case ${ACTION} in
+post)
+	# fix permissions and owners
+	chown radicale:radicale /etc/radicale/config
+	chown radicale:radicale /etc/radicale/rights
+	chmod 644 /etc/radicale/config
+	chmod 640 /etc/radicale/rights
+	;;
+esac
diff --git a/srcpkgs/radicale/template b/srcpkgs/radicale/template
index cfab227cfa194..8a7a341d79c7b 100644
--- a/srcpkgs/radicale/template
+++ b/srcpkgs/radicale/template
@@ -22,7 +22,7 @@ conf_files="
 make_dirs="
  /etc/radicale 755 root root
  /usr/share/radicale/ 755 root root
- /var/log/radicale/ 700 root root
+ /var/log/radicale/ 750 radicale radicale
  /var/lib/radicale 750 radicale radicale"
 system_accounts="radicale"
 radicale_homedir="/var/lib/radicale"
@@ -38,7 +38,6 @@ do_check() {
 post_install() {
 	vinstall config 644 etc/radicale/
 	vinstall rights 640 etc/radicale/
-	vinstall config 644 usr/share/examples/radicale
 	vinstall radicale.wsgi 644 usr/share/radicale
 	vsv radicale
 	vdoc README.md

From 16e591aaf6da1d261936d98a8984f896751b2994 Mon Sep 17 00:00:00 2001
From: fanyx <fanyx@posteo.net>
Date: Tue, 12 Dec 2023 13:00:43 +0100
Subject: [PATCH 2/2] radicale: remove deprecated pytests

---
 srcpkgs/radicale/template | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/srcpkgs/radicale/template b/srcpkgs/radicale/template
index 8a7a341d79c7b..50537fc7ad71f 100644
--- a/srcpkgs/radicale/template
+++ b/srcpkgs/radicale/template
@@ -6,8 +6,6 @@ build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-vobject python3-dateutil python3-passlib python3-bcrypt
  python3-defusedxml apache-htpasswd"
-checkdepends="${depends} python3-pytest python3-pytest-flake8 python3-isort
- python3-pytest-cov python3-waitress"
 short_desc="Complete calendar and contact storing and manipulating solution"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
@@ -29,12 +27,6 @@ radicale_homedir="/var/lib/radicale"
 radicale_descr="Radicale user"
 replaces="radicale2<3.0.6"
 
-do_check() {
-	# install the package to test_install directory for testing
-	python3 setup.py install --root="${PWD}/test_install"
-	PYTHONPATH="${PWD}/test_install/${py3_sitelib}" pytest -c /dev/null
-}
-
 post_install() {
 	vinstall config 644 etc/radicale/
 	vinstall rights 640 etc/radicale/

Re: radicale: fix permissions post-install, remove deprecated pytests

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46357#issuecomment-1989764297

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: radicale: fix permissions post-install, remove deprecated pytests

[fanyx]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

There's a closed pull request on the void-packages repository

radicale: fix permissions post-install, remove deprecated pytests
https://github.com/void-linux/void-packages/pull/46357

Description:
Picks up #39973

Hopefully fixes #38923