[PR PATCH] ardour: fix build with Python 3.12.

[PR PATCH] ardour: fix build with Python 3.12.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages ardour-fix-build-with-python-3.12
https://github.com/void-linux/void-packages/pull/46645

ardour: fix build with Python 3.12.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46645.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ardour-fix-build-with-python-3.12-46645.patch --]
[-- Type: text/x-diff, Size: 1543 bytes --]

From e6090f49db9993d7b838c9798d07428b2418eb02 Mon Sep 17 00:00:00 2001
From: Mohammed Anas <triallax@tutanota.com>
Date: Thu, 12 Oct 2023 21:45:34 +0100
Subject: [PATCH] ardour: fix build with Python 3.12.

---
 .../patches/fix-build-with-python-3.12.diff     | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/ardour/patches/fix-build-with-python-3.12.diff

diff --git a/srcpkgs/ardour/patches/fix-build-with-python-3.12.diff b/srcpkgs/ardour/patches/fix-build-with-python-3.12.diff
new file mode 100644
index 0000000000000..210083cb4abb0
--- /dev/null
+++ b/srcpkgs/ardour/patches/fix-build-with-python-3.12.diff
@@ -0,0 +1,17 @@
+At the moment, running `itstool` with Python 3.12 spews out a bunch of
+`SyntaxWarning`s, polluting the command's stderr (which the code in `ardour`'s
+`wscript` captures) and causing a configure failure.
+
+diff --git a/wscript b/wscript
+index 39761da5f..b72e2ab75 100644
+--- a/wscript
++++ b/wscript
+@@ -973,7 +973,7 @@ def configure(conf):
+ 
+     # freedesktop translations needs itstool > 1.0.3 (-j option)
+     if Options.options.freedesktop:
+-        output = subprocess.Popen("itstool --version", shell=True, stderr=subprocess.STDOUT, stdout=subprocess.PIPE).communicate()[0].splitlines()
++        output = subprocess.Popen("itstool --version", shell=True, stderr=subprocess.DEVNULL, stdout=subprocess.PIPE).communicate()[0].splitlines()
+         o = output[0].decode('utf-8')
+         itstool = o.split(' ')[0]
+         version = o.split(' ')[1].split('.')

Re: ardour: fix build with Python 3.12.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/46645#issuecomment-1761994896

Comment:
@mhmdanas after 7754f225fc2dee5f2fb397e79570232909d63c9e this should not be necessary

Re: [PR PATCH] [Closed]: ardour: fix build with Python 3.12.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

There's a closed pull request on the void-packages repository

ardour: fix build with Python 3.12.
https://github.com/void-linux/void-packages/pull/46645

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->