[PR PATCH] New package: grandorgue-3.13.0

[PR PATCH] New package: grandorgue-3.13.0

[nicolodavis]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

There is a new pull request by nicolodavis against master on the void-packages repository

https://github.com/nicolodavis/void-packages grandorgue
https://github.com/void-linux/void-packages/pull/46711

New package: grandorgue-3.13.0
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)


A patch file from https://github.com/void-linux/void-packages/pull/46711.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grandorgue-46711.patch --]
[-- Type: text/x-diff, Size: 1334 bytes --]

From ddcb42bbb19c0bf2431a6de0c409b77ddb1aeeb3 Mon Sep 17 00:00:00 2001
From: Nicolo John Davis <nicolodavis@gmail.com>
Date: Sun, 15 Oct 2023 21:42:00 -0600
Subject: [PATCH] New package: grandorgue-3.13.0

---
 srcpkgs/grandorgue/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/grandorgue/template

diff --git a/srcpkgs/grandorgue/template b/srcpkgs/grandorgue/template
new file mode 100644
index 0000000000000..2fbb405a7d9b1
--- /dev/null
+++ b/srcpkgs/grandorgue/template
@@ -0,0 +1,21 @@
+# Template file for 'grandorgue'
+pkgname=grandorgue
+version=3.13.0
+revision=1
+archs="x86_64 aarch64"
+build_style="cmake"
+configure_args="-DCMAKE_BUILD_TYPE=Release -G Ninja"
+hostmakedepends="pkg-config git ImageMagick"
+makedepends="jack-devel eudev-libudev-devel zlib-devel yaml-cpp-devel wxWidgets-devel wxWidgets-common-devel wxWidgets-gtk3-devel fftw-devel wavpack-devel alsa-lib-devel"
+depends="gettext po4a zip"
+short_desc="Pipe Organ Simulator"
+maintainer="Nicolo Davis <nicolodavis@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/GrandOrgue/grandorgue"
+
+export WX_CONFIG=wx-config-gtk3
+
+do_fetch() {
+	git clone --recurse-submodules --depth 1 --branch ${version}-${revision} https://github.com/GrandOrgue/grandorgue.git ${wrksrc}
+	cd ${wrksrc}
+}

Re: [PR PATCH] [Updated] New package: grandorgue-3.13.0

[nicolodavis]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

There is an updated pull request by nicolodavis against master on the void-packages repository

https://github.com/nicolodavis/void-packages grandorgue
https://github.com/void-linux/void-packages/pull/46711

New package: grandorgue-3.13.0
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)


A patch file from https://github.com/void-linux/void-packages/pull/46711.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grandorgue-46711.patch --]
[-- Type: text/x-diff, Size: 1334 bytes --]

From 782d721cdbb0e344e3a481bc63bf5431663e42b0 Mon Sep 17 00:00:00 2001
From: Nicolo John Davis <nicolodavis@gmail.com>
Date: Sun, 15 Oct 2023 21:42:00 -0600
Subject: [PATCH] New package: grandorgue-3.13.0

---
 srcpkgs/grandorgue/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/grandorgue/template

diff --git a/srcpkgs/grandorgue/template b/srcpkgs/grandorgue/template
new file mode 100644
index 0000000000000..2fbb405a7d9b1
--- /dev/null
+++ b/srcpkgs/grandorgue/template
@@ -0,0 +1,21 @@
+# Template file for 'grandorgue'
+pkgname=grandorgue
+version=3.13.0
+revision=1
+archs="x86_64 aarch64"
+build_style="cmake"
+configure_args="-DCMAKE_BUILD_TYPE=Release -G Ninja"
+hostmakedepends="pkg-config git ImageMagick"
+makedepends="jack-devel eudev-libudev-devel zlib-devel yaml-cpp-devel wxWidgets-devel wxWidgets-common-devel wxWidgets-gtk3-devel fftw-devel wavpack-devel alsa-lib-devel"
+depends="gettext po4a zip"
+short_desc="Pipe Organ Simulator"
+maintainer="Nicolo Davis <nicolodavis@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/GrandOrgue/grandorgue"
+
+export WX_CONFIG=wx-config-gtk3
+
+do_fetch() {
+	git clone --recurse-submodules --depth 1 --branch ${version}-${revision} https://github.com/GrandOrgue/grandorgue.git ${wrksrc}
+	cd ${wrksrc}
+}

Re: [PR PATCH] [Updated] New package: grandorgue-3.13.0

[nicolodavis]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

There is an updated pull request by nicolodavis against master on the void-packages repository

https://github.com/nicolodavis/void-packages grandorgue
https://github.com/void-linux/void-packages/pull/46711

New package: grandorgue-3.13.0
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)


A patch file from https://github.com/void-linux/void-packages/pull/46711.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grandorgue-46711.patch --]
[-- Type: text/x-diff, Size: 1326 bytes --]

From b3e0f47efbd29518e8cbe5b7b72413d3064146cc Mon Sep 17 00:00:00 2001
From: Nicolo John Davis <nicolodavis@gmail.com>
Date: Sun, 15 Oct 2023 21:42:00 -0600
Subject: [PATCH] New package: grandorgue-3.13.0

---
 srcpkgs/grandorgue/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/grandorgue/template

diff --git a/srcpkgs/grandorgue/template b/srcpkgs/grandorgue/template
new file mode 100644
index 0000000000000..fbf396dca5e31
--- /dev/null
+++ b/srcpkgs/grandorgue/template
@@ -0,0 +1,21 @@
+# Template file for 'grandorgue'
+pkgname=grandorgue
+version=3.13.0
+revision=1
+archs="x86_64"
+build_style="cmake"
+configure_args="-DCMAKE_BUILD_TYPE=Release -G Ninja"
+hostmakedepends="pkg-config git ImageMagick"
+makedepends="jack-devel eudev-libudev-devel zlib-devel yaml-cpp-devel wxWidgets-devel wxWidgets-common-devel wxWidgets-gtk3-devel fftw-devel wavpack-devel alsa-lib-devel"
+depends="gettext po4a zip"
+short_desc="Pipe Organ Simulator"
+maintainer="Nicolo Davis <nicolodavis@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/GrandOrgue/grandorgue"
+
+export WX_CONFIG=wx-config-gtk3
+
+do_fetch() {
+	git clone --recurse-submodules --depth 1 --branch ${version}-${revision} https://github.com/GrandOrgue/grandorgue.git ${wrksrc}
+	cd ${wrksrc}
+}

Re: New package: grandorgue-3.13.0

[nicolodavis]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by nicolodavis on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#issuecomment-1769265088

Comment:
Just curious if I need to do anything at my end to get the CI to green tick this PR?

Re: New package: grandorgue-3.13.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#issuecomment-1894801966

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: grandorgue-3.13.0

[nicolodavis]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by nicolodavis on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#issuecomment-1894930621

Comment:
Hi @classabbyamp, is Void still accepting new package contributions? Let me know if I should close this PR instead.

Re: New package: grandorgue-3.13.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#issuecomment-1894940974

Comment:
we do accept new package contributions, but generally it requires a maintainer to be either interested in the package or see the utility of merging it

we also generally like to see new contributors make some contributions (updates, fixes, etc) to existing packages (especially orphaned packages) before adding new packages.

Re: [PR REVIEW] New package: grandorgue-3.13.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#discussion_r1454586647

Comment:
neither of these need to be set. void sets the build type to None and the generator to ninja by default in `common/build-style/cmake.sh`

Re: [PR REVIEW] New package: grandorgue-3.13.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#discussion_r1454588315

Comment:
this can probably be replaced with `build_helper="cmake-wxWidgets-gtk3"`

Re: [PR REVIEW] New package: grandorgue-3.13.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#discussion_r1454587411

Comment:
do not use `git clone` to fetch. if a packages has submodules, they should be added as distfiles. see the `edk2-ovmf` template for an example.

Re: New package: grandorgue-3.13.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46711#issuecomment-2062843690

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: grandorgue-3.13.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

There's a closed pull request on the void-packages repository

New package: grandorgue-3.13.0
https://github.com/void-linux/void-packages/pull/46711

Description:
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): YES

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64 glibc)