[PR PATCH] New package: uxn-1.0

[PR PATCH] New package: uxn-1.0

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

There is a new pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages uxn
https://github.com/void-linux/void-packages/pull/46766

New package: uxn-1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/46766.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-uxn-46766.patch --]
[-- Type: text/x-diff, Size: 1043 bytes --]

From 9b4cfee33563dfb5f33369367aa0cdf172447822 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@duck.com>
Date: Wed, 18 Oct 2023 23:38:25 +0200
Subject: [PATCH] New package: uxn-1.0

---
 srcpkgs/uxn/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/uxn/template

diff --git a/srcpkgs/uxn/template b/srcpkgs/uxn/template
new file mode 100644
index 0000000000000..257678aac3b59
--- /dev/null
+++ b/srcpkgs/uxn/template
@@ -0,0 +1,25 @@
+# Template file for 'uxn'
+pkgname=uxn
+version=1.0
+revision=1
+makedepends="SDL2-devel"
+short_desc="Assembler and emulator for the Uxn stack-machine"
+maintainer="Eloi Torrents <eloitor@duck.com>"
+license="MIT"
+homepage="https://100r.co/site/uxn.html"
+distfiles="https://git.sr.ht/~rabbits/uxn/archive/${version}.tar.gz"
+checksum=29059ee288474e48fae4b9e755bbc8e1b392a9c7ac90449d7a6599385c145460
+
+do_build() {
+	./build.sh
+}
+
+do_install() {
+	vbin bin/uxnasm
+	vbin bin/uxncli
+	vbin bin/uxnemu
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: uxn-1.0

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages uxn
https://github.com/void-linux/void-packages/pull/46766

New package: uxn-1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/46766.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-uxn-46766.patch --]
[-- Type: text/x-diff, Size: 1086 bytes --]

From 9dea3584621cab6469b867e74e7f16d327e5b984 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@duck.com>
Date: Wed, 18 Oct 2023 23:38:25 +0200
Subject: [PATCH] New package: uxn-1.0

---
 srcpkgs/uxn/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/uxn/template

diff --git a/srcpkgs/uxn/template b/srcpkgs/uxn/template
new file mode 100644
index 0000000000000..5613bf2b4be3f
--- /dev/null
+++ b/srcpkgs/uxn/template
@@ -0,0 +1,25 @@
+# Template file for 'uxn'
+pkgname=uxn
+version=1.0
+revision=1
+makedepends="SDL2-devel"
+short_desc="Assembler and emulator for the Uxn stack-machine"
+maintainer="Eloi Torrents <eloitor@duck.com>"
+license="MIT"
+homepage="https://100r.co/site/uxn.html"
+distfiles="https://git.sr.ht/~rabbits/uxn/archive/${version}.tar.gz"
+checksum=29059ee288474e48fae4b9e755bbc8e1b392a9c7ac90449d7a6599385c145460
+
+do_build() {
+	CC="$BUILD_CC" CFLAGS="$XBPS_CROSS_CFLAGS" ./build.sh
+}
+
+do_install() {
+	vbin bin/uxnasm
+	vbin bin/uxncli
+	vbin bin/uxnemu
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: uxn-1.0

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

New comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/pull/46766#issuecomment-1770399822

Comment:
I don't know how to fix cross compilation...

for aarch64 I get:
```
cc1: error: bad value 'armv8-a' for '-march=' switch
cc1: note: valid arguments to '-march=' switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids alderlake bonnell atom silvermont slm goldmont goldmont-plus tremont knl knm x86-64 x86-64-v2 x86-64-v3 x86-64-v4 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 btver1 btver2 native
```

Re: [PR REVIEW] New package: uxn-1.0

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/46766#discussion_r1365795300

Comment:
You don't want to mess with CC/CFLAGS, they are already set correctly for cross compiling.
You want to add `--no-run`, so it does not attempt to run the just compiled binaries.

The other problem is, the `build.sh` adds `-g0` to `CFLAGS`, which we don't want. The binaries will get stripped by `void-packages`

Re: [PR REVIEW] New package: uxn-1.0

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/46766#discussion_r1365795732

Comment:
put it into `do_install`.

Re: [PR REVIEW] New package: uxn-1.0

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/pull/46766#discussion_r1366187941

Comment:
Thank you. Is it a good idea to just put the 3 lines needed for compilation in `do_build` and ignore the `build.sh` file?

Re: [PR PATCH] [Updated] New package: uxn-1.0

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages uxn
https://github.com/void-linux/void-packages/pull/46766

New package: uxn-1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/46766.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-uxn-46766.patch --]
[-- Type: text/x-diff, Size: 1578 bytes --]

From 9a58b95fa58d9b9ac7cef7ed6ac4e87b6dfadc3d Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@duck.com>
Date: Wed, 18 Oct 2023 23:38:25 +0200
Subject: [PATCH] New package: uxn-1.0

---
 srcpkgs/uxn/template | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 srcpkgs/uxn/template

diff --git a/srcpkgs/uxn/template b/srcpkgs/uxn/template
new file mode 100644
index 0000000000000..583ed05ac20b0
--- /dev/null
+++ b/srcpkgs/uxn/template
@@ -0,0 +1,28 @@
+# Template file for 'uxn'
+pkgname=uxn
+version=1.0
+revision=1
+hostmakedepends="SDL2-devel"
+makedepends="SDL2-devel"
+short_desc="Assembler and emulator for the Uxn stack-machine"
+maintainer="Eloi Torrents <eloitor@duck.com>"
+license="MIT"
+homepage="https://100r.co/site/uxn.html"
+distfiles="https://git.sr.ht/~rabbits/uxn/archive/${version}.tar.gz"
+checksum=29059ee288474e48fae4b9e755bbc8e1b392a9c7ac90449d7a6599385c145460
+
+do_build() {
+	mkdir -p bin
+	export UXNEMU_LDFLAGS="-L/usr/local/lib $(sdl2-config --cflags --libs)"
+	${CC} ${CFLAGS} src/uxnasm.c -o bin/uxnasm
+	${CC} ${CFLAGS} src/uxn.c src/devices/system.c src/devices/console.c src/devices/file.c src/devices/datetime.c src/devices/mouse.c src/devices/controller.c src/devices/screen.c src/devices/audio.c src/uxnemu.c ${UXNEMU_LDFLAGS} -o bin/uxnemu
+	${CC} ${CFLAGS} src/uxn.c src/devices/system.c src/devices/console.c src/devices/file.c src/devices/datetime.c src/uxncli.c ${UXNEMU_LDFLAGS} -o bin/uxncli
+}
+
+do_install() {
+	vbin bin/uxnasm
+	vbin bin/uxncli
+	vbin bin/uxnemu
+	vlicense LICENSE
+}
+

Re: [PR PATCH] [Updated] New package: uxn-1.0

[Eloitor]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages uxn
https://github.com/void-linux/void-packages/pull/46766

New package: uxn-1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/46766.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-uxn-46766.patch --]
[-- Type: text/x-diff, Size: 1575 bytes --]

From 3f0dacbaad65673018d0a357e928a5df5d769f3a Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@duck.com>
Date: Wed, 18 Oct 2023 23:38:25 +0200
Subject: [PATCH] New package: uxn-1.0

---
 srcpkgs/uxn/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/uxn/template

diff --git a/srcpkgs/uxn/template b/srcpkgs/uxn/template
new file mode 100644
index 0000000000000..797654c9aa33e
--- /dev/null
+++ b/srcpkgs/uxn/template
@@ -0,0 +1,27 @@
+# Template file for 'uxn'
+pkgname=uxn
+version=1.0
+revision=1
+hostmakedepends="SDL2-devel"
+makedepends="SDL2-devel"
+short_desc="Assembler and emulator for the Uxn stack-machine"
+maintainer="Eloi Torrents <eloitor@duck.com>"
+license="MIT"
+homepage="https://100r.co/site/uxn.html"
+distfiles="https://git.sr.ht/~rabbits/uxn/archive/${version}.tar.gz"
+checksum=29059ee288474e48fae4b9e755bbc8e1b392a9c7ac90449d7a6599385c145460
+
+do_build() {
+	mkdir -p bin
+	export UXNEMU_LDFLAGS="-L/usr/local/lib $(sdl2-config --cflags --libs)"
+	${CC} ${CFLAGS} src/uxnasm.c -o bin/uxnasm
+	${CC} ${CFLAGS} src/uxn.c src/devices/system.c src/devices/console.c src/devices/file.c src/devices/datetime.c src/devices/mouse.c src/devices/controller.c src/devices/screen.c src/devices/audio.c src/uxnemu.c ${UXNEMU_LDFLAGS} -o bin/uxnemu
+	${CC} ${CFLAGS} src/uxn.c src/devices/system.c src/devices/console.c src/devices/file.c src/devices/datetime.c src/uxncli.c ${UXNEMU_LDFLAGS} -o bin/uxncli
+}
+
+do_install() {
+	vbin bin/uxnasm
+	vbin bin/uxncli
+	vbin bin/uxnemu
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: uxn-1.0

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/46766#discussion_r1367782971

Comment:
Imo just patching it is better.
Vendoring parts of the script will add an additional burden of keeping it up to date.

Re: New package: uxn-1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/46766#issuecomment-1901579591

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: uxn-1.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

There's a closed pull request on the void-packages repository

New package: uxn-1.0
https://github.com/void-linux/void-packages/pull/46766

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)