Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] android-udev-rules: depend on libmtp, as suggested by upstream
@ 2023-11-20 21:18 dkwo
  2023-11-23 18:00 ` biopsin
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: dkwo @ 2023-11-20 21:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages aurmtp
https://github.com/void-linux/void-packages/pull/47327

android-udev-rules: depend on libmtp, as suggested by upstream
- I tested the changes in this PR: yes

This was suggested by upstream in discussion https://github.com/M0Rf30/android-udev-rules/issues/295

A patch file from https://github.com/void-linux/void-packages/pull/47327.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aurmtp-47327.patch --]
[-- Type: text/x-diff, Size: 853 bytes --]

From ee03ca3b4a65bcb73b039ae1990134e0be97c840 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Mon, 20 Nov 2023 16:16:44 -0500
Subject: [PATCH] android-udev-rules: depend on libmtp, as suggested by
 upstream

---
 srcpkgs/android-udev-rules/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/android-udev-rules/template b/srcpkgs/android-udev-rules/template
index 1309dd724b9a2..8775c27dda796 100644
--- a/srcpkgs/android-udev-rules/template
+++ b/srcpkgs/android-udev-rules/template
@@ -1,7 +1,8 @@
 # Template file for 'android-udev-rules'
 pkgname=android-udev-rules
 version=20231104
-revision=1
+revision=2
+depends="libmtp"
 short_desc="Android udev rules list aimed to be the most comprehensive on the net"
 maintainer="Mohammed Anas <triallax@tutanota.com>"
 license="GPL-3.0-or-later"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: android-udev-rules: depend on libmtp, as suggested by upstream
  2023-11-20 21:18 [PR PATCH] android-udev-rules: depend on libmtp, as suggested by upstream dkwo
@ 2023-11-23 18:00 ` biopsin
  2023-11-24 21:54 ` dkwo
  2023-11-24 21:54 ` [PR PATCH] [Closed]: " dkwo
  2 siblings, 0 replies; 4+ messages in thread
From: biopsin @ 2023-11-23 18:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/47327#issuecomment-1824784943

Comment:
From your upstream issue it seems to me that the libmtp dependency should be included in the android-file-transfer-linux package rather than in a udev rule set, since one should be able to connect using ftlpkg without having to install the android-udev-rules pkg right?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: android-udev-rules: depend on libmtp, as suggested by upstream
  2023-11-20 21:18 [PR PATCH] android-udev-rules: depend on libmtp, as suggested by upstream dkwo
  2023-11-23 18:00 ` biopsin
@ 2023-11-24 21:54 ` dkwo
  2023-11-24 21:54 ` [PR PATCH] [Closed]: " dkwo
  2 siblings, 0 replies; 4+ messages in thread
From: dkwo @ 2023-11-24 21:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/47327#issuecomment-1826104186

Comment:
Weirdly enough, the `aft` packages already contains a similar lib
```
=> android-file-transfer-linux-4.2_4: running post-install hook: 98-shlib-provides ...
   SONAME libmtp-ng.so.4.2.0 from /usr/lib/libmtp-ng.so.4.2.0
```
but that does not seem to do the job. I'll just add libmtp to its depends.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: android-udev-rules: depend on libmtp, as suggested by upstream
  2023-11-20 21:18 [PR PATCH] android-udev-rules: depend on libmtp, as suggested by upstream dkwo
  2023-11-23 18:00 ` biopsin
  2023-11-24 21:54 ` dkwo
@ 2023-11-24 21:54 ` dkwo
  2 siblings, 0 replies; 4+ messages in thread
From: dkwo @ 2023-11-24 21:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

There's a closed pull request on the void-packages repository

android-udev-rules: depend on libmtp, as suggested by upstream
https://github.com/void-linux/void-packages/pull/47327

Description:
- I tested the changes in this PR: yes

This was suggested by upstream in discussion https://github.com/M0Rf30/android-udev-rules/issues/295

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-24 21:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-20 21:18 [PR PATCH] android-udev-rules: depend on libmtp, as suggested by upstream dkwo
2023-11-23 18:00 ` biopsin
2023-11-24 21:54 ` dkwo
2023-11-24 21:54 ` [PR PATCH] [Closed]: " dkwo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).