Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: msitools-0.103
@ 2023-11-22 22:27 elbeardmorez
  2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: elbeardmorez @ 2023-11-22 22:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

There is a new pull request by elbeardmorez against master on the void-packages repository

https://github.com/elbeardmorez/void-packages xbps_msitools
https://github.com/void-linux/void-packages/pull/47355

New package: msitools-0.103
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/47355.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps_msitools-47355.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From 003f978a3694eb5763081d04417cc0ac61d29893 Mon Sep 17 00:00:00 2001
From: Pete Beardmore <peteb@appcheck-ng.com>
Date: Wed, 22 Nov 2023 18:51:03 +0000
Subject: [PATCH] New package: msitools-0.103

---
 srcpkgs/msitools/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 0000000000000..1d8d094aa609e
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,13 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.103
+revision=1
+build_style=meson
+hostmakedepends="vala perl bison pkg-config cmake"
+makedepends="glib-devel libgsf-devel gcab-devel gobject-introspection"
+short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
+maintainer="Pete Beardmore <elbeardmorez@msn.com>"
+license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
@ 2023-11-30  8:40 ` elbeardmorez
  2023-11-30  8:43 ` elbeardmorez
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: elbeardmorez @ 2023-11-30  8:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

There is an updated pull request by elbeardmorez against master on the void-packages repository

https://github.com/elbeardmorez/void-packages xbps_msitools
https://github.com/void-linux/void-packages/pull/47355

New package: msitools-0.103
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/47355.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps_msitools-47355.patch --]
[-- Type: text/x-diff, Size: 1247 bytes --]

From a4e91e27ec88fa3f3577043a961a47671a7a577f Mon Sep 17 00:00:00 2001
From: Pete Beardmore <peteb@appcheck-ng.com>
Date: Wed, 22 Nov 2023 18:51:03 +0000
Subject: [PATCH] New package: msitools-0.103

---
 srcpkgs/msitools/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/msitools/template

diff --git a/srcpkgs/msitools/template b/srcpkgs/msitools/template
new file mode 100644
index 0000000000000..7ea2f5b317992
--- /dev/null
+++ b/srcpkgs/msitools/template
@@ -0,0 +1,16 @@
+# Template file for 'msitools'
+pkgname=msitools
+version=0.103
+revision=1
+build_style=meson
+build_helper="gir"
+hostmakedepends="glib-devel gobject-introspection vala perl bison pkg-config cmake"
+makedepends="glib-devel gobject-introspection libgsf-devel gcab-devel"
+short_desc="Programs for inspecting and building Windows Installer (.MSI) files"
+maintainer="Pete Beardmore <elbeardmorez@msn.com>"
+license="LGPL-2.1-or-later, GPL-3.0-or-later, MS-RL"
+homepage="https://wiki.gnome.org/msitools"
+distfiles="https://download.gnome.org/sources/msitools/${version}/msitools-${version}.tar.xz"
+checksum="d17622eebbf37fa4c09b59be0bc8db08b26be300a6731c74da1ebce262bce839"
+build_options="gir"
+build_options_default="gir"

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
  2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
@ 2023-11-30  8:43 ` elbeardmorez
  2023-12-03 14:49 ` Bnyro
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: elbeardmorez @ 2023-11-30  8:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1833328181

Comment:
with a few tweaks to the template the aarch64 package is successfully built here locally

is there a requirement to get the package building for every single supported architecture?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
  2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
  2023-11-30  8:43 ` elbeardmorez
@ 2023-12-03 14:49 ` Bnyro
  2024-03-03  1:45 ` github-actions
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Bnyro @ 2023-12-03 14:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1837505892

Comment:
> with a few tweaks to the template the aarch64 package is successfully built here locally
> 
> is there a requirement to get the package building for every single supported architecture?
>
No, but all officially supported architectures by the project itself should likely be functional here too.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (2 preceding siblings ...)
  2023-12-03 14:49 ` Bnyro
@ 2024-03-03  1:45 ` github-actions
  2024-03-03 12:18 ` elbeardmorez
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2024-03-03  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1974973676

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (3 preceding siblings ...)
  2024-03-03  1:45 ` github-actions
@ 2024-03-03 12:18 ` elbeardmorez
  2024-03-27 14:47 ` afranchuk
  2024-03-27 14:48 ` afranchuk
  6 siblings, 0 replies; 8+ messages in thread
From: elbeardmorez @ 2024-03-03 12:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

New comment by elbeardmorez on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-1975141813

Comment:
There is no official list of what it should compile on and trying to compile such a list of potential architectures just in case someone needs it one day doesn't appeal as an exercise. If, assuming this goes in, someone then comes and suggests a tweak to make it also compile on XYZ then cool, I'll push the change.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (4 preceding siblings ...)
  2024-03-03 12:18 ` elbeardmorez
@ 2024-03-27 14:47 ` afranchuk
  2024-03-27 14:48 ` afranchuk
  6 siblings, 0 replies; 8+ messages in thread
From: afranchuk @ 2024-03-27 14:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2022961947

Comment:
I made #49528 as an update to #43321 (which was never merged) and didn't realize this existed. Comparing against your additions, I see that you have `build_options="gir"` and don't have `python3-setuptools`. I found that I needed `python3-setuptools` otherwise `distutils` (removed in python 3.12) was missing, and it's used by `gobject-introspection`. Obviously `gobject-introspection` should have this dependency itself, but I'm wondering whether the `build_options="gir"` somehow avoided this issue for you?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: New package: msitools-0.103
  2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
                   ` (5 preceding siblings ...)
  2024-03-27 14:47 ` afranchuk
@ 2024-03-27 14:48 ` afranchuk
  6 siblings, 0 replies; 8+ messages in thread
From: afranchuk @ 2024-03-27 14:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

New comment by afranchuk on void-packages repository

https://github.com/void-linux/void-packages/pull/47355#issuecomment-2022961947

Comment:
I made #49528 as an update to #43321 (which was never merged) and didn't realize this existed. Comparing against your additions, I see that you have `build_options="gir"` and don't have `python3-setuptools`.

I found that I needed `python3-setuptools` otherwise `distutils` (removed in python 3.12) was missing, and it's used by `gobject-introspection`. Obviously `gobject-introspection` should have this dependency itself (EDIT: it appears it does??), but I'm wondering whether the `build_options="gir"` somehow avoided this issue for you? Or maybe my (previously completely clean) build env somehow got busted?

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-03-27 14:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22 22:27 [PR PATCH] New package: msitools-0.103 elbeardmorez
2023-11-30  8:40 ` [PR PATCH] [Updated] " elbeardmorez
2023-11-30  8:43 ` elbeardmorez
2023-12-03 14:49 ` Bnyro
2024-03-03  1:45 ` github-actions
2024-03-03 12:18 ` elbeardmorez
2024-03-27 14:47 ` afranchuk
2024-03-27 14:48 ` afranchuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).