[ISSUE] `require("dns").setServers([])` causes Node.js to crash with an assertion error

[ISSUE] `require("dns").setServers([])` causes Node.js to crash with an assertion error

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

New issue by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/47411

Description:
### Is this a new report?

Yes

### System Info

Void 6.5.12_1 x86_64 GenuineIntel uptodate rFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

### Package(s) Affected

nodejs-18.16.0_3 (and also nodejs built from a locally bumped 18.18.2 template)

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

Couldn't find any.

### Expected behaviour

Node.js doesn't crash.

### Actual behaviour

```console
> require("dns").setServers([])
node[24747]: ../src/cares_wrap.cc:1691:void node::cares_wrap::{anonymous}::SetServers(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[0]->IsArray()' failed.
 1: 0x5647cd363300 node::Abort() [node]
 2: 0x5647cd363394  [node]
 3: 0x5647cd2c361c  [node]
 4: 0x5647cd59d6b6  [node]
 5: 0x5647cd59e1b7 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 6: 0x5647cde36539  [node]
fish: Job 1, 'node' terminated by signal SIGABRT (Abort)
```

This doesn't happen with Node.js installed from `n`:
```console
> require("dns").setServers([])
undefined
```

From my debugging `IsArray` seems to think that `[]` isn't an empty array for some reason(???); I tried skimming through the patches that Void applies, but I failed to find anything suspicious. I'll debug this more when I get the time, but if anybody can help I'd appreciate that too.

### Steps to reproduce

1. `node -e 'require("dns").setServers([])'`

Re: [ISSUE] [CLOSED] `require("dns").setServers([])` causes Node.js to crash with an assertion error

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

Closed issue by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/47411

Description:
### Is this a new report?

Yes

### System Info

Void 6.5.12_1 x86_64 GenuineIntel uptodate rFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF

### Package(s) Affected

nodejs-18.16.0_3 (and also nodejs built from a locally bumped 18.18.2 template)

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

Couldn't find any.

### Expected behaviour

Node.js doesn't crash.

### Actual behaviour

```console
> require("dns").setServers([])
node[24747]: ../src/cares_wrap.cc:1691:void node::cares_wrap::{anonymous}::SetServers(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[0]->IsArray()' failed.
 1: 0x5647cd363300 node::Abort() [node]
 2: 0x5647cd363394  [node]
 3: 0x5647cd2c361c  [node]
 4: 0x5647cd59d6b6  [node]
 5: 0x5647cd59e1b7 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 6: 0x5647cde36539  [node]
fish: Job 1, 'node' terminated by signal SIGABRT (Abort)
```

This doesn't happen with Node.js 18.18.2 installed from `n`:
```console
> require("dns").setServers([])
undefined
```

From my debugging `IsArray` seems to think that `[]` isn't an empty array for some reason(???); I tried skimming through the patches that Void applies, but I failed to find anything suspicious. I'll debug this more when I get the time, but if anybody can help I'd appreciate that too.

### Steps to reproduce

1. `node -e 'require("dns").setServers([])'`

Re: `require("dns").setServers([])` causes Node.js to crash with an assertion error

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/47411#issuecomment-1839140013

Comment:
Fixed by 7bc0ddadb9a543f34bc15bbc2acc088389d99461.