[PR PATCH] eza: disable stripping during build

[PR PATCH] eza: disable stripping during build

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

There is a new pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages eza-debug
https://github.com/void-linux/void-packages/pull/47459

eza: disable stripping during build
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47459.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-eza-debug-47459.patch --]
[-- Type: text/x-diff, Size: 1276 bytes --]

From 5f4df1a996958819c5ccfa4cc616c728ee370dcb Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Tue, 28 Nov 2023 11:06:36 +0100
Subject: [PATCH] eza: disable stripping during build

---
 srcpkgs/eza/patches/no-strip.patch | 12 ++++++++++++
 srcpkgs/eza/template               |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/eza/patches/no-strip.patch

diff --git a/srcpkgs/eza/patches/no-strip.patch b/srcpkgs/eza/patches/no-strip.patch
new file mode 100644
index 0000000000000..cbb62a3c9f854
--- /dev/null
+++ b/srcpkgs/eza/patches/no-strip.patch
@@ -0,0 +1,12 @@
+diff --git a/Cargo.toml b/Cargo.toml
+index 684e6b0..a9955a5 100644
+--- a/Cargo.toml
++++ b/Cargo.toml
+@@ -130,7 +130,6 @@ nix-generated = []
+ # use LTO for smaller binaries (that take longer to build)
+ [profile.release]
+ lto = true
+-strip = true
+ opt-level = 3
+ codegen-units = 1
+ panic = 'abort'
diff --git a/srcpkgs/eza/template b/srcpkgs/eza/template
index b4d9a6c3ed5a9..355035b74e40e 100644
--- a/srcpkgs/eza/template
+++ b/srcpkgs/eza/template
@@ -1,7 +1,7 @@
 # Template file for 'eza'
 pkgname=eza
 version=0.16.1
-revision=1
+revision=2
 build_style=cargo
 hostmakedepends="pandoc pkg-config"
 makedepends="libgit2-devel"

Re: eza: disable stripping during build

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/47459#issuecomment-1829555467

Comment:
This is a problem with multiple rust packages, not only eza.
E.g. bat also has this set. Maybe we could find soem way to overwrite this in the build style?

Re: eza: disable stripping during build

[tranzystorekk]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by tranzystorekk on void-packages repository

https://github.com/void-linux/void-packages/pull/47459#issuecomment-1829562151

Comment:
True, should be possible via https://doc.rust-lang.org/nightly/cargo/reference/config.html#profilenamestrip

Re: eza: disable stripping during build

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/47459#issuecomment-1829562644

Comment:
setting `CARGO_PROFILE_RELEASE_STRIP=false` should do the trick

Re: [PR PATCH] [Closed]: eza: disable stripping during build

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

There's a closed pull request on the void-packages repository

eza: disable stripping during build
https://github.com/void-linux/void-packages/pull/47459

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->