[PR PATCH] New package: usbimager-1.0.10

[PR PATCH] New package: usbimager-1.0.10

[filiprojek]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

There is a new pull request by filiprojek against master on the void-packages repository

https://github.com/filiprojek/void-packages usbimager
https://github.com/void-linux/void-packages/pull/47851

New package: usbimager-1.0.10
Closes: #42758

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/47851.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-usbimager-47851.patch --]
[-- Type: text/x-diff, Size: 1208 bytes --]

From 938f14b3cf9d543fec4665457cbe3145dadbcf12 Mon Sep 17 00:00:00 2001
From: Filip Rojek <filip@filiprojek.cz>
Date: Thu, 15 Jun 2023 18:43:33 +0200
Subject: [PATCH] New package: usbimager-1.0.10

Closes: #42758
---
 srcpkgs/usbimager/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/usbimager/template

diff --git a/srcpkgs/usbimager/template b/srcpkgs/usbimager/template
new file mode 100644
index 0000000000000..8fd59f1d4f05d
--- /dev/null
+++ b/srcpkgs/usbimager/template
@@ -0,0 +1,23 @@
+# Template file for 'usbimager'
+pkgname=usbimager
+version=1.0.10
+revision=1
+build_style=gnu-makefile
+hostmakedepends="libX11-devel"
+short_desc="Minimal GUI application (GTK) for writing ISO images to USB drives"
+maintainer="Filip Rojek <filip@filiprojek.cz>"
+license="MIT"
+homepage="https://gitlab.com/bztsrc/usbimager"
+changelog="https://gitlab.com/bztsrc/usbimager/-/releases"
+distfiles="https://gitlab.com/bztsrc/usbimager/-/archive/${version}/usbimager-${version}.tar.gz"
+checksum=582a4121bec523c5f737d4c91a5a96357243c146330d7785ab54aa3730fba4ff
+
+do_build() {
+	cd src/
+	make
+}
+
+do_install() {
+	cd src/
+	make DESTDIR=${DESTDIR} install
+}

Re: [PR PATCH] [Updated] New package: usbimager-1.0.10

[filiprojek]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

There is an updated pull request by filiprojek against master on the void-packages repository

https://github.com/filiprojek/void-packages usbimager
https://github.com/void-linux/void-packages/pull/47851

New package: usbimager-1.0.10
Closes: #42758

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/47851.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-usbimager-47851.patch --]
[-- Type: text/x-diff, Size: 1254 bytes --]

From a5066b71e82ee8e696c4d6d51bdabbb418d83d2d Mon Sep 17 00:00:00 2001
From: Filip Rojek <filip@filiprojek.cz>
Date: Thu, 15 Jun 2023 18:43:33 +0200
Subject: [PATCH] New package: usbimager-1.0.10

Closes: #42758
---
 srcpkgs/usbimager/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/usbimager/template

diff --git a/srcpkgs/usbimager/template b/srcpkgs/usbimager/template
new file mode 100644
index 0000000000000..bd797a44907d3
--- /dev/null
+++ b/srcpkgs/usbimager/template
@@ -0,0 +1,27 @@
+# Template file for 'usbimager'
+pkgname=usbimager
+version=1.0.10
+revision=1
+build_style=gnu-makefile
+hostmakedepends="libX11-devel"
+short_desc="Minimal GUI application (GTK) for writing ISO images to USB drives"
+maintainer="Filip Rojek <filip@filiprojek.cz>"
+license="MIT"
+homepage="https://gitlab.com/bztsrc/usbimager"
+changelog="https://gitlab.com/bztsrc/usbimager/-/releases"
+distfiles="https://gitlab.com/bztsrc/usbimager/-/archive/${version}/usbimager-${version}.tar.gz"
+checksum=582a4121bec523c5f737d4c91a5a96357243c146330d7785ab54aa3730fba4ff
+
+do_build() {
+	cd src/
+	make
+}
+
+do_install() {
+	cd src/
+	make DESTDIR=${DESTDIR} install
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: usbimager-1.0.10

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/47851#discussion_r1435867819

Comment:
It should be ` makedepends=`, not `hostmakedepends=`

Re: New package: usbimager-1.0.10

[Luciogi]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

New comment by Luciogi on void-packages repository

https://github.com/void-linux/void-packages/pull/47851#issuecomment-1868576855

Comment:
`build_style=gnu-makefile`
when template mentions , `build_style` variable, then you dont have have to declare functions like `do_build` and `do_install`
xbps-src will do build and install automatically

--- if it fails to build automatically, then you can write custom functions for build and install


If I said anything correct me reviewers

Re: [PR PATCH] [Updated] New package: usbimager-1.0.10

[filiprojek]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

There is an updated pull request by filiprojek against master on the void-packages repository

https://github.com/filiprojek/void-packages usbimager
https://github.com/void-linux/void-packages/pull/47851

New package: usbimager-1.0.10
Closes: #42758

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/47851.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-usbimager-47851.patch --]
[-- Type: text/x-diff, Size: 1283 bytes --]

From 5d88c1f30fb6a7d7bd83d46ad43b1431e9dc666e Mon Sep 17 00:00:00 2001
From: Filip Rojek <filip@filiprojek.cz>
Date: Thu, 15 Jun 2023 18:43:33 +0200
Subject: [PATCH] New package: usbimager-1.0.10

Closes: #42758
---
 srcpkgs/usbimager/template | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 srcpkgs/usbimager/template

diff --git a/srcpkgs/usbimager/template b/srcpkgs/usbimager/template
new file mode 100644
index 0000000000000..34cbc06df462a
--- /dev/null
+++ b/srcpkgs/usbimager/template
@@ -0,0 +1,26 @@
+# Template file for 'usbimager'
+pkgname=usbimager
+version=1.0.10
+revision=1
+archs="~aarch64 ~armv7l ~armv6l-musl ~aarch64-musl"
+build_wrksrc="src"
+hostmakedepends="libX11-devel"
+short_desc="Minimal GUI application (GTK) for writing ISO images to USB drives"
+maintainer="Filip Rojek <filip@filiprojek.cz>"
+license="MIT"
+homepage="https://gitlab.com/bztsrc/usbimager"
+changelog="https://gitlab.com/bztsrc/usbimager/-/releases"
+distfiles="https://gitlab.com/bztsrc/usbimager/-/archive/${version}/usbimager-${version}.tar.gz"
+checksum=582a4121bec523c5f737d4c91a5a96357243c146330d7785ab54aa3730fba4ff
+
+do_build() {
+	make
+}
+
+do_install() {
+	make DESTDIR=${DESTDIR} install
+}
+
+post_install() {
+	vlicense ../LICENSE
+}

Re: [PR REVIEW] New package: usbimager-1.0.10

[filiprojek]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by filiprojek on void-packages repository

https://github.com/void-linux/void-packages/pull/47851#discussion_r1436134723

Comment:
if I make this change, the package can no longer be compiled for any architecture

Re: New package: usbimager-1.0.10

[filiprojek]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

New comment by filiprojek on void-packages repository

https://github.com/void-linux/void-packages/pull/47851#issuecomment-1869077717

Comment:
When I try to build the package using ` build_style=gnu-makefile`, the package reports an error about missing libraries.
There's some problem with the vendored libraries. @Duncaen  advised me on irc to try to link system libraries instead of using vendored ones

I managed to build a package for `x86_64-musl` on my local machine. I have no idea why the package reports an error here.

I have not been able to build a package for these architectures:
 - `aarch64`
 - `armv7l`
 - `armv6l-musl`
 - `aarch64-musl`

On `aarch64` there is this error:
`/usr/bin/aarch64-linux-gnu-strip: Unable to recognise the format of the input file '/destdir/aarch64-linux-gnu/usbimager-1.0.10/usr/bin/usbimager'` 
@classabbyamp advised me that Makefile probably ignores cflags

Until I can fix them, I have masked them in the template.

Re: New package: usbimager-1.0.10

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/47851#issuecomment-2017064924

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: usbimager-1.0.10

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

There's a closed pull request on the void-packages repository

New package: usbimager-1.0.10
https://github.com/void-linux/void-packages/pull/47851

Description:
Closes: #42758

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)