Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] wt: add build options and their dependencies
@ 2023-12-25 13:00 Danoloan10
  2023-12-25 13:17 ` [PR PATCH] [Updated] " Danoloan10
                   ` (19 more replies)
  0 siblings, 20 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 13:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

There is a new pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 3873 bytes --]

From 37bd019a6a563f1fdca7a99ffda9bd4c2b40f7c4 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..019e0ad01869e 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,20 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="$(vopt_bool examples BUILD_EXAMPLES) $(vopt_bool examples INSTALL_EXAMPLES)
+ $(vopt_bool docs INSTALL_DOCUMENTATION) $(vopt_bool resources INSTALL_RESOURCES)
+ $(vopt_bool ssl ENABLE_SSL) $(vopt_bool haru ENABLE_HARU) $(vopt_bool pango ENABLE_PANGO)
+ $(vopt_bool sqlite ENABLE_SQLITE) $(vopt_bool postgres ENABLE_POSTGRES)
+ $(vopt_bool firebird ENABLE_FIREBIRD) $(vopt_bool mysql ENABLE_MYSQL)
+ $(vopt_bool mssqlserver ENABLE_MSSQLSERVER) $(vopt_bool qt4 ENABLE_QT4) $(vopt_bool qt5 ENABLE_QT5)
+ $(vopt_bool saml ENABLE_SAML) $(vopt_bool libwttest ENABLE_LIBWTTEST) $(vopt_bool libtdbo ENABLE_LIBTDBO)
+ $(vopt_bool no_std_locale WT_NO_STD_LOCALE) $(vopt_bool no_std_wstring WT_NO_STD_WSTRING)
+ $(vopt_bool opengl ENABLE_OPENGL) $(vopt_bool unwind ENABLE_UNWIND)"
+makedepends="boost-devel
+ $(vopt_if ssl openssl-devel) $(vopt_if haru Haru-devel) $(vopt_if pango pango-devel) $(vopt_if sqlite sqlite-devel)
+ $(vopt_if postgres postgresql-libs-devel) $(vopt_if firebird firebird3) $(vopt_if mysql libmysqlclient-devel)
+ $(vopt_if mssqlserver unixodbc-devel) $(vopt_if qt4 qt-devel) $(vopt_if qt5 qt5-devel)
+ $(vopt_if opengl libfreeglut-devel) $(vopt_if backtrace libunwind-devel)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +25,28 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="docs examples resources ssl haru pango sqlite postgres firebird mysql mssqlserver qt4 qt5 saml libwttest libtdbo no_std_locale no_std_wstring opengl backtrace"
+build_options_default="resources ssl haru pango sqlite postgres firebird mysql mssqlserver qt5 libwttest libtdbo opengl"
+vopt_conflict qt4 qt5
+desc_option_docs="Install documentation (tutorials and reference)"
+desc_option_examples="Build and install examples (binaries and source)"
+desc_option_resources="Install resources directory"
+desc_option_ssl="Enable cryptography functions, using OpenSSL"
+desc_option_haru="Enable Haru Free PDF Library, which is used to provide support for painting to PDF (WPdfImage)"
+desc_option_pango="Enable Pango Library, which is used for improved font support (WPdfImage and WRasterImage)"
+desc_option_sqlite="Build SQLite3 backend for Wt::Dbo"
+desc_option_postgres="Build PostgreSQL backend for Wt::Dbo"
+desc_option_firebird="Build FirebirdSQL backend for Wt::Dbo"
+desc_option_mysql="Build mariadb/mysql backend for Wt::Dbo"
+desc_option_mssqlserver="Build Microsoft SQL Server backend for Wt::Dbo"
+desc_option_qt4="Build Qt4 interworking library (libwtwithqt)"
+desc_option_qt5="Build Qt5 interworking library (libwtwithqt5)"
+desc_option_saml="Build built-in SAML service provider for Wt::Auth"
+desc_option_no_std_locale="Build Wt to run on a system without std::locale support"
+desc_option_no_std_wstring="Build Wt to run on a system without std::wstring support"
+desc_option_libwttest="Build Wt::Test"
+desc_option_libtdbo="Build Wt::Dbo"
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
@ 2023-12-25 13:17 ` Danoloan10
  2023-12-25 13:35 ` Danoloan10
                   ` (18 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 13:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 3945 bytes --]

From 95ed3eda391d3e9513b38474675a7e70b81b2e77 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 41 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..1e6af81ec9ae7 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,20 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="$(vopt_bool examples BUILD_EXAMPLES) $(vopt_bool examples INSTALL_EXAMPLES)
+ $(vopt_bool docs INSTALL_DOCUMENTATION) $(vopt_bool resources INSTALL_RESOURCES)
+ $(vopt_bool ssl ENABLE_SSL) $(vopt_bool haru ENABLE_HARU) $(vopt_bool pango ENABLE_PANGO)
+ $(vopt_bool sqlite ENABLE_SQLITE) $(vopt_bool postgres ENABLE_POSTGRES)
+ $(vopt_bool firebird ENABLE_FIREBIRD) $(vopt_bool mysql ENABLE_MYSQL)
+ $(vopt_bool mssqlserver ENABLE_MSSQLSERVER) $(vopt_bool qt4 ENABLE_QT4) $(vopt_bool qt5 ENABLE_QT5)
+ $(vopt_bool saml ENABLE_SAML) $(vopt_bool libwttest ENABLE_LIBWTTEST) $(vopt_bool libtdbo ENABLE_LIBTDBO)
+ $(vopt_bool no_std_locale WT_NO_STD_LOCALE) $(vopt_bool no_std_wstring WT_NO_STD_WSTRING)
+ $(vopt_bool opengl ENABLE_OPENGL) $(vopt_bool unwind ENABLE_UNWIND)"
+makedepends="boost-devel
+ $(vopt_if ssl openssl-devel) $(vopt_if haru Haru-devel) $(vopt_if pango pango-devel) $(vopt_if sqlite sqlite-devel)
+ $(vopt_if postgres postgresql-libs-devel) $(vopt_if firebird firebird3) $(vopt_if mysql libmysqlclient-devel)
+ $(vopt_if mssqlserver unixodbc-devel) $(vopt_if qt4 qt-devel) $(vopt_if qt5 qt5-devel)
+ $(vopt_if opengl libfreeglut-devel) $(vopt_if backtrace libunwind-devel)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +25,32 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="docs examples resources ssl haru pango sqlite postgres firebird mysql mssqlserver qt4 qt5 saml libwttest libtdbo no_std_locale no_std_wstring opengl backtrace"
+build_options_default="resources ssl haru pango sqlite postgres mysql mssqlserver qt5 libwttest libtdbo opengl"
+vopt_conflict qt4 qt5
+desc_option_docs="Install documentation (tutorials and reference)"
+desc_option_examples="Build and install examples (binaries and source)"
+desc_option_resources="Install resources directory"
+desc_option_ssl="Enable cryptography functions, using OpenSSL"
+desc_option_haru="Enable Haru Free PDF Library, which is used to provide support for painting to PDF (WPdfImage)"
+desc_option_pango="Enable Pango Library, which is used for improved font support (WPdfImage and WRasterImage)"
+desc_option_sqlite="Build SQLite3 backend for Wt::Dbo"
+desc_option_postgres="Build PostgreSQL backend for Wt::Dbo"
+desc_option_firebird="Build FirebirdSQL backend for Wt::Dbo"
+desc_option_mysql="Build mariadb/mysql backend for Wt::Dbo"
+desc_option_mssqlserver="Build Microsoft SQL Server backend for Wt::Dbo"
+desc_option_qt4="Build Qt4 interworking library (libwtwithqt)"
+desc_option_qt5="Build Qt5 interworking library (libwtwithqt5)"
+desc_option_saml="Build built-in SAML service provider for Wt::Auth"
+desc_option_no_std_locale="Build Wt to run on a system without std::locale support"
+desc_option_no_std_wstring="Build Wt to run on a system without std::wstring support"
+desc_option_libwttest="Build Wt::Test"
+desc_option_libtdbo="Build Wt::Dbo"
+
+if [ -n "$CROSS_BUILD ]; then
+    build_options_default+=" firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
  2023-12-25 13:17 ` [PR PATCH] [Updated] " Danoloan10
@ 2023-12-25 13:35 ` Danoloan10
  2023-12-25 13:38 ` Danoloan10
                   ` (17 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 13:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 3942 bytes --]

From 7ebbadfaf4db88be7170dff22b5ba955fe033291 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 41 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..63f369eed137a 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,20 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="$(vopt_bool examples BUILD_EXAMPLES) $(vopt_bool examples INSTALL_EXAMPLES)
+ $(vopt_bool docs INSTALL_DOCUMENTATION) $(vopt_bool resources INSTALL_RESOURCES)
+ $(vopt_bool ssl ENABLE_SSL) $(vopt_bool haru ENABLE_HARU) $(vopt_bool pango ENABLE_PANGO)
+ $(vopt_bool sqlite ENABLE_SQLITE) $(vopt_bool postgres ENABLE_POSTGRES)
+ $(vopt_bool firebird ENABLE_FIREBIRD) $(vopt_bool mysql ENABLE_MYSQL)
+ $(vopt_bool mssqlserver ENABLE_MSSQLSERVER) $(vopt_bool qt4 ENABLE_QT4) $(vopt_bool qt5 ENABLE_QT5)
+ $(vopt_bool saml ENABLE_SAML) $(vopt_bool libwttest ENABLE_LIBWTTEST) $(vopt_bool libtdbo ENABLE_LIBTDBO)
+ $(vopt_bool no_std_locale WT_NO_STD_LOCALE) $(vopt_bool no_std_wstring WT_NO_STD_WSTRING)
+ $(vopt_bool opengl ENABLE_OPENGL) $(vopt_bool unwind ENABLE_UNWIND)"
+makedepends="boost-devel
+ $(vopt_if ssl openssl-devel) $(vopt_if haru Haru-devel) $(vopt_if pango pango-devel) $(vopt_if sqlite sqlite-devel)
+ $(vopt_if postgres postgresql-libs-devel) $(vopt_if firebird firebird3) $(vopt_if mysql libmysqlclient-devel)
+ $(vopt_if mssqlserver unixodbc-devel) $(vopt_if qt4 qt-devel) $(vopt_if qt5 qt5-devel)
+ $(vopt_if opengl libfreeglut-devel) $(vopt_if backtrace libunwind-devel)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +25,32 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="docs examples resources ssl haru pango sqlite postgres firebird mysql mssqlserver qt4 qt5 saml libwttest libtdbo no_std_locale no_std_wstring opengl backtrace"
+build_options_default="resources ssl haru pango sqlite postgres mysql mssqlserver qt5 libwttest libtdbo opengl"
+vopt_conflict qt4 qt5
+desc_option_docs="Install documentation (tutorials and reference)"
+desc_option_examples="Build and install examples (binaries and source)"
+desc_option_resources="Install resources directory"
+desc_option_ssl="Enable cryptography functions, using OpenSSL"
+desc_option_haru="Enable Haru Free PDF Library, which is used to provide support for painting to PDF (WPdfImage)"
+desc_option_pango="Enable Pango Library, which is used for improved font support (WPdfImage and WRasterImage)"
+desc_option_sqlite="Build SQLite3 backend for Wt::Dbo"
+desc_option_postgres="Build PostgreSQL backend for Wt::Dbo"
+desc_option_firebird="Build FirebirdSQL backend for Wt::Dbo"
+desc_option_mysql="Build mariadb/mysql backend for Wt::Dbo"
+desc_option_mssqlserver="Build Microsoft SQL Server backend for Wt::Dbo"
+desc_option_qt4="Build Qt4 interworking library (libwtwithqt)"
+desc_option_qt5="Build Qt5 interworking library (libwtwithqt5)"
+desc_option_saml="Build built-in SAML service provider for Wt::Auth"
+desc_option_no_std_locale="Build Wt to run on a system without std::locale support"
+desc_option_no_std_wstring="Build Wt to run on a system without std::wstring support"
+desc_option_libwttest="Build Wt::Test"
+desc_option_libtdbo="Build Wt::Dbo"
+
+if [ -n "$CROSS_BUILD ]; then
+	build_options_default+=" firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
  2023-12-25 13:17 ` [PR PATCH] [Updated] " Danoloan10
  2023-12-25 13:35 ` Danoloan10
@ 2023-12-25 13:38 ` Danoloan10
  2023-12-25 13:40 ` Danoloan10
                   ` (16 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 13:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 3942 bytes --]

From b94779363999d525f7315f3cbd3e849eea796e86 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 41 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..63f369eed137a 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,20 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="$(vopt_bool examples BUILD_EXAMPLES) $(vopt_bool examples INSTALL_EXAMPLES)
+ $(vopt_bool docs INSTALL_DOCUMENTATION) $(vopt_bool resources INSTALL_RESOURCES)
+ $(vopt_bool ssl ENABLE_SSL) $(vopt_bool haru ENABLE_HARU) $(vopt_bool pango ENABLE_PANGO)
+ $(vopt_bool sqlite ENABLE_SQLITE) $(vopt_bool postgres ENABLE_POSTGRES)
+ $(vopt_bool firebird ENABLE_FIREBIRD) $(vopt_bool mysql ENABLE_MYSQL)
+ $(vopt_bool mssqlserver ENABLE_MSSQLSERVER) $(vopt_bool qt4 ENABLE_QT4) $(vopt_bool qt5 ENABLE_QT5)
+ $(vopt_bool saml ENABLE_SAML) $(vopt_bool libwttest ENABLE_LIBWTTEST) $(vopt_bool libtdbo ENABLE_LIBTDBO)
+ $(vopt_bool no_std_locale WT_NO_STD_LOCALE) $(vopt_bool no_std_wstring WT_NO_STD_WSTRING)
+ $(vopt_bool opengl ENABLE_OPENGL) $(vopt_bool unwind ENABLE_UNWIND)"
+makedepends="boost-devel
+ $(vopt_if ssl openssl-devel) $(vopt_if haru Haru-devel) $(vopt_if pango pango-devel) $(vopt_if sqlite sqlite-devel)
+ $(vopt_if postgres postgresql-libs-devel) $(vopt_if firebird firebird3) $(vopt_if mysql libmysqlclient-devel)
+ $(vopt_if mssqlserver unixodbc-devel) $(vopt_if qt4 qt-devel) $(vopt_if qt5 qt5-devel)
+ $(vopt_if opengl libfreeglut-devel) $(vopt_if backtrace libunwind-devel)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +25,32 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="docs examples resources ssl haru pango sqlite postgres firebird mysql mssqlserver qt4 qt5 saml libwttest libtdbo no_std_locale no_std_wstring opengl backtrace"
+build_options_default="resources ssl haru pango sqlite postgres mysql mssqlserver qt5 libwttest libtdbo opengl"
+vopt_conflict qt4 qt5
+desc_option_docs="Install documentation (tutorials and reference)"
+desc_option_examples="Build and install examples (binaries and source)"
+desc_option_resources="Install resources directory"
+desc_option_ssl="Enable cryptography functions, using OpenSSL"
+desc_option_haru="Enable Haru Free PDF Library, which is used to provide support for painting to PDF (WPdfImage)"
+desc_option_pango="Enable Pango Library, which is used for improved font support (WPdfImage and WRasterImage)"
+desc_option_sqlite="Build SQLite3 backend for Wt::Dbo"
+desc_option_postgres="Build PostgreSQL backend for Wt::Dbo"
+desc_option_firebird="Build FirebirdSQL backend for Wt::Dbo"
+desc_option_mysql="Build mariadb/mysql backend for Wt::Dbo"
+desc_option_mssqlserver="Build Microsoft SQL Server backend for Wt::Dbo"
+desc_option_qt4="Build Qt4 interworking library (libwtwithqt)"
+desc_option_qt5="Build Qt5 interworking library (libwtwithqt5)"
+desc_option_saml="Build built-in SAML service provider for Wt::Auth"
+desc_option_no_std_locale="Build Wt to run on a system without std::locale support"
+desc_option_no_std_wstring="Build Wt to run on a system without std::wstring support"
+desc_option_libwttest="Build Wt::Test"
+desc_option_libtdbo="Build Wt::Dbo"
+
+if [ -n "$CROSS_BUILD ]; then
+	build_options_default+=" firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (2 preceding siblings ...)
  2023-12-25 13:38 ` Danoloan10
@ 2023-12-25 13:40 ` Danoloan10
  2023-12-25 14:18 ` classabbyamp
                   ` (15 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 13:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 3943 bytes --]

From cecbe172238000e7fba61a87a6b04597ba01b27b Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 41 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..c48c3ab0d9535 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,20 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="$(vopt_bool examples BUILD_EXAMPLES) $(vopt_bool examples INSTALL_EXAMPLES)
+ $(vopt_bool docs INSTALL_DOCUMENTATION) $(vopt_bool resources INSTALL_RESOURCES)
+ $(vopt_bool ssl ENABLE_SSL) $(vopt_bool haru ENABLE_HARU) $(vopt_bool pango ENABLE_PANGO)
+ $(vopt_bool sqlite ENABLE_SQLITE) $(vopt_bool postgres ENABLE_POSTGRES)
+ $(vopt_bool firebird ENABLE_FIREBIRD) $(vopt_bool mysql ENABLE_MYSQL)
+ $(vopt_bool mssqlserver ENABLE_MSSQLSERVER) $(vopt_bool qt4 ENABLE_QT4) $(vopt_bool qt5 ENABLE_QT5)
+ $(vopt_bool saml ENABLE_SAML) $(vopt_bool libwttest ENABLE_LIBWTTEST) $(vopt_bool libtdbo ENABLE_LIBTDBO)
+ $(vopt_bool no_std_locale WT_NO_STD_LOCALE) $(vopt_bool no_std_wstring WT_NO_STD_WSTRING)
+ $(vopt_bool opengl ENABLE_OPENGL) $(vopt_bool unwind ENABLE_UNWIND)"
+makedepends="boost-devel
+ $(vopt_if ssl openssl-devel) $(vopt_if haru Haru-devel) $(vopt_if pango pango-devel) $(vopt_if sqlite sqlite-devel)
+ $(vopt_if postgres postgresql-libs-devel) $(vopt_if firebird firebird3) $(vopt_if mysql libmysqlclient-devel)
+ $(vopt_if mssqlserver unixodbc-devel) $(vopt_if qt4 qt-devel) $(vopt_if qt5 qt5-devel)
+ $(vopt_if opengl libfreeglut-devel) $(vopt_if backtrace libunwind-devel)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +25,32 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="docs examples resources ssl haru pango sqlite postgres firebird mysql mssqlserver qt4 qt5 saml libwttest libtdbo no_std_locale no_std_wstring opengl backtrace"
+build_options_default="resources ssl haru pango sqlite postgres mysql mssqlserver qt5 libwttest libtdbo opengl"
+vopt_conflict qt4 qt5
+desc_option_docs="Install documentation (tutorials and reference)"
+desc_option_examples="Build and install examples (binaries and source)"
+desc_option_resources="Install resources directory"
+desc_option_ssl="Enable cryptography functions, using OpenSSL"
+desc_option_haru="Enable Haru Free PDF Library, which is used to provide support for painting to PDF (WPdfImage)"
+desc_option_pango="Enable Pango Library, which is used for improved font support (WPdfImage and WRasterImage)"
+desc_option_sqlite="Build SQLite3 backend for Wt::Dbo"
+desc_option_postgres="Build PostgreSQL backend for Wt::Dbo"
+desc_option_firebird="Build FirebirdSQL backend for Wt::Dbo"
+desc_option_mysql="Build mariadb/mysql backend for Wt::Dbo"
+desc_option_mssqlserver="Build Microsoft SQL Server backend for Wt::Dbo"
+desc_option_qt4="Build Qt4 interworking library (libwtwithqt)"
+desc_option_qt5="Build Qt5 interworking library (libwtwithqt5)"
+desc_option_saml="Build built-in SAML service provider for Wt::Auth"
+desc_option_no_std_locale="Build Wt to run on a system without std::locale support"
+desc_option_no_std_wstring="Build Wt to run on a system without std::wstring support"
+desc_option_libwttest="Build Wt::Test"
+desc_option_libtdbo="Build Wt::Dbo"
+
+if [ -n "$CROSS_BUILD" ]; then
+	build_options_default+=" firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (3 preceding siblings ...)
  2023-12-25 13:40 ` Danoloan10
@ 2023-12-25 14:18 ` classabbyamp
  2023-12-25 14:39 ` Danoloan10
                   ` (14 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-25 14:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#issuecomment-1869004139

Comment:
this isn't Gentoo, not everything needs to be a build option. some of these don't even make sense, like the qt4 one (we don't have qt4 anymore) 

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (4 preceding siblings ...)
  2023-12-25 14:18 ` classabbyamp
@ 2023-12-25 14:39 ` Danoloan10
  2023-12-25 14:55 ` classabbyamp
                   ` (13 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 14:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New comment by Danoloan10 on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#issuecomment-1869011045

Comment:
the default config would fix the original issue, because everything is enabled by default on the condition that each dependency package is found. so I guess a full build without options should be ok. in that case should any of these options be kept?

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (5 preceding siblings ...)
  2023-12-25 14:39 ` Danoloan10
@ 2023-12-25 14:55 ` classabbyamp
  2023-12-25 15:48 ` [PR PATCH] [Updated] " Danoloan10
                   ` (12 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-25 14:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#issuecomment-1869016581

Comment:
then just add the necessary build dependencies 

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (6 preceding siblings ...)
  2023-12-25 14:55 ` classabbyamp
@ 2023-12-25 15:48 ` Danoloan10
  2023-12-25 15:57 ` Danoloan10
                   ` (11 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 15:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1521 bytes --]

From 1ebcf9b0c6cae8df1bb902b4b2ec3384108f189c Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..6b7050127255f 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,10 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="-DBUILD_EXAMPLES=OFF -DINSTALL_EXAMPLES=OFF $(vopt_bool firebird ENABLE_FIREBIRD)"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt-devel qt5-devel libfreeglut-devel libunwind-devel
+ $(vopt_if firebird firebird3)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +15,13 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="firebird"
+build_options_default=""
+
+if [ -n "$CROSS_BUILD" ]; then
+	build_options_default+=" firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (7 preceding siblings ...)
  2023-12-25 15:48 ` [PR PATCH] [Updated] " Danoloan10
@ 2023-12-25 15:57 ` Danoloan10
  2023-12-25 16:04 ` Danoloan10
                   ` (10 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 15:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly** (only default options)

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1483 bytes --]

From f41ce36a86e392717e8227a03371ccd566c5b52b Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..577445e99fff5 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,10 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="-DBUILD_EXAMPLES=OFF -DINSTALL_EXAMPLES=OFF $(vopt_bool firebird ENABLE_FIREBIRD)"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt5-devel libfreeglut-devel libunwind-devel
+ $(vopt_if firebird firebird3)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +15,12 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="firebird"
+
+if [ -z "$CROSS_BUILD" ]; then
+	build_options_default="firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (8 preceding siblings ...)
  2023-12-25 15:57 ` Danoloan10
@ 2023-12-25 16:04 ` Danoloan10
  2023-12-25 16:25 ` Danoloan10
                   ` (9 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 16:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1500 bytes --]

From 0a4379319108537ad45c8c7726e743c9d83aa123 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..c3a83e0a9f4c1 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,10 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+configure_args="-DBUILD_EXAMPLES=OFF -DINSTALL_EXAMPLES=OFF -DENABLE_QT4=OFF $(vopt_bool firebird ENABLE_FIREBIRD)"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt5-devel libfreeglut-devel libunwind-devel
+ $(vopt_if firebird firebird3)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +15,12 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="firebird"
+
+if [ -z "$CROSS_BUILD" ]; then
+	build_options_default="firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (9 preceding siblings ...)
  2023-12-25 16:04 ` Danoloan10
@ 2023-12-25 16:25 ` Danoloan10
  2023-12-25 18:38 ` [PR REVIEW] " classabbyamp
                   ` (8 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-25 16:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1566 bytes --]

From 7ff8234b81d04028a080a1f9527eda9eeed53af3 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..5e37bc5d3b1fe 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -3,7 +3,12 @@ pkgname=wt
 version=4.10.0
 revision=2
 build_style=cmake
-makedepends="boost-devel"
+build_helper=qmake
+configure_args="-DBUILD_EXAMPLES=OFF -DINSTALL_EXAMPLES=OFF -DENABLE_QT4=OFF $(vopt_bool firebird ENABLE_FIREBIRD)"
+hostmakedepends="qt5-host-tools qt5-qmake"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt5-devel libfreeglut-devel libunwind-devel
+ $(vopt_if firebird firebird3)"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"
@@ -12,6 +17,12 @@ changelog="https://webtoolkit.eu/wt/doc/reference/html/Releasenotes.html"
 distfiles="https://github.com/emweb/wt/archive/refs/tags/${version}.tar.gz"
 checksum=7090023d4fc4b6594bf4cb11072d9d3d775269327aece9a8993c7bbe46decb9d
 
+build_options="firebird"
+
+if [ -z "$CROSS_BUILD" ]; then
+	build_options_default="firebird"
+fi
+
 wt-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR REVIEW] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (10 preceding siblings ...)
  2023-12-25 16:25 ` Danoloan10
@ 2023-12-25 18:38 ` classabbyamp
  2023-12-25 18:38 ` classabbyamp
                   ` (7 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-25 18:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#discussion_r1436138679

Comment:
INSTALL_EXAMPLES appears to default to off

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR REVIEW] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (11 preceding siblings ...)
  2023-12-25 18:38 ` [PR REVIEW] " classabbyamp
@ 2023-12-25 18:38 ` classabbyamp
  2023-12-25 18:39 ` classabbyamp
                   ` (6 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-25 18:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#discussion_r1436138718

Comment:
this should be incremented

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR REVIEW] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (12 preceding siblings ...)
  2023-12-25 18:38 ` classabbyamp
@ 2023-12-25 18:39 ` classabbyamp
  2023-12-26 20:48 ` Danoloan10
                   ` (5 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-25 18:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#discussion_r1436138841

Comment:
firebird probably needs to be added to `depends` (too?)

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR REVIEW] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (13 preceding siblings ...)
  2023-12-25 18:39 ` classabbyamp
@ 2023-12-26 20:48 ` Danoloan10
  2023-12-26 20:50 ` [PR PATCH] [Updated] " Danoloan10
                   ` (4 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-26 20:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by Danoloan10 on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#discussion_r1436609242

Comment:
I have investigated the code base a bit and it looks like it's looking for "libfbclient", which is not being provided by the firebird3 package anyway, so this option is useless

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (14 preceding siblings ...)
  2023-12-26 20:48 ` Danoloan10
@ 2023-12-26 20:50 ` Danoloan10
  2023-12-26 20:52 ` Danoloan10
                   ` (3 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-26 20:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1088 bytes --]

From fd2e1c9307553cf50eaee81db8d3cb21108b45e7 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build options and their dependencies

Fixes https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..95a834500093a 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -1,9 +1,13 @@
 # Template file for 'wt'
 pkgname=wt
 version=4.10.0
-revision=2
+revision=3
 build_style=cmake
-makedepends="boost-devel"
+build_helper=qmake
+configure_args="-DBUILD_EXAMPLES=OFF -DENABLE_QT4=OFF $(vopt_bool firebird ENABLE_FIREBIRD)"
+hostmakedepends="qt5-host-tools qt5-qmake"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt5-devel libfreeglut-devel libunwind-devel"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build options and their dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (15 preceding siblings ...)
  2023-12-26 20:50 ` [PR PATCH] [Updated] " Danoloan10
@ 2023-12-26 20:52 ` Danoloan10
  2023-12-26 21:07 ` [PR REVIEW] wt: add build dependencies classabbyamp
                   ` (2 subsequent siblings)
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-26 20:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build options and their dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1276 bytes --]

From 9d4453e29deba6b0895cb58d843ac2ea1f0454e5 Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build dependencies

Wt's build will silently ignore build options if their respective
dependencies are not found, but this does not mean that they should not
be used. In fact, the lms package needs wt be built with OpenSSL.

Fixes: https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..95a834500093a 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -1,9 +1,13 @@
 # Template file for 'wt'
 pkgname=wt
 version=4.10.0
-revision=2
+revision=3
 build_style=cmake
-makedepends="boost-devel"
+build_helper=qmake
+configure_args="-DBUILD_EXAMPLES=OFF -DENABLE_QT4=OFF $(vopt_bool firebird ENABLE_FIREBIRD)"
+hostmakedepends="qt5-host-tools qt5-qmake"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt5-devel libfreeglut-devel libunwind-devel"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR REVIEW] wt: add build dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (16 preceding siblings ...)
  2023-12-26 20:52 ` Danoloan10
@ 2023-12-26 21:07 ` classabbyamp
  2023-12-26 21:48 ` [PR PATCH] [Updated] " Danoloan10
  2023-12-26 23:07 ` [PR PATCH] [Merged]: " classabbyamp
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-26 21:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/47903#discussion_r1436613859

Comment:
```suggestion
configure_args="-DBUILD_EXAMPLES=OFF -DENABLE_QT4=OFF"
```

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Updated] wt: add build dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (17 preceding siblings ...)
  2023-12-26 21:07 ` [PR REVIEW] wt: add build dependencies classabbyamp
@ 2023-12-26 21:48 ` Danoloan10
  2023-12-26 23:07 ` [PR PATCH] [Merged]: " classabbyamp
  19 siblings, 0 replies; 21+ messages in thread
From: Danoloan10 @ 2023-12-26 21:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

There is an updated pull request by Danoloan10 against master on the void-packages repository

https://github.com/Danoloan10/void-packages wt-opts
https://github.com/void-linux/void-packages/pull/47903

wt: add build dependencies
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


A patch file from https://github.com/void-linux/void-packages/pull/47903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wt-opts-47903.patch --]
[-- Type: text/x-diff, Size: 1238 bytes --]

From df407c7ab895c2ac1413431a918faa13b6bd61ee Mon Sep 17 00:00:00 2001
From: danoloan10 <danolo@danoloan.es>
Date: Mon, 25 Dec 2023 13:48:18 +0100
Subject: [PATCH] wt: add build dependencies

Wt's build will silently ignore build options if their respective
dependencies are not found, but this does not mean that they should not
be used. In fact, the lms package needs wt be built with OpenSSL.

Fixes: https://github.com/epoupon/lms/issues/384
---
 srcpkgs/wt/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/wt/template b/srcpkgs/wt/template
index d825acae8889b..fb154d61c6ad0 100644
--- a/srcpkgs/wt/template
+++ b/srcpkgs/wt/template
@@ -1,9 +1,13 @@
 # Template file for 'wt'
 pkgname=wt
 version=4.10.0
-revision=2
+revision=3
 build_style=cmake
-makedepends="boost-devel"
+build_helper=qmake
+configure_args="-DBUILD_EXAMPLES=OFF -DENABLE_QT4=OFF"
+hostmakedepends="qt5-host-tools qt5-qmake"
+makedepends="boost-devel openssl-devel Haru-devel pango-devel sqlite-devel postgresql-libs-devel
+ libmysqlclient-devel unixodbc-devel qt5-devel libfreeglut-devel libunwind-devel"
 short_desc="Wt, C++ Web Toolkit"
 maintainer="danoloan10 <danoloan10@tutanota.com>"
 license="GPL-2.0-or-later"

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PR PATCH] [Merged]: wt: add build dependencies
  2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
                   ` (18 preceding siblings ...)
  2023-12-26 21:48 ` [PR PATCH] [Updated] " Danoloan10
@ 2023-12-26 23:07 ` classabbyamp
  19 siblings, 0 replies; 21+ messages in thread
From: classabbyamp @ 2023-12-26 23:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

There's a merged pull request on the void-packages repository

wt: add build dependencies
https://github.com/void-linux/void-packages/pull/47903

Description:
Fixes https://github.com/epoupon/lms/issues/384

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glib)


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2023-12-26 23:07 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-25 13:00 [PR PATCH] wt: add build options and their dependencies Danoloan10
2023-12-25 13:17 ` [PR PATCH] [Updated] " Danoloan10
2023-12-25 13:35 ` Danoloan10
2023-12-25 13:38 ` Danoloan10
2023-12-25 13:40 ` Danoloan10
2023-12-25 14:18 ` classabbyamp
2023-12-25 14:39 ` Danoloan10
2023-12-25 14:55 ` classabbyamp
2023-12-25 15:48 ` [PR PATCH] [Updated] " Danoloan10
2023-12-25 15:57 ` Danoloan10
2023-12-25 16:04 ` Danoloan10
2023-12-25 16:25 ` Danoloan10
2023-12-25 18:38 ` [PR REVIEW] " classabbyamp
2023-12-25 18:38 ` classabbyamp
2023-12-25 18:39 ` classabbyamp
2023-12-26 20:48 ` Danoloan10
2023-12-26 20:50 ` [PR PATCH] [Updated] " Danoloan10
2023-12-26 20:52 ` Danoloan10
2023-12-26 21:07 ` [PR REVIEW] wt: add build dependencies classabbyamp
2023-12-26 21:48 ` [PR PATCH] [Updated] " Danoloan10
2023-12-26 23:07 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).