[PR PATCH] perl: depends on libxcrypt-devel

[PR PATCH] perl: depends on libxcrypt-devel

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages perl
https://github.com/void-linux/void-packages/pull/47979

perl: depends on libxcrypt-devel
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Fixes https://github.com/void-linux/void-packages/pull/47977

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47979.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-47979.patch --]
[-- Type: text/x-diff, Size: 1000 bytes --]

From 9b8986bb8bb8e5f45ba1a64f071db69a93c0816d Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Fri, 29 Dec 2023 07:27:21 -0800
Subject: [PATCH] perl: depends on libxcrypt-devel

When crypt support is enabled, the public header files also include
crypt.h in core_perl/CORE/reentr.h
---
 srcpkgs/perl/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/perl/template b/srcpkgs/perl/template
index b82da36b50f06..010bda8cd3f98 100644
--- a/srcpkgs/perl/template
+++ b/srcpkgs/perl/template
@@ -1,7 +1,7 @@
 # Template file for 'perl'
 pkgname=perl
 version=5.38.2
-revision=2
+revision=3
 _perl_cross_version=1.5.2
 build_style=gnu-configure
 makedepends="zlib-devel bzip2-devel gdbm-devel db-devel"
@@ -20,6 +20,7 @@ skip_extraction=perl-cross-${_perl_cross_version}.tar.gz
 
 if [ "$XBPS_TARGET_LIBC" = "glibc" ]; then
 	makedepends+=" libxcrypt-devel"
+	depends+=" libxcrypt-devel"
 fi
 
 # Before updating this package to a new major version, run

Re: [PR PATCH] [Updated] perl: depends on libxcrypt-devel

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages perl
https://github.com/void-linux/void-packages/pull/47979

perl: depends on libxcrypt-devel
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Fixes https://github.com/void-linux/void-packages/pull/47977

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47979.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-47979.patch --]
[-- Type: text/x-diff, Size: 1001 bytes --]

From 0bd08aa90e78515eb759ae94cde9f08685dc29ec Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Fri, 29 Dec 2023 07:27:21 -0800
Subject: [PATCH] perl: depends on libxcrypt-devel

When crypt support is enabled, the public header files also includes
crypt.h in core_perl/CORE/reentr.h
---
 srcpkgs/perl/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/perl/template b/srcpkgs/perl/template
index b82da36b50f06..010bda8cd3f98 100644
--- a/srcpkgs/perl/template
+++ b/srcpkgs/perl/template
@@ -1,7 +1,7 @@
 # Template file for 'perl'
 pkgname=perl
 version=5.38.2
-revision=2
+revision=3
 _perl_cross_version=1.5.2
 build_style=gnu-configure
 makedepends="zlib-devel bzip2-devel gdbm-devel db-devel"
@@ -20,6 +20,7 @@ skip_extraction=perl-cross-${_perl_cross_version}.tar.gz
 
 if [ "$XBPS_TARGET_LIBC" = "glibc" ]; then
 	makedepends+=" libxcrypt-devel"
+	depends+=" libxcrypt-devel"
 fi
 
 # Before updating this package to a new major version, run

Re: perl: depends on libxcrypt-devel

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/47979#issuecomment-1872200439

Comment:
The test failure isn't related to this PR and seems to have been happening for a while.

Re: perl: depends on libxcrypt-devel

[tsndqst]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/47979#issuecomment-1872202387

Comment:
I was just about to create a PR for the exact same change.
This is needed for apps that compile against perl such as postgresql, ImageMagick, hexchat, etc. so crypt.h is available when building those packages.

https://github.com/void-linux/void-packages/pull/47977 is dependent on this PR.

Re: [PR PATCH] [Merged]: perl: depends on libxcrypt-devel

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

There's a merged pull request on the void-packages repository

perl: depends on libxcrypt-devel
https://github.com/void-linux/void-packages/pull/47979

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Fixes build for https://github.com/void-linux/void-packages/pull/47977

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->