Github messages for voidlinux
 help / color / mirror / Atom feed
From: dkwo <dkwo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] lf: build with cgo=0, run checks
Date: Thu, 25 Jan 2024 22:45:43 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48373@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages lf
https://github.com/void-linux/void-packages/pull/48373

lf: build with cgo=0, run checks
build static as suggested by upstream, run checks. cc maintainer @TeddyDD 

- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (cross aarch64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/48373.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lf-48373.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]

From ac81c6d479ead6a7fe29edcc166cd11c770772ae Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 25 Jan 2024 16:42:41 -0500
Subject: [PATCH] lf: build with cgo=0, run checks

---
 srcpkgs/lf/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/lf/template b/srcpkgs/lf/template
index eac3fd04beab0..9c718153bc72a 100644
--- a/srcpkgs/lf/template
+++ b/srcpkgs/lf/template
@@ -1,7 +1,7 @@
 # Template file for 'lf'
 pkgname=lf
 version=r31
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/gokcehan/${pkgname}"
 go_ldflags="-X main.gVersion=$version"
@@ -11,6 +11,11 @@ license="MIT"
 homepage="https://github.com/gokcehan/lf"
 distfiles="https://github.com/gokcehan/lf/archive/${version}.tar.gz"
 checksum=ed47fc22c58cf4f4e4116a58c500bdb9f9ccc0b89f87be09f321e8d1431226ab
+export CGO_ENABLED=0
+
+do_check() {
+	go test ./...
+}
 
 post_install() {
 	vlicense LICENSE

             reply	other threads:[~2024-01-25 21:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 21:45 dkwo [this message]
2024-01-26  7:42 ` TeddyDD
2024-01-30 22:48 ` dkwo
2024-01-31 18:44 ` TeddyDD
2024-01-31 21:17 ` [PR PATCH] [Closed]: " dkwo
2024-01-31 21:17 ` dkwo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48373@inbox.vuxu.org \
    --to=dkwo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).