[PR PATCH] lf: build with cgo=0, run checks

[PR PATCH] lf: build with cgo=0, run checks

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages lf
https://github.com/void-linux/void-packages/pull/48373

lf: build with cgo=0, run checks
build static as suggested by upstream, run checks. cc maintainer @TeddyDD 

- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (cross aarch64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/48373.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lf-48373.patch --]
[-- Type: text/x-diff, Size: 949 bytes --]

From ac81c6d479ead6a7fe29edcc166cd11c770772ae Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 25 Jan 2024 16:42:41 -0500
Subject: [PATCH] lf: build with cgo=0, run checks

---
 srcpkgs/lf/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/lf/template b/srcpkgs/lf/template
index eac3fd04beab0..9c718153bc72a 100644
--- a/srcpkgs/lf/template
+++ b/srcpkgs/lf/template
@@ -1,7 +1,7 @@
 # Template file for 'lf'
 pkgname=lf
 version=r31
-revision=1
+revision=2
 build_style=go
 go_import_path="github.com/gokcehan/${pkgname}"
 go_ldflags="-X main.gVersion=$version"
@@ -11,6 +11,11 @@ license="MIT"
 homepage="https://github.com/gokcehan/lf"
 distfiles="https://github.com/gokcehan/lf/archive/${version}.tar.gz"
 checksum=ed47fc22c58cf4f4e4116a58c500bdb9f9ccc0b89f87be09f321e8d1431226ab
+export CGO_ENABLED=0
+
+do_check() {
+	go test ./...
+}
 
 post_install() {
 	vlicense LICENSE

Re: lf: build with cgo=0, run checks

[TeddyDD]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by TeddyDD on void-packages repository

https://github.com/void-linux/void-packages/pull/48373#issuecomment-1911615189

Comment:
What's the added value of building this statically for system-wide installation? From what I see, Void defaults to `CGO_ENABLED=1`

Re: lf: build with cgo=0, run checks

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/48373#issuecomment-1918041969

Comment:
That's what upstream does and suggests. What's the disadvantage?

Re: lf: build with cgo=0, run checks

[TeddyDD]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

New comment by TeddyDD on void-packages repository

https://github.com/void-linux/void-packages/pull/48373#issuecomment-1919718531

Comment:
> That's what upstream does and suggests

It's not a strong suggestion, just copy-paste instruction for people who want to build it from source.
Half of programs written in Go suggest you should do static build so you can copy binary around.

For whatever reason, Void doesn't do this, and I fell like exceptions shoud be justified.

Re: [PR PATCH] [Closed]: lf: build with cgo=0, run checks

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

There's a closed pull request on the void-packages repository

lf: build with cgo=0, run checks
https://github.com/void-linux/void-packages/pull/48373

Description:
build static as suggested by upstream, run checks. cc maintainer @TeddyDD 

- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (cross aarch64-musl)

Re: lf: build with cgo=0, run checks

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/48373#issuecomment-1919983715

Comment:
Fair enough.