Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Update template to preserve debug symbols
@ 2024-01-30 20:56 sbromberger
  2024-01-30 21:19 ` valgrind: " oreo639
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: sbromberger @ 2024-01-30 20:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

There is a new pull request by sbromberger against master on the void-packages repository

https://github.com/sbromberger/void-packages patch-5
https://github.com/void-linux/void-packages/pull/48448

Update template to preserve debug symbols
Added `nostrip=yes` to preserve debug symbols, required for upstream bug submissions. Bumps revision to 2. Closes #48427.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 glibc (`Void 6.6.11_1 x86_64 AuthenticAMD uptodate rFFFF`)


A patch file from https://github.com/void-linux/void-packages/pull/48448.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-5-48448.patch --]
[-- Type: text/x-diff, Size: 875 bytes --]

From d475e419c7fa8cdf52fc35939d4ec40bf5a2cc89 Mon Sep 17 00:00:00 2001
From: Seth Bromberger <sbromberger@users.noreply.github.com>
Date: Tue, 30 Jan 2024 12:54:54 -0800
Subject: [PATCH] Update template to preserve debug symbols

Added `nostrip=yes` to preserve debug symbols, required for upstream bug submissions. Closes #48427.
---
 srcpkgs/valgrind/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/valgrind/template b/srcpkgs/valgrind/template
index bc93f932e335e..f140627efe5b6 100644
--- a/srcpkgs/valgrind/template
+++ b/srcpkgs/valgrind/template
@@ -1,8 +1,9 @@
 # Template file for 'valgrind'
 pkgname=valgrind
 version=3.22.0
-revision=1
+revision=2
 build_style=gnu-configure
+nostrip=yes
 configure_args="--enable-tls --without-mpicc --enable-lto=yes"
 hostmakedepends="automake perl pkg-config"
 makedepends="libgomp-devel"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: valgrind: Update template to preserve debug symbols
  2024-01-30 20:56 [PR PATCH] Update template to preserve debug symbols sbromberger
@ 2024-01-30 21:19 ` oreo639
  2024-02-05  5:44 ` valgrind: " oreo639
  2024-02-15  3:51 ` [PR PATCH] [Closed]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: oreo639 @ 2024-01-30 21:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48448#issuecomment-1917912408

Comment:
You can fix the commit message and author by cloning your repo locally:
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#creating-updating-and-modifying-packages-in-void-by-yourself

Then do:
```
git config --global user.name "YOUR_NAME"
git config --global user.email "YOUR_EMAIL"
git checkout patch-5
git commit --amend --reset-author
git push -f
```

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: valgrind: preserve debug symbols
  2024-01-30 20:56 [PR PATCH] Update template to preserve debug symbols sbromberger
  2024-01-30 21:19 ` valgrind: " oreo639
@ 2024-02-05  5:44 ` oreo639
  2024-02-15  3:51 ` [PR PATCH] [Closed]: " classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: oreo639 @ 2024-02-05  5:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/48448#issuecomment-1917912408

Comment:
You need to fix the commit message and author email.

You can do this by cloning the repo locally:
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#creating-updating-and-modifying-packages-in-void-by-yourself

Then do:
```
git config --global user.name "YOUR_NAME"
git config --global user.email "YOUR_EMAIL"
git checkout patch-5
git commit --amend --reset-author
git push -f
```

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: valgrind: preserve debug symbols
  2024-01-30 20:56 [PR PATCH] Update template to preserve debug symbols sbromberger
  2024-01-30 21:19 ` valgrind: " oreo639
  2024-02-05  5:44 ` valgrind: " oreo639
@ 2024-02-15  3:51 ` classabbyamp
  2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2024-02-15  3:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

There's a closed pull request on the void-packages repository

valgrind: preserve debug symbols
https://github.com/void-linux/void-packages/pull/48448

Description:
Added `nostrip=yes` to preserve debug symbols, required for upstream bug submissions. Bumps revision to 3.22.0_2. Closes #48427.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 glibc (`Void 6.6.11_1 x86_64 AuthenticAMD uptodate rFFFF`)


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-15  3:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-30 20:56 [PR PATCH] Update template to preserve debug symbols sbromberger
2024-01-30 21:19 ` valgrind: " oreo639
2024-02-05  5:44 ` valgrind: " oreo639
2024-02-15  3:51 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).