[PR PATCH] nicotine+: update to 3.3.0.

[PR PATCH] nicotine+: update to 3.3.0.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

There is a new pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages nicotine-3.3.0
https://github.com/void-linux/void-packages/pull/48489

nicotine+: update to 3.3.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)
- Built locally for:
  - `i686-glibc`


A patch file from https://github.com/void-linux/void-packages/pull/48489.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nicotine-3.3.0-48489.patch --]
[-- Type: text/x-diff, Size: 1317 bytes --]

From a9b2ed9855eab026242cf9c1018554c27d011811 Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Thu, 1 Feb 2024 21:50:11 -0500
Subject: [PATCH] nicotine+: update to 3.3.0.

---
 srcpkgs/nicotine+/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/nicotine+/template b/srcpkgs/nicotine+/template
index 133d36a154f8c..b57e1e7ce9a34 100644
--- a/srcpkgs/nicotine+/template
+++ b/srcpkgs/nicotine+/template
@@ -1,10 +1,10 @@
 # Template file for 'nicotine+'
 pkgname=nicotine+
-version=3.2.9
-revision=2
+version=3.3.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools gettext"
-depends="gspell gtk+3 python3-gobject"
+depends="gspell gtk4 python3-gobject"
 checkdepends="$depends python3-pytest python3-pytest-xvfb"
 short_desc="Graphical client for the Soulseek peer-to-peer network"
 maintainer="doggone <doggone@airmail.cc>"
@@ -12,4 +12,4 @@ license="GPL-3.0-or-later"
 homepage="https://nicotine-plus.org"
 changelog="https://raw.githubusercontent.com/nicotine-plus/nicotine-plus/master/NEWS.md"
 distfiles="https://github.com/Nicotine-Plus/nicotine-plus/archive/${version}.tar.gz"
-checksum=aeaf45742a915345d1635f36ca334c3f332788c7a27262408be9998985f99e41
+checksum=c94bd7ecf6a107445836df80efed9b8c18cab307d812c2b91be18e93dfb4ac1f

Re: [PR REVIEW] nicotine+: update to 3.3.0.

[mathiascode]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by mathiascode on void-packages repository

https://github.com/void-linux/void-packages/pull/48489#discussion_r1475487595

Comment:
gspell is no longer used (only compatible with GTK 3)

Re: [PR PATCH] [Updated] nicotine+: update to 3.3.0.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

There is an updated pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages nicotine-3.3.0
https://github.com/void-linux/void-packages/pull/48489

nicotine+: update to 3.3.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)
- Built locally for:
  - `i686-glibc`


A patch file from https://github.com/void-linux/void-packages/pull/48489.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nicotine-3.3.0-48489.patch --]
[-- Type: text/x-diff, Size: 1310 bytes --]

From f8d77250db50ab839de30ff210cadc37bb992faf Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Thu, 1 Feb 2024 21:50:11 -0500
Subject: [PATCH] nicotine+: update to 3.3.0.

---
 srcpkgs/nicotine+/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/nicotine+/template b/srcpkgs/nicotine+/template
index 133d36a154f8c..f207ed87914b5 100644
--- a/srcpkgs/nicotine+/template
+++ b/srcpkgs/nicotine+/template
@@ -1,10 +1,10 @@
 # Template file for 'nicotine+'
 pkgname=nicotine+
-version=3.2.9
-revision=2
+version=3.3.0
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools gettext"
-depends="gspell gtk+3 python3-gobject"
+depends="gtk4 python3-gobject"
 checkdepends="$depends python3-pytest python3-pytest-xvfb"
 short_desc="Graphical client for the Soulseek peer-to-peer network"
 maintainer="doggone <doggone@airmail.cc>"
@@ -12,4 +12,4 @@ license="GPL-3.0-or-later"
 homepage="https://nicotine-plus.org"
 changelog="https://raw.githubusercontent.com/nicotine-plus/nicotine-plus/master/NEWS.md"
 distfiles="https://github.com/Nicotine-Plus/nicotine-plus/archive/${version}.tar.gz"
-checksum=aeaf45742a915345d1635f36ca334c3f332788c7a27262408be9998985f99e41
+checksum=c94bd7ecf6a107445836df80efed9b8c18cab307d812c2b91be18e93dfb4ac1f

Re: [PR REVIEW] nicotine+: update to 3.3.0.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New review comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/48489#discussion_r1475491975

Comment:
thanks

Re: nicotine+: update to 3.3.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48489#issuecomment-1922857479

Comment:
it seems all the icons and translation files moved from `/usr/share` to inside site-packages

Re: nicotine+: update to 3.3.0.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by yoshiyoshyosh on void-packages repository

https://github.com/void-linux/void-packages/pull/48489#issuecomment-1922890926

Comment:
> it seems all the icons and translation files moved from `/usr/share` to inside site-packages

is this necessarily a bad thing?

Re: nicotine+: update to 3.3.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48489#issuecomment-1923008074

Comment:
if they don't get used by the application, yes

Re: nicotine+: update to 3.3.0.

[mathiascode]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

New comment by mathiascode on void-packages repository

https://github.com/void-linux/void-packages/pull/48489#issuecomment-1924024477

Comment:
> it seems all the icons and translation files moved from `/usr/share` to inside site-packages

Private, unthemable icons did indeed move to site-packages, but icons that are used by the system (such as launcher and tray icons) are still located in /usr/share/icons.

Translation files were also moved to simplify i18n-related code for e.g. Flatpak, but if it turns out distros have issues with this, they could be moved back in a future release. 

Re: [PR PATCH] [Updated] nicotine+: update to 3.3.0.

[yoshiyoshyosh]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

There is an updated pull request by yoshiyoshyosh against master on the void-packages repository

https://github.com/yoshiyoshyosh/void-packages nicotine-3.3.0
https://github.com/void-linux/void-packages/pull/48489

nicotine+: update to 3.3.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)
- Built locally for:
  - `i686-glibc`


A patch file from https://github.com/void-linux/void-packages/pull/48489.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nicotine-3.3.0-48489.patch --]
[-- Type: text/x-diff, Size: 1312 bytes --]

From 1b914eed27f67e1f00155f0431cb8e71e4e8bdfd Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Thu, 1 Feb 2024 21:50:11 -0500
Subject: [PATCH] nicotine+: update to 3.3.2.

---
 srcpkgs/nicotine+/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/nicotine+/template b/srcpkgs/nicotine+/template
index 133d36a154f8c6..d1f2eef4aea815 100644
--- a/srcpkgs/nicotine+/template
+++ b/srcpkgs/nicotine+/template
@@ -1,10 +1,10 @@
 # Template file for 'nicotine+'
 pkgname=nicotine+
-version=3.2.9
-revision=2
+version=3.3.2
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools gettext"
-depends="gspell gtk+3 python3-gobject"
+depends="gtk4 python3-gobject"
 checkdepends="$depends python3-pytest python3-pytest-xvfb"
 short_desc="Graphical client for the Soulseek peer-to-peer network"
 maintainer="doggone <doggone@airmail.cc>"
@@ -12,4 +12,4 @@ license="GPL-3.0-or-later"
 homepage="https://nicotine-plus.org"
 changelog="https://raw.githubusercontent.com/nicotine-plus/nicotine-plus/master/NEWS.md"
 distfiles="https://github.com/Nicotine-Plus/nicotine-plus/archive/${version}.tar.gz"
-checksum=aeaf45742a915345d1635f36ca334c3f332788c7a27262408be9998985f99e41
+checksum=1399e8edad1212ca17fdf4a44ab9975c195a57b269c16194e4f06a27d9d3d31a