[PR PATCH] Explain ./xbps-src binary-bootstrap

[PR PATCH] Explain ./xbps-src binary-bootstrap

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

There is a new pull request by melroy89 against master on the void-packages repository

https://github.com/melroy89/void-packages patch-1
https://github.com/void-linux/void-packages/pull/48636

Explain ./xbps-src binary-bootstrap
It's not a package change, it's a script change. Explain existence of the: `./xbps-src binary-bootstrap` command.

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/48636.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-48636.patch --]
[-- Type: text/x-diff, Size: 1141 bytes --]

From 43fde5cf51299134400584b7a24946d109fdf886 Mon Sep 17 00:00:00 2001
From: Melroy van den Berg <melroy@melroy.org>
Date: Sat, 10 Feb 2024 05:16:42 +0100
Subject: [PATCH] Explain ./xbps-src binary-bootstrap

If users forgot to run this command (I did lol). You could explain them to try to run this command: `./xbps-src binary-bootstrap`
---
 common/xbps-src/shutils/common.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/common.sh b/common/xbps-src/shutils/common.sh
index 4083e08ee084f..e44a25d80e749 100644
--- a/common/xbps-src/shutils/common.sh
+++ b/common/xbps-src/shutils/common.sh
@@ -496,7 +496,7 @@ setup_pkg() {
     # Check if base-chroot is already installed.
     if [ -z "$bootstrap" -a -z "$CHROOT_READY" -a "z$show_problems" != "zignore-problems" ]; then
         msg_red "${pkg} is not a bootstrap package and cannot be built without it.\n"
-        msg_error "Please install bootstrap packages and try again.\n"
+        msg_error "Please install bootstrap packages and try again. Run for example first: ./xbps-src binary-bootstrap\n"
     fi
 
     sourcepkg="${pkgname}"

Re: Explain ./xbps-src binary-bootstrap

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48636#issuecomment-1936854468

Comment:
I have a WIP patch that automatically `binary-bootstrap`s on certain operations where this error could happen

Re: Explain ./xbps-src binary-bootstrap

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/48636#issuecomment-1936854468

Comment:
I have a WIP patch that automatically `binary-bootstrap`s on certain operations where this error could happen that might eliminate the need for this error message

Re: [PR PATCH] [Updated] Explain ./xbps-src binary-bootstrap

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

There is an updated pull request by melroy89 against master on the void-packages repository

https://github.com/melroy89/void-packages patch-1
https://github.com/void-linux/void-packages/pull/48636

Explain ./xbps-src binary-bootstrap
It's not a package change, it's a script change. Explain existence of the: `./xbps-src binary-bootstrap` command.

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/48636.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-48636.patch --]
[-- Type: text/x-diff, Size: 1039 bytes --]

From 52486c6e5a967415095c6a05a81fafba85bd8b4b Mon Sep 17 00:00:00 2001
From: Melroy van den Berg <melroy@melroy.org>
Date: Sat, 10 Feb 2024 18:57:27 +0100
Subject: [PATCH] xbps-src: Add xbps-src: binary-bootstrap to the error message

---
 common/xbps-src/shutils/common.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/common.sh b/common/xbps-src/shutils/common.sh
index 4083e08ee084ff..e44a25d80e7495 100644
--- a/common/xbps-src/shutils/common.sh
+++ b/common/xbps-src/shutils/common.sh
@@ -496,7 +496,7 @@ setup_pkg() {
     # Check if base-chroot is already installed.
     if [ -z "$bootstrap" -a -z "$CHROOT_READY" -a "z$show_problems" != "zignore-problems" ]; then
         msg_red "${pkg} is not a bootstrap package and cannot be built without it.\n"
-        msg_error "Please install bootstrap packages and try again.\n"
+        msg_error "Please install bootstrap packages and try again. Run for example first: ./xbps-src binary-bootstrap\n"
     fi
 
     sourcepkg="${pkgname}"

Re: [PR PATCH] [Closed]: Explain ./xbps-src binary-bootstrap

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

There's a closed pull request on the void-packages repository

Explain ./xbps-src binary-bootstrap
https://github.com/void-linux/void-packages/pull/48636

Description:
It's not a package change, it's a script change. Explain existence of the: `./xbps-src binary-bootstrap` command.

#### Testing the changes
- I tested the changes in this PR: **YES**

Re: Explain ./xbps-src binary-bootstrap

[melroy89]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by melroy89 on void-packages repository

https://github.com/void-linux/void-packages/pull/48636#issuecomment-1944482502

Comment:
> I have a WIP patch that automatically `binary-bootstrap`s on certain operations where this error could happen that might eliminate the need for this error message

OK Clear. assuming your PR will be actually merged... Then I will close this PR for now.