Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] telegram-desktop: remove unused makedeps
@ 2024-02-25  9:47 oreo639
  2024-02-25 12:24 ` [PR PATCH] [Merged]: " oreo639
  0 siblings, 1 reply; 2+ messages in thread
From: oreo639 @ 2024-02-25  9:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages telegram-desktop
https://github.com/void-linux/void-packages/pull/48924

telegram-desktop: remove unused makedeps
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

@Johnnynator webkit2gtk currently is not a rundep for `telegram-desktop` package.

Would you like it to stay that way (since there are multiple versions of webkit2gtk and if you don't have it installed telegram-desktop displays a message telling you to install it), otherwise I can add either libwebkitgtk60 or libwebkit2gtk41, either are supported: https://github.com/desktop-app/lib_webview/blob/4fce8b1971721da739619acf36da0fe79d614a23/webview/platform/linux/webview_linux_webkitgtk_library.cpp#L14-L16

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48924.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-telegram-desktop-48924.patch --]
[-- Type: text/x-diff, Size: 1767 bytes --]

From 0a1d6d75b7835f0555c8c33d487852b1c807b6f5 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Sun, 25 Feb 2024 01:31:43 -0800
Subject: [PATCH] telegram-desktop: remove unused makedeps

gtk+3 used to be needed for the gtk filechooser, but doesn't appear to be
used anymore.

webkit2gtk is not needed at build time and is dlopen()'d at runtime.
---
 srcpkgs/telegram-desktop/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/telegram-desktop/template b/srcpkgs/telegram-desktop/template
index 53d89aad23ba8..6dc6a553cfcec 100644
--- a/srcpkgs/telegram-desktop/template
+++ b/srcpkgs/telegram-desktop/template
@@ -1,7 +1,7 @@
 # Template file for 'telegram-desktop'
 pkgname=telegram-desktop
 version=4.14.15
-revision=2
+revision=3
 build_style=cmake
 build_helper="qemu gir"
 configure_args="-DTDESKTOP_API_ID=209235
@@ -14,10 +14,10 @@ hostmakedepends="pkg-config qt6-base python3 extra-cmake-modules
  qt6-wayland-tools wayland-devel protobuf"
 makedepends="alsa-lib-devel boost-devel fmt-devel ffmpeg-devel gobject-introspection libdbusmenu-glib-devel libopenal-devel
  minizip-devel opus-devel xxHash-devel pulseaudio-devel range-v3
- qt6-svg-devel libva-devel rapidjson liblz4-devel liblzma-devel gtk+3-devel
+ qt6-svg-devel libva-devel rapidjson liblz4-devel liblzma-devel
  MesaLib-devel qt6-wayland-devel qt6-qt5compat-devel
  xcb-util-keysyms-devel $(vopt_if spellcheck hunspell-devel) protobuf-devel
- glibmm2.68-devel tg_owt webkit2gtk-devel rnnoise-devel jemalloc-devel qt6-declarative-devel"
+ glibmm2.68-devel tg_owt rnnoise-devel jemalloc-devel qt6-declarative-devel"
 depends="qt6-imageformats ttf-opensans"
 short_desc="Telegram Desktop messaging app"
 maintainer="John <me@johnnynator.dev>"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: telegram-desktop: remove unused makedeps
  2024-02-25  9:47 [PR PATCH] telegram-desktop: remove unused makedeps oreo639
@ 2024-02-25 12:24 ` oreo639
  0 siblings, 0 replies; 2+ messages in thread
From: oreo639 @ 2024-02-25 12:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There's a merged pull request on the void-packages repository

telegram-desktop: remove unused makedeps
https://github.com/void-linux/void-packages/pull/48924

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

@Johnnynator webkit2gtk currently is not a rundep for `telegram-desktop` package.

Would you like it to stay that way (since there are multiple versions of webkit2gtk and if you don't have it installed telegram-desktop displays a message telling you to install it), otherwise I can add either libwebkitgtk60 or libwebkit2gtk41, either are supported: https://github.com/desktop-app/lib_webview/blob/4fce8b1971721da739619acf36da0fe79d614a23/webview/platform/linux/webview_linux_webkitgtk_library.cpp#L14-L16

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-25 12:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-25  9:47 [PR PATCH] telegram-desktop: remove unused makedeps oreo639
2024-02-25 12:24 ` [PR PATCH] [Merged]: " oreo639

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).