[PR PATCH] common/shlibs: add missing shlibs

[PR PATCH] common/shlibs: add missing shlibs

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

There is a new pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages shlibs
https://github.com/void-linux/void-packages/pull/49003

common/shlibs: add missing shlibs
#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/49003.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shlibs-49003.patch --]
[-- Type: text/x-diff, Size: 775 bytes --]

From decac8d85b82517af0a71d33f779565406c2b07a Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Thu, 29 Feb 2024 15:28:22 +0300
Subject: [PATCH] common/shlibs: add missing shlibs

---
 common/shlibs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/shlibs b/common/shlibs
index 44c8b34a3482ea..625ea471555862 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4281,3 +4281,8 @@ libunicode_ucd.so.0.4 libunicode-0.4.0_1
 libunicode_loader.so.0.4 libunicode-0.4.0_1
 force-stage.so.0.1 void-force-stage-0.1_1
 libliftoff.so.0 libliftoff-0.4.1_1
+libfwupd.so.2 fwupd-1.9.12_1
+libgstplay-1.0.so.0 gst-plugins-bad1-1.22.9_1
+libgstrtspserver-1.0.so.0 gst-rtsp-server-1.22.9_1
+libzopfli.so.1 zopfli-1.0.3_2
+libzopflipng.so.1 zopfli-1.0.3_2

Re: common/shlibs: add missing shlibs

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/49003#issuecomment-1971449599

Comment:
What package fails to build due to lack of these entries?

Re: common/shlibs: add missing shlibs

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/49003#issuecomment-1971793141

Comment:
Those that depend on those shlibs. From my private repo. Why does it matter?

`fwupd`, `gst-plugins-bad1`, `gst-rtsp-server`, `zopfli` are in the official repo, and provide the shared libs which need to be in the `common/shlibs` file. 

Re: common/shlibs: add missing shlibs

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/49003#issuecomment-1971843546

Comment:
> provide the shared libs which need to be in the `common/shlibs`

Wrong assumption, we usually do not list shared libs in `shlibs` unless used by other package.

> Why does it matter?

Packages would likely need a revbump, and you added none in the PR what raised my question.

> From my private repo.

Enough for me, but I'll like to hear opinion from other maintainers.

Re: common/shlibs: add missing shlibs

[abenson]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/49003#issuecomment-1971851998

Comment:
If these entries aren't needed for anything else that currently exists in `void-packages`, they can live on the same branch as your custom templates.

Additionally, these are unrelated to each other, and each one should be located within the file next to their similar entries (i.e. keep entries for `gst-plugins-bad1` with the existing entries for `gst-plugins-bad1`.

Re: [PR PATCH] [Closed]: common/shlibs: add missing shlibs

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

There's a closed pull request on the void-packages repository

common/shlibs: add missing shlibs
https://github.com/void-linux/void-packages/pull/49003

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**