* [PR PATCH] dooble: add dictionaries.
@ 2024-03-04 11:29 Eloitor
2024-03-10 15:11 ` [PR PATCH] [Updated] [WIP] " Eloitor
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eloitor @ 2024-03-04 11:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
There is a new pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/49075
dooble: add dictionaries.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
closes #49030
A patch file from https://github.com/void-linux/void-packages/pull/49075.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-49075.patch --]
[-- Type: text/x-diff, Size: 1770 bytes --]
From edfc64c66cce66e75827ddafd99637b8b6d42dcc Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Mon, 4 Mar 2024 13:27:30 +0100
Subject: [PATCH] dooble: add dictionaries.
---
srcpkgs/dooble/patches/dictionaries.patch | 11 +++++++++++
srcpkgs/dooble/template | 4 +++-
2 files changed, 14 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/dooble/patches/dictionaries.patch
diff --git a/srcpkgs/dooble/patches/dictionaries.patch b/srcpkgs/dooble/patches/dictionaries.patch
new file mode 100644
index 00000000000000..c153468928b81d
--- /dev/null
+++ b/srcpkgs/dooble/patches/dictionaries.patch
@@ -0,0 +1,11 @@
+--- a/Source/dooble_settings.cc
++++ b/Source/dooble_settings.cc
+@@ -2271,7 +2271,7 @@ void dooble_settings::show_qtwebengine_dictionaries_warning_label(void)
+
+ if(bytes.trimmed().isEmpty())
+ {
+- bytes = "qtwebengine_dictionaries";
++ bytes = "/usr/share/dooble/qtwebengine_dictionaries";
+
+ if(!QFileInfo(bytes).isReadable())
+ {
diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
index 9c4933e551a356..8175bcbbd718b7 100644
--- a/srcpkgs/dooble/template
+++ b/srcpkgs/dooble/template
@@ -1,7 +1,7 @@
# Template file for 'dooble'
pkgname=dooble
version=2024.01.25
-revision=1
+revision=2
archs="x86_64* aarch64*"
build_style=qmake
configure_args="dooble.pro"
@@ -19,6 +19,8 @@ do_install() {
vbin Dooble dooble
vinstall Distributions/dooble.desktop 644 usr/share/applications
vinstall Icons/Logo/dooble.png 644 usr/share/pixmaps
+ vmkdir usr/share/dooble/qtwebengine_dictionaries
+ vcopy qtwebengine_dictionaries usr/share/dooble
vmkdir usr/share/dooble/translations
vcopy "Translations/dooble_*.qm" usr/share/dooble/translations
vlicense LICENSE
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PR PATCH] [Updated] [WIP] dooble: add dictionaries.
2024-03-04 11:29 [PR PATCH] dooble: add dictionaries Eloitor
@ 2024-03-10 15:11 ` Eloitor
2024-03-10 17:29 ` [PR PATCH] [Updated] " Eloitor
2024-03-10 17:30 ` Eloitor
2 siblings, 0 replies; 4+ messages in thread
From: Eloitor @ 2024-03-10 15:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/49075
[WIP] dooble: add dictionaries.
#### Testing the changes
- I tested the changes in this PR: **YES**
(Dooble finds them, but QT doesn't... See https://github.com/textbrowser/dooble/issues/222)
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
closes #49030
A patch file from https://github.com/void-linux/void-packages/pull/49075.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-49075.patch --]
[-- Type: text/x-diff, Size: 2033 bytes --]
From 6c5f0e15ac88e0f02ecf80b0b33b6da63a5fac1e Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Mon, 4 Mar 2024 13:27:30 +0100
Subject: [PATCH] dooble: add dictionaries and translations.
---
srcpkgs/dooble/patches/dictionaries.patch | 11 +++++++++++
srcpkgs/dooble/template | 4 ++--
2 files changed, 13 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/dooble/patches/dictionaries.patch
diff --git a/srcpkgs/dooble/patches/dictionaries.patch b/srcpkgs/dooble/patches/dictionaries.patch
new file mode 100644
index 00000000000000..f8bf80ee34466b
--- /dev/null
+++ b/srcpkgs/dooble/patches/dictionaries.patch
@@ -0,0 +1,11 @@
+--- a/Source/dooble_settings.cc
++++ b/Source/dooble_settings.cc
+@@ -2271,7 +2271,7 @@ void dooble_settings::show_qtwebengine_dictionaries_warning_label(void)
+
+ if(bytes.trimmed().isEmpty())
+ {
+- bytes = "qtwebengine_dictionaries";
++ bytes = "/usr/share/qt6/qtwebengine_dictionaries";
+
+ if(!QFileInfo(bytes).isReadable())
+ {
diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
index 9c4933e551a356..c33baca5e05f67 100644
--- a/srcpkgs/dooble/template
+++ b/srcpkgs/dooble/template
@@ -1,13 +1,13 @@
# Template file for 'dooble'
pkgname=dooble
version=2024.01.25
-revision=1
+revision=2
archs="x86_64* aarch64*"
build_style=qmake
configure_args="dooble.pro"
hostmakedepends="qt6-webengine qt6-declarative-devel"
makedepends="qt6-charts-devel qt6-webengine-devel qt6-webchannel-devel qt6-location-devel qt6-charts-devel qt6-wayland python3-QtPy"
-depends="qt6-charts qt6-core qt6-declarative qt6-gui qt6-network qt6-plugin-sqlite qt6-printsupport qt6-sql qt6-webengine qt6-widgets"
+depends="qt6-charts qt6-core qt6-declarative qt6-gui qt6-network qt6-plugin-sqlite qt6-printsupport qt6-sql qt6-webengine qt6-widgets libreoffice-qtwebengine-dict"
short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
maintainer="Eloi Torrents <eloitor@disroot.org>"
license="BSD-3-Clause"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PR PATCH] [Updated] dooble: add dictionaries
2024-03-04 11:29 [PR PATCH] dooble: add dictionaries Eloitor
2024-03-10 15:11 ` [PR PATCH] [Updated] [WIP] " Eloitor
@ 2024-03-10 17:29 ` Eloitor
2024-03-10 17:30 ` Eloitor
2 siblings, 0 replies; 4+ messages in thread
From: Eloitor @ 2024-03-10 17:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/49075
dooble: add dictionaries
#### Testing the changes
- I tested the changes in this PR: **YES**
(Dooble finds them, but QT doesn't... See https://github.com/textbrowser/dooble/issues/222)
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
closes #49030
A patch file from https://github.com/void-linux/void-packages/pull/49075.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-49075.patch --]
[-- Type: text/x-diff, Size: 2016 bytes --]
From 1e7f965935f71d1d7ddc1b4c11d4a766724b088d Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Mon, 4 Mar 2024 13:27:30 +0100
Subject: [PATCH] dooble: add dictionaries.
---
srcpkgs/dooble/patches/dictionaries.patch | 11 +++++++++++
srcpkgs/dooble/template | 4 ++--
2 files changed, 13 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/dooble/patches/dictionaries.patch
diff --git a/srcpkgs/dooble/patches/dictionaries.patch b/srcpkgs/dooble/patches/dictionaries.patch
new file mode 100644
index 00000000000000..f8bf80ee34466b
--- /dev/null
+++ b/srcpkgs/dooble/patches/dictionaries.patch
@@ -0,0 +1,11 @@
+--- a/Source/dooble_settings.cc
++++ b/Source/dooble_settings.cc
+@@ -2271,7 +2271,7 @@ void dooble_settings::show_qtwebengine_dictionaries_warning_label(void)
+
+ if(bytes.trimmed().isEmpty())
+ {
+- bytes = "qtwebengine_dictionaries";
++ bytes = "/usr/share/qt6/qtwebengine_dictionaries";
+
+ if(!QFileInfo(bytes).isReadable())
+ {
diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
index 9c4933e551a356..c33baca5e05f67 100644
--- a/srcpkgs/dooble/template
+++ b/srcpkgs/dooble/template
@@ -1,13 +1,13 @@
# Template file for 'dooble'
pkgname=dooble
version=2024.01.25
-revision=1
+revision=2
archs="x86_64* aarch64*"
build_style=qmake
configure_args="dooble.pro"
hostmakedepends="qt6-webengine qt6-declarative-devel"
makedepends="qt6-charts-devel qt6-webengine-devel qt6-webchannel-devel qt6-location-devel qt6-charts-devel qt6-wayland python3-QtPy"
-depends="qt6-charts qt6-core qt6-declarative qt6-gui qt6-network qt6-plugin-sqlite qt6-printsupport qt6-sql qt6-webengine qt6-widgets"
+depends="qt6-charts qt6-core qt6-declarative qt6-gui qt6-network qt6-plugin-sqlite qt6-printsupport qt6-sql qt6-webengine qt6-widgets libreoffice-qtwebengine-dict"
short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
maintainer="Eloi Torrents <eloitor@disroot.org>"
license="BSD-3-Clause"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: dooble: add dictionaries
2024-03-04 11:29 [PR PATCH] dooble: add dictionaries Eloitor
2024-03-10 15:11 ` [PR PATCH] [Updated] [WIP] " Eloitor
2024-03-10 17:29 ` [PR PATCH] [Updated] " Eloitor
@ 2024-03-10 17:30 ` Eloitor
2 siblings, 0 replies; 4+ messages in thread
From: Eloitor @ 2024-03-10 17:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New comment by Eloitor on void-packages repository
https://github.com/void-linux/void-packages/pull/49075#issuecomment-1987303030
Comment:
Now it is ready to be merged.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-10 17:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-04 11:29 [PR PATCH] dooble: add dictionaries Eloitor
2024-03-10 15:11 ` [PR PATCH] [Updated] [WIP] " Eloitor
2024-03-10 17:29 ` [PR PATCH] [Updated] " Eloitor
2024-03-10 17:30 ` Eloitor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).