[PR PATCH] vpsm: remove package

[PR PATCH] vpsm: remove package

[meator]

[-- Attachment #1: Type: text/plain, Size: 3347 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages vpsm
https://github.com/void-linux/void-packages/pull/49353

vpsm: remove package
I have created this PR because of https://www.reddit.com/r/voidlinux/comments/1bgdi51/recommend_way_to_update_xbpssrc_packages/

vpsm's latest commit has been made five years ago. I've reviewed the script, and it seems that everything is still functioning correctly. However, there's a possibility that any future changes to `xbps-src` could potentially break vpsm.

One might argue that this doesn't matter because it's not broken (yet). One could say that vpsm is feature complete and it doesn't need any updates. But it appears to me as though it has been abandoned.

vpsm isn't compiled, no packages require it and it doesn't need to be system installed. It therefore meets none of the quality requirements.

I personally hate these wrapper scripts because they do not provide any value of their own. vpsm doesn't really combine `xtools`, `xbps-src` and `git` to produce something, it just executes the appropriate commands 1:1. For example, `vpsm update-sys` = `./xbps-src update-sys`, `vpsm show-deps` = `./xbps-src show-deps`, `vpsm push-commit`
 = `git push -u` etc.

This "hides the truth" from the user. Instead of using official, documented commands, `vpsm` users are encouraged to use `vpsm` (which uses those official commands) which adds an unnecessary layer of abstraction. Using official, documented commands should be preferred in my opinion.

But it isn't always 1:1. Users of vpsm might be surprised to find out[^1] that `vpsm build-environment` uses `XBPS_CHROOT_CMD=uchroot`, which is not the default way `xbps-src` is used. vpsm does special setup for this which requires superuser privileges, but it isn't properly documented. It also sets the set user ID bit on `xbps-uchroot`, which really should be documented. All of this shouldn't even happen in the first place, because `xbps-uchroot` has the right permissions set by default.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

[^1]: `vpsm` echos the commands used to set up the build environment, so the user will be made aware that `XBPS_CHROOT_CMD=uchroot` is used. However, I don't see it documented anywhere. Figuring this out as the commands are being run is too late.

A patch file from https://github.com/void-linux/void-packages/pull/49353.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vpsm-49353.patch --]
[-- Type: text/x-diff, Size: 2352 bytes --]

From 8eb5ae21b41d1fec9dedb0085dcd81b78e58af16 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Mon, 18 Mar 2024 15:28:38 +0100
Subject: [PATCH] vpsm: remove package

Project appears to be dead, latest commit was made 5 years ago and vpsm
doesn't meet quality requirements.
---
 srcpkgs/removed-packages/template     |  1 +
 srcpkgs/vpsm/patches/setuid-fix.patch | 19 -------------------
 srcpkgs/vpsm/template                 | 16 ----------------
 3 files changed, 1 insertion(+), 35 deletions(-)
 delete mode 100644 srcpkgs/vpsm/patches/setuid-fix.patch
 delete mode 100644 srcpkgs/vpsm/template

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 3be0b39d23945d..2dc5410097e6de 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -691,6 +691,7 @@ replaces="
  vkd3d<=1.3_1
  volnoti<=0.1_1
  volume_key-python<=0.3.12_5
+ vpsm<=vpsm-0.1.2_2
  vte-devel<=0.28.2_16
  vte-python<=0.28.2_16
  vte290-devel<=0.36.5_5
diff --git a/srcpkgs/vpsm/patches/setuid-fix.patch b/srcpkgs/vpsm/patches/setuid-fix.patch
deleted file mode 100644
index 3a2ec1a1c40559..00000000000000
--- a/srcpkgs/vpsm/patches/setuid-fix.patch
+++ /dev/null
@@ -1,19 +0,0 @@
-Do not apply the setuid permission bit on the vpsm script
-
-See https://github.com/void-linux/void-packages/issues/32156
-see https://github.com/sineto/vpsm/pull/2
-
-
---
-
---- a/Makefile
-+++ b/Makefile
-@@ -16,7 +16,7 @@
- 
- .PHONY: install
- install:
--	install -Dm4755 vpsm $(DESTDIR)$(PREFIX)/bin/vpsm
-+	install -Dm755 vpsm $(DESTDIR)$(PREFIX)/bin/vpsm
- 	install -Dm644 man/vpsm.1 $(DESTDIR)/$(PREFIX)/share/man/man1/vpsm.1
- 
- .PHONY: uninstall
diff --git a/srcpkgs/vpsm/template b/srcpkgs/vpsm/template
deleted file mode 100644
index ead8e89e6ba84c..00000000000000
--- a/srcpkgs/vpsm/template
+++ /dev/null
@@ -1,16 +0,0 @@
-# Template file for 'vpsm'
-pkgname=vpsm
-version=0.1.2
-revision=2
-build_style=gnu-makefile
-depends="bash xtools ripgrep hub"
-short_desc="Void-Packages Sources Management wrapper for XBPS-SRC"
-maintainer="Sinésio Neto <sinetoami@gmail.com>"
-license="MIT"
-homepage="https://github.com/sineto/vpsm"
-distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=7317439096f56371397eb1250a81ff83e53740c14163993cf6668e9f0c4bdc2f
-
-post_install() {
-	vlicense LICENSE
-}

Re: vpsm: remove package

[meator]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/49353#issuecomment-2004334121

Comment:
Ping maintainer (and creator): @sinetoami, @sineto