[PR PATCH] New package: duckdb-0.10.1

[PR PATCH] New package: duckdb-0.10.1

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages duckdb
https://github.com/void-linux/void-packages/pull/49367

New package: duckdb-0.10.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/49367.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-duckdb-49367.patch --]
[-- Type: text/x-diff, Size: 2577 bytes --]

From 8f318d1c416d1969fc9472b28181918869f43e06 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 4 Apr 2023 21:41:12 +0530
Subject: [PATCH] New package: duckdb-0.10.1

---
 srcpkgs/duckdb-devel    |  1 +
 srcpkgs/duckdb/template | 51 +++++++++++++++++++++++++++++++++++++++++
 srcpkgs/python3-duckdb  |  1 +
 3 files changed, 53 insertions(+)
 create mode 120000 srcpkgs/duckdb-devel
 create mode 100644 srcpkgs/duckdb/template
 create mode 120000 srcpkgs/python3-duckdb

diff --git a/srcpkgs/duckdb-devel b/srcpkgs/duckdb-devel
new file mode 120000
index 00000000000000..3da59dfc722faf
--- /dev/null
+++ b/srcpkgs/duckdb-devel
@@ -0,0 +1 @@
+duckdb
\ No newline at end of file
diff --git a/srcpkgs/duckdb/template b/srcpkgs/duckdb/template
new file mode 100644
index 00000000000000..c4817b07747433
--- /dev/null
+++ b/srcpkgs/duckdb/template
@@ -0,0 +1,51 @@
+# Template file for 'duckdb'
+pkgname=duckdb
+version=0.10.1
+revision=1
+build_style=cmake
+build_helper="python3"
+configure_args="-DOVERRIDE_GIT_DESCRIBE=v${version}-0-gdeadbeeff
+ -DBUILD_EXTENSIONS='autocomplete;icu;fts;httpfs;json;parquet'"
+hostmakedepends="pkg-config python3-build python3-installer python3-setuptools_scm
+ python3-wheel python3-pybind11"
+makedepends="openssl-devel"
+short_desc="In-process SQL OLAP database management system"
+maintainer="icp <pangolin@vivaldi.net>"
+license="MIT"
+homepage="https://duckdb.org"
+changelog="https://github.com/duckdb/duckdb/releases"
+distfiles="https://github.com/duckdb/duckdb/archive/refs/tags/v${version}.tar.gz"
+checksum=83bd4944c070fd0bd287fbe62919fa887f35d7422ba0fa66e13d4ed098f3791a
+
+post_build() {
+	OVERRIDE_GIT_DESCRIBE="v${version}-0-gdeadbeeff" python3 -m build \
+		--no-isolation --wheel tools/pythonpkg
+}
+
+post_install() {
+	python3 -m installer --destdir "${DESTDIR}" --no-compile-bytecode \
+		tools/pythonpkg/dist/duckdb-${version}-*-*-*.whl
+
+	rm "${DESTDIR}/usr/"{includes,sources}.list
+	rm -r "${DESTDIR}/usr/duckdb_build"
+
+	vlicense LICENSE
+}
+
+duckdb-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/cmake
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+	}
+}
+
+python3-duckdb_package() {
+	short_desc+=" - python bindings"
+	pkg_install() {
+		vmove "${py3_sitelib}"
+	}
+}
diff --git a/srcpkgs/python3-duckdb b/srcpkgs/python3-duckdb
new file mode 120000
index 00000000000000..3da59dfc722faf
--- /dev/null
+++ b/srcpkgs/python3-duckdb
@@ -0,0 +1 @@
+duckdb
\ No newline at end of file

Re: [PR PATCH] [Updated] New package: duckdb-0.10.1

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages duckdb
https://github.com/void-linux/void-packages/pull/49367

New package: duckdb-0.10.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/49367.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-duckdb-49367.patch --]
[-- Type: text/x-diff, Size: 3389 bytes --]

From 36a73f63c498e95e2b62d25bc6565c68291ecda6 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 4 Apr 2023 21:41:12 +0530
Subject: [PATCH] New package: duckdb-0.10.1

---
 srcpkgs/duckdb-devel                  |  1 +
 srcpkgs/duckdb/patches/fix-musl.patch | 10 +++++
 srcpkgs/duckdb/template               | 57 +++++++++++++++++++++++++++
 srcpkgs/python3-duckdb                |  1 +
 4 files changed, 69 insertions(+)
 create mode 120000 srcpkgs/duckdb-devel
 create mode 100644 srcpkgs/duckdb/patches/fix-musl.patch
 create mode 100644 srcpkgs/duckdb/template
 create mode 120000 srcpkgs/python3-duckdb

diff --git a/srcpkgs/duckdb-devel b/srcpkgs/duckdb-devel
new file mode 120000
index 00000000000000..3da59dfc722faf
--- /dev/null
+++ b/srcpkgs/duckdb-devel
@@ -0,0 +1 @@
+duckdb
\ No newline at end of file
diff --git a/srcpkgs/duckdb/patches/fix-musl.patch b/srcpkgs/duckdb/patches/fix-musl.patch
new file mode 100644
index 00000000000000..6db141ef614ed1
--- /dev/null
+++ b/srcpkgs/duckdb/patches/fix-musl.patch
@@ -0,0 +1,10 @@
+--- a/tools/shell/linenoise/terminal.cpp
++++ b/tools/shell/linenoise/terminal.cpp
+@@ -10,6 +10,7 @@
+ #include <stdlib.h>
+ #include <ctype.h>
+ #include <sys/ioctl.h>
++#include <sys/select.h>
+ 
+ namespace duckdb {
+ 
diff --git a/srcpkgs/duckdb/template b/srcpkgs/duckdb/template
new file mode 100644
index 00000000000000..0955124e193955
--- /dev/null
+++ b/srcpkgs/duckdb/template
@@ -0,0 +1,57 @@
+# Template file for 'duckdb'
+pkgname=duckdb
+version=0.10.1
+revision=1
+archs="x86_64* aarch64*" # 32-bit FTBFS
+build_style=cmake
+build_helper="python3"
+configure_args="-DOVERRIDE_GIT_DESCRIBE=v${version}-0-gdeadbeeff
+ -DBUILD_EXTENSIONS='autocomplete;icu;fts;httpfs;json;parquet'"
+hostmakedepends="pkg-config python3-build python3-installer python3-setuptools_scm
+ python3-wheel python3-pybind11"
+makedepends="openssl-devel"
+short_desc="In-process SQL OLAP database management system"
+maintainer="icp <pangolin@vivaldi.net>"
+license="MIT"
+homepage="https://duckdb.org"
+changelog="https://github.com/duckdb/duckdb/releases"
+distfiles="https://github.com/duckdb/duckdb/archive/refs/tags/v${version}.tar.gz"
+checksum=83bd4944c070fd0bd287fbe62919fa887f35d7422ba0fa66e13d4ed098f3791a
+
+case "${XBPS_TARGET_MACHINE}" in
+	x86_64*) configure_args+=" -DDUCKDB_EXPLICIT_PLATFORM=linux_amd64" ;;
+	aarch64*) configure_args+=" -DDUCKDB_EXPLICIT_PLATFORM=linux_arm64" ;;
+esac
+
+post_build() {
+	OVERRIDE_GIT_DESCRIBE="v${version}-0-gdeadbeeff" python3 -m build \
+		--no-isolation --wheel tools/pythonpkg
+}
+
+post_install() {
+	python3 -m installer --destdir "${DESTDIR}" --no-compile-bytecode \
+		tools/pythonpkg/dist/duckdb-${version}-*-*-*.whl
+
+	rm "${DESTDIR}/usr/"{includes,sources}.list
+	rm -r "${DESTDIR}/usr/duckdb_build"
+
+	vlicense LICENSE
+}
+
+duckdb-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/cmake
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+	}
+}
+
+python3-duckdb_package() {
+	short_desc+=" - python bindings"
+	pkg_install() {
+		vmove "${py3_sitelib}"
+	}
+}
diff --git a/srcpkgs/python3-duckdb b/srcpkgs/python3-duckdb
new file mode 120000
index 00000000000000..3da59dfc722faf
--- /dev/null
+++ b/srcpkgs/python3-duckdb
@@ -0,0 +1 @@
+duckdb
\ No newline at end of file

Re: [PR REVIEW] New package: duckdb-0.10.1

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/49367#discussion_r1535836761

Comment:
just `v${version}` works here

Re: New package: duckdb-0.10.1

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/49367#issuecomment-2015439072

Comment:
I wonder if we can make duckdb and python3-duckdb use the libduckdb.so?

Re: [PR REVIEW] New package: duckdb-0.10.1

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49367#discussion_r1535897576

Comment:
yeah but they add [random stuff](https://github.com/duckdb/duckdb/blob/v0.10.1/CMakeLists.txt#L248-L259) anyway
clearly the [python counterpart](https://github.com/duckdb/duckdb/blob/v0.10.1/tools/pythonpkg/setup.py#L395) was written by someone else :smile: