Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: font-comic-mono-ttf-1.0
@ 2024-03-24 21:49 Zeitsperre
  2024-03-26 17:40 ` ahesford
  2024-03-27 16:20 ` Zeitsperre
  0 siblings, 2 replies; 3+ messages in thread
From: Zeitsperre @ 2024-03-24 21:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

There is a new pull request by Zeitsperre against master on the void-packages repository

https://github.com/Zeitsperre/void-packages font-comic-mono-ttf
https://github.com/void-linux/void-packages/pull/49515

New package: font-comic-mono-ttf-1.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-glibc)
- I built this PR for these architectures (cross-builds):
  - aarch64-musl
  - armv6l
  - armv7l
  - i686
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/49515.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-font-comic-mono-ttf-49515.patch --]
[-- Type: text/x-diff, Size: 4522 bytes --]

From 19e6107673e5ba6aa0ee80ebac4c5b626892e1ad Mon Sep 17 00:00:00 2001
From: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
Date: Sun, 24 Mar 2024 17:02:09 -0400
Subject: [PATCH 1/4] add comic mono template

---
 srcpkgs/comic-mono-ttf/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/comic-mono-ttf/template

diff --git a/srcpkgs/comic-mono-ttf/template b/srcpkgs/comic-mono-ttf/template
new file mode 100644
index 00000000000000..31fc66088a319e
--- /dev/null
+++ b/srcpkgs/comic-mono-ttf/template
@@ -0,0 +1,19 @@
+# Template file for 'font-comic-mono-ttf'
+pkgname=font-comic-mono-ttf
+version=1
+revision=0
+depends="font-util xbps-triggers"
+short_desc="Comic Sans-based monospace font, forked from Comic Shanns"
+maintainer="Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>"
+license="MIT"
+homepage="https://dtinth.github.io/comic-mono-font/"
+distfiles="https://github.com/dtinth/comic-mono-font/archive/refs/heads/master.tar.gz"
+checksum=19b280825653be975fae9f20f5cf48286e88166bf4185ffa3d5bdb03f7719083
+
+font_dirs="/usr/share/fonts/OTF"
+
+do_install() {
+	vmkdir usr/share/fonts/OTF
+	install -m644 *.ttf ${DESTDIR}/usr/share/fonts/OTF
+	vlicense LICENSE
+}

From ac02aec3a06e4d7578948e16a98fa3f55c2d4c1b Mon Sep 17 00:00:00 2001
From: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
Date: Sun, 24 Mar 2024 17:05:32 -0400
Subject: [PATCH 2/4] install in TTF folder

---
 srcpkgs/comic-mono-ttf/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/comic-mono-ttf/template b/srcpkgs/comic-mono-ttf/template
index 31fc66088a319e..a291b16de1dbdf 100644
--- a/srcpkgs/comic-mono-ttf/template
+++ b/srcpkgs/comic-mono-ttf/template
@@ -10,10 +10,10 @@ homepage="https://dtinth.github.io/comic-mono-font/"
 distfiles="https://github.com/dtinth/comic-mono-font/archive/refs/heads/master.tar.gz"
 checksum=19b280825653be975fae9f20f5cf48286e88166bf4185ffa3d5bdb03f7719083
 
-font_dirs="/usr/share/fonts/OTF"
+font_dirs="/usr/share/fonts/TTF"
 
 do_install() {
 	vmkdir usr/share/fonts/OTF
-	install -m644 *.ttf ${DESTDIR}/usr/share/fonts/OTF
+	install -m644 *.ttf ${DESTDIR}/usr/share/fonts/TTF
 	vlicense LICENSE
 }

From 657c241da24efe4f9120db6bca70c0d044073aef Mon Sep 17 00:00:00 2001
From: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
Date: Sun, 24 Mar 2024 17:17:19 -0400
Subject: [PATCH 3/4] finalize changes

---
 srcpkgs/{comic-mono-ttf => font-comic-mono-ttf}/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
 rename srcpkgs/{comic-mono-ttf => font-comic-mono-ttf}/template (82%)

diff --git a/srcpkgs/comic-mono-ttf/template b/srcpkgs/font-comic-mono-ttf/template
similarity index 82%
rename from srcpkgs/comic-mono-ttf/template
rename to srcpkgs/font-comic-mono-ttf/template
index a291b16de1dbdf..55c876858018b6 100644
--- a/srcpkgs/comic-mono-ttf/template
+++ b/srcpkgs/font-comic-mono-ttf/template
@@ -9,11 +9,10 @@ license="MIT"
 homepage="https://dtinth.github.io/comic-mono-font/"
 distfiles="https://github.com/dtinth/comic-mono-font/archive/refs/heads/master.tar.gz"
 checksum=19b280825653be975fae9f20f5cf48286e88166bf4185ffa3d5bdb03f7719083
-
-font_dirs="/usr/share/fonts/TTF"
+font_dirs="/usr/share/fonts/TTF/comic-mono"
 
 do_install() {
-	vmkdir usr/share/fonts/OTF
-	install -m644 *.ttf ${DESTDIR}/usr/share/fonts/TTF
+	vmkdir ${font_dirs}
+	vcopy '*.ttf' ${font_dirs}
 	vlicense LICENSE
 }

From aa6d1aa27c9c838f627592b8dadc32179b7a5b47 Mon Sep 17 00:00:00 2001
From: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
Date: Sun, 24 Mar 2024 17:42:10 -0400
Subject: [PATCH 4/4] linting

---
 srcpkgs/font-comic-mono-ttf/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/font-comic-mono-ttf/template b/srcpkgs/font-comic-mono-ttf/template
index 55c876858018b6..a8705311f0778d 100644
--- a/srcpkgs/font-comic-mono-ttf/template
+++ b/srcpkgs/font-comic-mono-ttf/template
@@ -1,10 +1,10 @@
 # Template file for 'font-comic-mono-ttf'
 pkgname=font-comic-mono-ttf
 version=1
-revision=0
+revision=1
 depends="font-util xbps-triggers"
 short_desc="Comic Sans-based monospace font, forked from Comic Shanns"
-maintainer="Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>"
+maintainer="Trevor James Smith <trevor_smith@live.com>"
 license="MIT"
 homepage="https://dtinth.github.io/comic-mono-font/"
 distfiles="https://github.com/dtinth/comic-mono-font/archive/refs/heads/master.tar.gz"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New package: font-comic-mono-ttf-1.0
  2024-03-24 21:49 [PR PATCH] New package: font-comic-mono-ttf-1.0 Zeitsperre
@ 2024-03-26 17:40 ` ahesford
  2024-03-27 16:20 ` Zeitsperre
  1 sibling, 0 replies; 3+ messages in thread
From: ahesford @ 2024-03-26 17:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/49515#issuecomment-2021080577

Comment:
What does this font provide besides different esthetics? We note in the linked packaging requirements document that this is not a sufficient criterion for packaging fonts.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New package: font-comic-mono-ttf-1.0
  2024-03-24 21:49 [PR PATCH] New package: font-comic-mono-ttf-1.0 Zeitsperre
  2024-03-26 17:40 ` ahesford
@ 2024-03-27 16:20 ` Zeitsperre
  1 sibling, 0 replies; 3+ messages in thread
From: Zeitsperre @ 2024-03-27 16:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by Zeitsperre on void-packages repository

https://github.com/void-linux/void-packages/pull/49515#issuecomment-2023183256

Comment:
My bad, it's solely different aesthetics. My goal was to follow the steps required to package for Void Linux as well as add a new (nicer, IMO) font. Feel free to reject if that's insufficient justification. Thanks all the same.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-27 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-24 21:49 [PR PATCH] New package: font-comic-mono-ttf-1.0 Zeitsperre
2024-03-26 17:40 ` ahesford
2024-03-27 16:20 ` Zeitsperre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).