[PR PATCH] New package: iamb-0.0.9

[PR PATCH] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages iamb
https://github.com/void-linux/void-packages/pull/49652

New package: iamb-0.0.9
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

closes #49586



A patch file from https://github.com/void-linux/void-packages/pull/49652.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iamb-49652.patch --]
[-- Type: text/x-diff, Size: 938 bytes --]

From e127c4bd627bc695f9f6ea9c51b2b685114d673c Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 1 Apr 2024 16:58:43 +0200
Subject: [PATCH] New package: iamb-0.0.9

---
 srcpkgs/iamb/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/iamb/template

diff --git a/srcpkgs/iamb/template b/srcpkgs/iamb/template
new file mode 100644
index 00000000000000..3ed60bfd100c52
--- /dev/null
+++ b/srcpkgs/iamb/template
@@ -0,0 +1,13 @@
+# Template file for 'iamb'
+pkgname=iamb
+version=0.0.9
+revision=1
+build_style=cargo
+hostmakedepends="pkg-config"
+makedepends="oniguruma-devel sqlite-devel"
+short_desc="Matrix client for Vim addicts"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="Apache-2.0"
+homepage="https://iamb.chat/"
+distfiles="https://github.com/ulyssa/iamb/archive/refs/tags/v${version}.tar.gz"
+checksum=7ef6d23a957bfab62decd48caa83c106a49d95760b4b2ccf5a6b6a8f4506e687

Re: New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#issuecomment-2041502809

Comment:
Tested on x86_64-glibc, joined a room and sent a message. Works as expected!

Re: [PR REVIEW] New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

New review comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1554996018

Comment:
The .desktop file, example config, and man pages could be included here as well
https://github.com/ulyssa/iamb/blob/main/PACKAGING.md#documentation
(not sure about the icons?)
```suggestion
checksum=7ef6d23a957bfab62decd48caa83c106a49d95760b4b2ccf5a6b6a8f4506e687

post_install() {
	vinstall iamb.desktop 644 usr/share/applications
	vman docs/iamb.1
	vman docs/iamb.5
	vsconf config.example.toml
}
```

Re: [PR REVIEW] New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

New review comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1554996451

Comment:
Upstream recommends linking against system-wide packages. I haven't tested this myself though, nor do I know if it's a good idea or not
(likewise, no idea about the lto thing either)
https://github.com/ulyssa/iamb/blob/main/PACKAGING.md#linking-against-system-packages
```suggestion
build_style=cargo
configure_args="--no-default-features --features=native-tls"
```

Re: [PR REVIEW] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1555001149

Comment:
Oh yes, I completely forgot about looking up if there are any static files we could install.

I think we should install the icons too, I've seen some other packages doing the same thing.

Re: [PR REVIEW] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1555001698

Comment:
That probably makes sense, I'll see if I can make that work (we might need some additional make depends then).

Re: [PR PATCH] [Updated] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages iamb
https://github.com/void-linux/void-packages/pull/49652

New package: iamb-0.0.9
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

closes #49586



A patch file from https://github.com/void-linux/void-packages/pull/49652.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iamb-49652.patch --]
[-- Type: text/x-diff, Size: 1408 bytes --]

From 52896fe7e61affbad79c8f8b3dbc7b049f2b555a Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 1 Apr 2024 16:58:43 +0200
Subject: [PATCH] New package: iamb-0.0.9

---
 srcpkgs/iamb/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/iamb/template

diff --git a/srcpkgs/iamb/template b/srcpkgs/iamb/template
new file mode 100644
index 00000000000000..5a355ed7d752a3
--- /dev/null
+++ b/srcpkgs/iamb/template
@@ -0,0 +1,24 @@
+# Template file for 'iamb'
+pkgname=iamb
+version=0.0.9
+revision=1
+build_style=cargo
+configure_args="--no-default-features --features=native-tls"
+hostmakedepends="pkg-config"
+makedepends="oniguruma-devel sqlite-devel openssl-devel"
+short_desc="Matrix client for Vim addicts"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="Apache-2.0"
+homepage="https://iamb.chat/"
+distfiles="https://github.com/ulyssa/iamb/archive/refs/tags/v${version}.tar.gz"
+checksum=7ef6d23a957bfab62decd48caa83c106a49d95760b4b2ccf5a6b6a8f4506e687
+
+post_install() {
+	vinstall iamb.desktop 644 usr/share/applications
+	vinstall docs/iamb-256x256.png 644 usr/share/icons/hicolor/256x256/apps/iamb.png
+	vinstall docs/iamb-256x256.png 644 usr/share/icons/hicolor/256x256/apps/iamb.png
+	vinstall docs/iamb.svg 644 usr/share/icons/hicolor/scalable/apps/iamb.svg
+	vman docs/iamb.1
+	vman docs/iamb.5
+	vsconf config.example.toml
+}

Re: [PR REVIEW] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1555003155

Comment:
Seems to work :+1:

Re: [PR REVIEW] New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1555016070

Comment:
```suggestion
```

Re: New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#issuecomment-2041539506

Comment:
Super duper nitpick, but the manpage is technically wrong on void
https://github.com/ulyssa/iamb/blob/e5b284ed19cb99f79a0cbaca9e2339b9171e6d6d/docs/iamb.5#L541C1-L543C43

```roff
.Sy iamb
will load if the TOML one is not found.
.It Pa /usr/share/iamb/config.example.toml
A sample configuration file with examples of how to set different values.
.El
```
Should actually be `/usr/share/examples/iamb/config.example.toml`, with an added `examples/`

Re: New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#issuecomment-2041540016

Comment:
Tested it again with the lib changes and it still works

Re: New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#issuecomment-2041547097

Comment:
I guess we should report the test failure om i686 upstream?

Re: [PR REVIEW] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#discussion_r1555021156

Comment:
Oh, I wanted to make one 512x512 but forgot to change it after copy and paste 😉 

Re: [PR PATCH] [Updated] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages iamb
https://github.com/void-linux/void-packages/pull/49652

New package: iamb-0.0.9
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

closes #49586



A patch file from https://github.com/void-linux/void-packages/pull/49652.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iamb-49652.patch --]
[-- Type: text/x-diff, Size: 1458 bytes --]

From e3dc822e47ba903ebe543525d79ce40d436a64a5 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 1 Apr 2024 16:58:43 +0200
Subject: [PATCH] New package: iamb-0.0.9

---
 srcpkgs/iamb/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/iamb/template

diff --git a/srcpkgs/iamb/template b/srcpkgs/iamb/template
new file mode 100644
index 00000000000000..bfaee2aeeb5cea
--- /dev/null
+++ b/srcpkgs/iamb/template
@@ -0,0 +1,24 @@
+# Template file for 'iamb'
+pkgname=iamb
+version=0.0.9
+revision=1
+build_style=cargo
+configure_args="--no-default-features --features=native-tls"
+hostmakedepends="pkg-config"
+makedepends="oniguruma-devel sqlite-devel openssl-devel"
+short_desc="Matrix client for Vim addicts"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="Apache-2.0"
+homepage="https://iamb.chat/"
+distfiles="https://github.com/ulyssa/iamb/archive/refs/tags/v${version}.tar.gz"
+checksum=7ef6d23a957bfab62decd48caa83c106a49d95760b4b2ccf5a6b6a8f4506e687
+
+post_install() {
+	vinstall iamb.desktop 644 usr/share/applications
+	vinstall docs/iamb-256x256.png 644 usr/share/icons/hicolor/256x256/apps/iamb.png
+	vinstall docs/iamb-512x512.png 644 usr/share/icons/hicolor/512x512/apps/iamb.png
+	vinstall docs/iamb.svg 644 usr/share/icons/hicolor/scalable/apps/iamb.svg
+	vinstall config.example.toml 644 usr/share/examples/iamb/config.example.toml
+	vman docs/iamb.1
+	vman docs/iamb.5
+}

Re: New package: iamb-0.0.9

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

New comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/49652#issuecomment-2041597505

Comment:
> I guess we should report the test failure om i686 upstream?

I've let them know on matrix that the one test is failing on 32bit (I assume it would fail on armv* as well if the CI would run those tests)

--

About my earlier comment on the manpage, what I meant to say is that maybe the manpage should be vsed'd to change that one line. Something like this for example

```sh
vsed -i docs/iamb.5 -e 's#/usr/share/iamb/config.example.toml#/usr/share/examples/iamb/config.example.toml#'
```

You should still vsconf the file though, that part was correct

Re: [PR PATCH] [Updated] New package: iamb-0.0.9

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages iamb
https://github.com/void-linux/void-packages/pull/49652

New package: iamb-0.0.9
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

closes #49586



A patch file from https://github.com/void-linux/void-packages/pull/49652.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iamb-49652.patch --]
[-- Type: text/x-diff, Size: 1526 bytes --]

From ea5fdbd4f5fe8bcb8ac945191d6a96f371408ceb Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Mon, 1 Apr 2024 16:58:43 +0200
Subject: [PATCH] New package: iamb-0.0.9

---
 srcpkgs/iamb/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/iamb/template

diff --git a/srcpkgs/iamb/template b/srcpkgs/iamb/template
new file mode 100644
index 00000000000000..58f824850865d2
--- /dev/null
+++ b/srcpkgs/iamb/template
@@ -0,0 +1,27 @@
+# Template file for 'iamb'
+pkgname=iamb
+version=0.0.9
+revision=1
+build_style=cargo
+configure_args="--no-default-features --features=native-tls"
+hostmakedepends="pkg-config"
+makedepends="oniguruma-devel sqlite-devel openssl-devel"
+short_desc="Matrix client for Vim addicts"
+maintainer="Bnyro <bnyro@tutanota.com>"
+license="Apache-2.0"
+homepage="https://iamb.chat/"
+distfiles="https://github.com/ulyssa/iamb/archive/refs/tags/v${version}.tar.gz"
+checksum=7ef6d23a957bfab62decd48caa83c106a49d95760b4b2ccf5a6b6a8f4506e687
+
+post_install() {
+	vinstall iamb.desktop 644 usr/share/applications
+	vinstall docs/iamb-256x256.png 644 usr/share/icons/hicolor/256x256/apps/iamb.png
+	vinstall docs/iamb-512x512.png 644 usr/share/icons/hicolor/512x512/apps/iamb.png
+	vinstall docs/iamb.svg 644 usr/share/icons/hicolor/scalable/apps/iamb.svg
+
+	vsed -i docs/iamb.5 -e 's#/usr/share/iamb/config.example.toml#/usr/share/examples/iamb/config.example.toml#'
+	vman docs/iamb.1
+	vman docs/iamb.5
+
+	vsconf config.example.toml
+}